[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-18 Thread Tetsuya Mukawa
On 2015/02/18 10:09, Thomas Monjalon wrote: > 2015-02-17 15:15, Tetsuya Mukawa: >> On 2015/02/17 10:11, Thomas Monjalon wrote: >>> 2015-02-16 13:14, Tetsuya Mukawa: +#ifdef ENABLE_HOTPLUG >>> Please avoid using #ifdef if not really necessary. >> I agree with you. >> In this case, only hotplug

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-18 Thread Thomas Monjalon
2015-02-17 15:15, Tetsuya Mukawa: > On 2015/02/17 10:11, Thomas Monjalon wrote: > > 2015-02-16 13:14, Tetsuya Mukawa: > >> +#ifdef ENABLE_HOTPLUG > > Please avoid using #ifdef if not really necessary. > > I agree with you. > In this case, only hotplug functions call pci_unmap_resource(). > So

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/17 10:11, Thomas Monjalon wrote: > 2015-02-16 13:14, Tetsuya Mukawa: >> The patch adds functions for unmapping igb_uio resources. The patch is only >> for Linux and igb_uio environment. VFIO and BSD are not supported. >> >> v8: >> - Fix typo. >> (Thanks to Iremonger, Bernard) >> v5:

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-17 Thread Tetsuya Mukawa
On 2015/02/16 21:45, Neil Horman wrote: > On Mon, Feb 16, 2015 at 01:14:27PM +0900, Tetsuya Mukawa wrote: >> The patch adds functions for unmapping igb_uio resources. The patch is only >> for Linux and igb_uio environment. VFIO and BSD are not supported. >> >> v8: >> - Fix typo. >> (Thanks to

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-17 Thread Thomas Monjalon
2015-02-16 13:14, Tetsuya Mukawa: > The patch adds functions for unmapping igb_uio resources. The patch is only > for Linux and igb_uio environment. VFIO and BSD are not supported. > > v8: > - Fix typo. > (Thanks to Iremonger, Bernard) > v5: > - Fix pci_unmap_device() to check pt_driver. > v4:

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-16 Thread Iremonger, Bernard
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Monday, February 16, 2015 4:14 AM > To: dev at dpdk.org > Cc: Qiu, Michael; Iremonger, Bernard; Tetsuya Mukawa > Subject: [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio > resources > >

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-16 Thread Tetsuya Mukawa
The patch adds functions for unmapping igb_uio resources. The patch is only for Linux and igb_uio environment. VFIO and BSD are not supported. v8: - Fix typo. (Thanks to Iremonger, Bernard) v5: - Fix pci_unmap_device() to check pt_driver. v4: - Add parameter checking. - Add header file to

[dpdk-dev] [PATCH v8 08/14] eal/linux/pci: Add functions for unmapping igb_uio resources

2015-02-16 Thread Neil Horman
On Mon, Feb 16, 2015 at 01:14:27PM +0900, Tetsuya Mukawa wrote: > The patch adds functions for unmapping igb_uio resources. The patch is only > for Linux and igb_uio environment. VFIO and BSD are not supported. > > v8: > - Fix typo. > (Thanks to Iremonger, Bernard) > v5: > - Fix