[dpdk-dev] [PATCH v9 1/9] nfp: basic initialization

2015-11-27 07:51, Alejandro Lucero: > I converted (almost) all the Linux typedefs. This one went under the radar. > > We do not have such thing like ixgbe/base but maybe it makes sense. > > Should I send a new patchset version for fixing this "minor nit"? If you send a new version, please fix

[dpdk-dev] [PATCH v9 1/9] nfp: basic initialization

I converted (almost) all the Linux typedefs. This one went under the radar. We do not have such thing like ixgbe/base but maybe it makes sense. Should I send a new patchset version for fixing this "minor nit"? Thanks On Thu, Nov 26, 2015 at 6:14 PM, Stephen Hemminger < stephen at

[dpdk-dev] [PATCH v9 1/9] nfp: basic initialization

On Thu, 26 Nov 2015 09:49:21 + Alejandro Lucero wrote: > +static inline void > +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val) > +{ > + uint32_t off; Minor nit. why mix use of Linux specific basic size typedefs (__u8) with Posix standard values (uint32_t). The DPDK style

[dpdk-dev] [PATCH v9 1/9] nfp: basic initialization

Signed-off-by: Alejandro Lucero Signed-off-by: Rolf Neugebauer --- MAINTAINERS |3 + config/common_linuxapp |6 + doc/guides/rel_notes/release_2_2.rst|4 + drivers/net/Makefile|1 + drivers/net/nfp/Makefile