On 2015-06-04 23:27, Chilikin, Andrey wrote:
>> Its not a bad addition, I'm just not sure its worth having to take on the
>> additional API surface to include. I'd be more supportive if you could
>> enhance
>> the function to allow the previously mentioned before/after flexibiilty.
>> Then w
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman
> Sent: Thursday, June 4, 2015 2:56 PM
> To: Wiles, Keith
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at
> rte_eal_init time
>
On Thu, Jun 4, 2015 at 4:27 PM, Wiles, Keith wrote:
> Hi Neil and Stephen,
>
> I agree this is not saving instructions and adding performance, but of
> code clutter and providing a layered model for the developer. The
> rte_eal_init() routine still exists and I was not trying to remove that
> API
Hmmm, replied in HTML.
>On Thu, Jun 4, 2015 at 4:27 PM, Wiles, Keith
> wrote:
>
>Hi Neil and Stephen,
>
>I agree this is not saving instructions and adding performance, but of
>code clutter and providing a layered model for the developer. The
>rte_eal_init() routine still exists and I was not tryi
org>>
Subject: Re: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at
rte_eal_init time
On Thu, Jun 4, 2015 at 4:27 PM, Wiles, Keith mailto:keith.wiles at intel.com>> wrote:
Hi Neil and Stephen,
I agree this is not saving instructions and adding performance, but of
code clutter a
Hi Neil and Stephen,
On 6/4/15, 8:55 AM, "Neil Horman" wrote:
>On Thu, Jun 04, 2015 at 11:50:33AM +, Wiles, Keith wrote:
>> Hi Stephen
>>
>> On 6/3/15, 7:12 PM, "Stephen Hemminger"
>>wrote:
>>
>> >On Wed, 3 Jun 2015 13:49:53 -0500
>> >Keith Wiles wrote:
>> >
>> >> +/* Launch threads, ca
On 6/4/15 9:55 AM, Neil Horman wrote:
> On Thu, Jun 04, 2015 at 11:50:33AM +, Wiles, Keith wrote:
>> Hi Stephen
>>
>> On 6/3/15, 7:12 PM, "Stephen Hemminger"
>> wrote:
>>
>>> On Wed, 3 Jun 2015 13:49:53 -0500
>>> Keith Wiles wrote:
>>>
+/* Launch threads, called at application init()
Hi Stephen
On 6/3/15, 7:12 PM, "Stephen Hemminger" wrote:
>On Wed, 3 Jun 2015 13:49:53 -0500
>Keith Wiles wrote:
>
>> +/* Launch threads, called at application init() and parse app args. */
>> +int
>> +rte_eal_init_parse(int argc, char **argv,
>> +int (*parse)(int, char **))
>> +{
On Thu, Jun 04, 2015 at 11:50:33AM +, Wiles, Keith wrote:
> Hi Stephen
>
> On 6/3/15, 7:12 PM, "Stephen Hemminger" wrote:
>
> >On Wed, 3 Jun 2015 13:49:53 -0500
> >Keith Wiles wrote:
> >
> >> +/* Launch threads, called at application init() and parse app args. */
> >> +int
> >> +rte_eal_in
On Thu, 4 Jun 2015 09:55:42 -0400
Neil Horman wrote:
> That said, I'm not sure theres much value in adding this to the API. For one,
> it implies that dpdk arguments need to come first on the command line. While
> all the example applications do that, theres no requirement that they do so,
> a
Hi Keith,
2015-06-03 13:49, Keith Wiles:
> Signed-off-by: Keith Wiles
> ---
> lib/librte_eal/bsdapp/eal/eal.c | 20
> lib/librte_eal/common/include/rte_eal.h | 32
> 2 files changed, 52 insertions(+)
These comments would be useful:
A
On 6/3/15, 2:24 PM, "Thomas Monjalon" wrote:
>Hi Keith,
>
>2015-06-03 13:49, Keith Wiles:
>> Signed-off-by: Keith Wiles
>> ---
>> lib/librte_eal/bsdapp/eal/eal.c | 20
>> lib/librte_eal/common/include/rte_eal.h | 32
>>
>> 2 files c
On Wed, 3 Jun 2015 13:49:53 -0500
Keith Wiles wrote:
> +/* Launch threads, called at application init() and parse app args. */
> +int
> +rte_eal_init_parse(int argc, char **argv,
> + int (*parse)(int, char **))
> +{
> + int ret;
> +
> + ret = rte_eal_init(argc, argv);
> +
Signed-off-by: Keith Wiles
---
lib/librte_eal/bsdapp/eal/eal.c | 20
lib/librte_eal/common/include/rte_eal.h | 32
2 files changed, 52 insertions(+)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index
14 matches
Mail list logo
