[dpdk-dev] Clarification for eth_driver changes

2016-11-16 Thread Shreyansh Jain
On Monday 14 November 2016 11:08 PM, Ferruh Yigit wrote: [...] > What I was thinking is: > > rte_device/driver are not abstract classes. > > rte_bus device/driver is an abstract class and any bus inherited from > this class. > rte_func device/driver is and abstract class and eth/crypto inherited >

[dpdk-dev] Clarification for eth_driver changes

2016-11-14 Thread David Marchand
On Fri, Nov 11, 2016 at 8:16 PM, Ferruh Yigit wrote: > On 11/10/2016 11:05 AM, Shreyansh Jain wrote: >> On Thursday 10 November 2016 01:46 PM, David Marchand wrote: >>> Do we really need to keep a eth_driver ? >> >> No. As you have rightly mentioned below (as well as in your Jan'16 >> post), it

[dpdk-dev] Clarification for eth_driver changes

2016-11-12 Thread Shreyansh Jain
> > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] Clarification for eth_driver changes > > On 11/10/2016 11:05 AM, Shreyansh Jain wrote: > > Hello David, > > > > On Thursday 10 November 2016 01:46 PM, David Marchand wrote: > >> Hello Shreyansh, > >>

[dpdk-dev] Clarification for eth_driver changes

2016-11-11 Thread Ferruh Yigit
On 11/10/2016 11:05 AM, Shreyansh Jain wrote: > Hello David, > > On Thursday 10 November 2016 01:46 PM, David Marchand wrote: >> Hello Shreyansh, >> >> On Thu, Nov 10, 2016 at 8:26 AM, Shreyansh Jain >> wrote: >>> I need some help and clarification regarding some changes I am doing to >>>

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Jianbo Liu
Hi Thomas, On 10 November 2016 at 16:58, Thomas Monjalon wrote: > 2016-11-10 14:12, Shreyansh Jain: >> On Thursday 10 November 2016 01:33 PM, Thomas Monjalon wrote: >> > 2016-11-10 15:51, Jianbo Liu: >> >> On 10 November 2016 at 15:26, Shreyansh Jain >> >> wrote: >> >>> This is what the

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
Hello David, On Thursday 10 November 2016 01:46 PM, David Marchand wrote: > Hello Shreyansh, > > On Thu, Nov 10, 2016 at 8:26 AM, Shreyansh Jain > wrote: >> I need some help and clarification regarding some changes I am doing to >> cleanup the EAL code. >> >> There are some changes which should

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Jianbo Liu
On 10 November 2016 at 15:26, Shreyansh Jain wrote: > Hello David, list, > > I need some help and clarification regarding some changes I am doing to > cleanup the EAL code. > > There are some changes which should be done for eth_driver/rte_eth_device > structures: > > 1. most obvious, eth_driver

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 01:33 PM, Thomas Monjalon wrote: > 2016-11-10 15:51, Jianbo Liu: >> On 10 November 2016 at 15:26, Shreyansh Jain >> wrote: >>> This is what the current outline of eth_driver is: >>> >>> ++ >>> | eth_driver | >>> |

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
On Thursday 10 November 2016 01:21 PM, Jianbo Liu wrote: > On 10 November 2016 at 15:26, Shreyansh Jain > wrote: >> Hello David, list, >> >> I need some help and clarification regarding some changes I am doing to >> cleanup the EAL code. >> >> There are some changes which should be done for

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Shreyansh Jain
Hello David, list, I need some help and clarification regarding some changes I am doing to cleanup the EAL code. There are some changes which should be done for eth_driver/rte_eth_device structures: 1. most obvious, eth_driver should be renamed to rte_eth_driver. 2. eth_driver currently has

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Thomas Monjalon
Hi Stephen, 2016-11-10 02:51, Stephen Hemminger: > I also think drv_flags should part of device not PCI. Most of the flags > there like link state support are generic. If it isn't changed for this > release will probably have to break ABI to fully support VMBUS When do you plan to send VMBUS

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread David Marchand
Hello Shreyansh, On Thu, Nov 10, 2016 at 8:26 AM, Shreyansh Jain wrote: > I need some help and clarification regarding some changes I am doing to > cleanup the EAL code. > > There are some changes which should be done for eth_driver/rte_eth_device > structures: > > 1. most obvious, eth_driver

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Thomas Monjalon
2016-11-10 15:51, Jianbo Liu: > On 10 November 2016 at 15:26, Shreyansh Jain > wrote: > > This is what the current outline of eth_driver is: > > > > ++ > > | eth_driver | > > | +-+| > > | | rte_pci_driver || > > | |

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Stephen Hemminger
I also think drv_flags should part of device not PCI. Most of the flags there like link state support are generic. If it isn't changed for this release will probably have to break ABI to fully support VMBUS

[dpdk-dev] Clarification for eth_driver changes

2016-11-10 Thread Thomas Monjalon
2016-11-10 14:12, Shreyansh Jain: > On Thursday 10 November 2016 01:33 PM, Thomas Monjalon wrote: > > 2016-11-10 15:51, Jianbo Liu: > >> On 10 November 2016 at 15:26, Shreyansh Jain > >> wrote: > >>> This is what the current outline of eth_driver is: > >>> > >>> ++ > >>>