[dpdk-dev] igb PMD should set the default tx wthresh correctly.

2015-07-20 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Wiles, Keith > Sent: Friday, July 17, 2015 7:06 PM > To: Thomas Monjalon; Stephen Hemminger; Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] igb PMD should set the default tx wthresh correctly. > > > > On 7/

[dpdk-dev] igb PMD should set the default tx wthresh correctly.

2015-07-17 Thread Wiles, Keith
On 7/17/15, 9:15 AM, "dev on behalf of Thomas Monjalon" wrote: >2015-07-16 19:49, Stephen Hemminger: >> On Fri, 17 Jul 2015 00:52:09 + >> "Lu, Wenzhuo" wrote: >> >> > Hi Stephen, >> > I don't think there's a conflict. The message just reminder us that >>we can adjust the values to

[dpdk-dev] igb PMD should set the default tx wthresh correctly.

2015-07-16 Thread Stephen Hemminger
On Fri, 17 Jul 2015 00:52:09 + "Lu, Wenzhuo" wrote: > Hi Stephen, > I don't think there's a conflict. The message just reminder us that we can > adjust the values to achieve better performance. > I saw ixgbe and i40e also use 0 as the same default value. To my opinion, > it's good to keep

[dpdk-dev] igb PMD should set the default tx wthresh correctly.

2015-07-16 Thread Stephen Hemminger
Why doesn't igb driver set the wthresh it wants as default? I see: PMD: eth_igb_tx_queue_setup(): To improve 1G driver performance, consider setting the TX WTHRESH value to 4, 8, or 16. But the default tx_conf has wthresh of 0. #define IGB_DEFAULT_TX_WTHRESH 0 Either