[dpdk-dev] problem vhost-user sockets

2015-12-16 Thread Yuanhan Liu
On Tue, Dec 15, 2015 at 05:21:25PM +0300, Pavel Fedin wrote: > Hello! > > > I'm thinking you can't simply unlink a file given by a user inside > > a libraray unconditionaly. Say, what if a user gives a wrong socket > > path? > > Well... We can improve the security by checking that: > > a) The

[dpdk-dev] problem vhost-user sockets

2015-12-15 Thread Yuanhan Liu
On Tue, Dec 15, 2015 at 03:41:23PM +0300, Pavel Fedin wrote: > Hello! > > I have a question regarding vhostuser. If we cannot bind to a socket, why do > we simply fail with error instead of just unlink()ing > the path before binding? I'm thinking you can't simply unlink a file given by a user

[dpdk-dev] problem vhost-user sockets

2015-12-15 Thread Pavel Fedin
Hello! > I'm thinking you can't simply unlink a file given by a user inside > a libraray unconditionaly. Say, what if a user gives a wrong socket > path? Well... We can improve the security by checking that: a) The file exists and it's a socket. b) Nobody is listening on it. > I normally writ

[dpdk-dev] problem vhost-user sockets

2015-12-15 Thread Xie, Huawei
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pavel Fedin > Sent: Tuesday, December 15, 2015 10:21 PM > To: 'Yuanhan Liu' > Cc: dev at dpdk.org; 'Ilya Maximets'; 'Dyasly Sergey' > Subject: Re: [dpdk-dev] pr

[dpdk-dev] problem vhost-user sockets

2015-12-15 Thread Pavel Fedin
Hello! I have a question regarding vhostuser. If we cannot bind to a socket, why do we simply fail with error instead of just unlink()ing the path before binding? This causes a very annoying problem with ovs. After ovs is stopped (i use supplied system integration), these sockets are not rem