[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/396#discussion_r55117425 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -1392,6 +1387,198 @@ void DrillClientQueryResult::clearAndDestroy(){ }

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/396#discussion_r55117339 --- Diff: contrib/native/client/example/pooledConnections.cpp --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/396#discussion_r55117302 --- Diff: contrib/native/client/example/pooledConnections.cpp --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: Time for the 1.6 Release

Okay here's the list of JIRA's pending. It looks like we need to get some more time to get the PRs still under review merged, so I'll wait over the weekend. It looks like the PRs that no reviewers assigned in the list below may not make it into the release. Thanks Committed for 1.6 -

Re: Time for the 1.6 Release

Awesome. Thanks Chun! On Mar 4, 2016 5:51 PM, "Chun Chang" wrote: > Jacques submitted a PR for fixing the failed baselines. I've merged them > into automation master and confirmed the failed tests are all passing now. > Thanks. > > -Chun > > > On Thu, Mar 3, 2016 at 10:48

Re: Time for the 1.6 Release

Jacques submitted a PR for fixing the failed baselines. I've merged them into automation master and confirmed the failed tests are all passing now. Thanks. -Chun On Thu, Mar 3, 2016 at 10:48 PM, Jacques Nadeau wrote: > I think we need to include DRILL-4467 >

[jira] [Created] (DRILL-4479) JsonReader should pick a less restrictive type when creating the default column

Aman Sinha created DRILL-4479: - Summary: JsonReader should pick a less restrictive type when creating the default column Key: DRILL-4479 URL: https://issues.apache.org/jira/browse/DRILL-4479 Project:

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/396#discussion_r55112200 --- Diff: contrib/native/client/example/pooledConnections.cpp --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/396#discussion_r55112202 --- Diff: contrib/native/client/example/pooledConnections.cpp --- @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/396#discussion_r55112213 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -1392,6 +1387,198 @@ void DrillClientQueryResult::clearAndDestroy(){ }

[jira] [Created] (DRILL-4478) binary_string cannot convert buffer that were not start from 0 correctly

Chunhui Shi created DRILL-4478: -- Summary: binary_string cannot convert buffer that were not start from 0 correctly Key: DRILL-4478 URL: https://issues.apache.org/jira/browse/DRILL-4478 Project: Apache

[GitHub] drill pull request: DRILL-4281: Support authorized proxy users to ...

Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-192538620 @jacques-n can you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-192535617 I apologize that my terminology is confusing everyone. I've updated the [design

[jira] [Created] (DRILL-4477) Wrong Plan (potentially wrong result) if wrapping a query with SELECT * FROM

Sean Hsuan-Yi Chu created DRILL-4477: Summary: Wrong Plan (potentially wrong result) if wrapping a query with SELECT * FROM Key: DRILL-4477 URL: https://issues.apache.org/jira/browse/DRILL-4477

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/406#issuecomment-192531157 +1. Yes, seems like the project was not being checked at all and the nullability check did not work for expressions inside the count aggregate. --- If your

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r55106082 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -88,6 +89,7 @@ String USER_AUTHENTICATION_ENABLED =

[GitHub] drill pull request: DRILL-4476: Allow UnionAllRecordBatch to manag...

Github user hsuanyi commented on the pull request: https://github.com/apache/drill/pull/407#issuecomment-192523111 @amansinha100 can you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request: DRILL-4476: Allow UnionAllRecordBatch to manag...

GitHub user hsuanyi opened a pull request: https://github.com/apache/drill/pull/407 DRILL-4476: Allow UnionAllRecordBatch to manager situations where lef… …t input side or both sides come(s) from empty source(s). You can merge this pull request into a Git repository by running:

[jira] [Created] (DRILL-4476) Enhance Union-All operator for dealing with empty left input or empty both inputs

Sean Hsuan-Yi Chu created DRILL-4476: Summary: Enhance Union-All operator for dealing with empty left input or empty both inputs Key: DRILL-4476 URL: https://issues.apache.org/jira/browse/DRILL-4476

[GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...

GitHub user jacques-n opened a pull request: https://github.com/apache/drill/pull/406 DRILL-4474: Ensure that ConvertCountToDirectScan only pushes through project when project is trivial. There are probably additional optimizations here but as the code stood, we completely ignored

[jira] [Created] (DRILL-4475) Joins containing join key between varbinary and non-varbinary fails

Krystal created DRILL-4475: -- Summary: Joins containing join key between varbinary and non-varbinary fails Key: DRILL-4475 URL: https://issues.apache.org/jira/browse/DRILL-4475 Project: Apache Drill

[jira] [Created] (DRILL-4474) Inconsistent behavior while using COUNT in select (Apache drill 1.2.0)

Shankar created DRILL-4474: -- Summary: Inconsistent behavior while using COUNT in select (Apache drill 1.2.0) Key: DRILL-4474 URL: https://issues.apache.org/jira/browse/DRILL-4474 Project: Apache Drill

Re: Heads up on trivial project fix: plan baselines in regression suite need updating

I think it is ~40 in our suite. Not sure on yours. If you have a failed run on your side, share the output and I may be able to propose a patch to your suite: It is a one line change.

Re: Heads up on trivial project fix: plan baselines in regression suite need updating

I think it depends on which cluster. I saw 8 failures on most of the clusters, but 44 failures on one cluster. I guess all of them need to be looked at and modified. On Fri, Mar 4, 2016 at 10:35 AM, Parth Chandra wrote: > I'd be more comfortable if we merged this in after the

Re: Heads up on trivial project fix: plan baselines in regression suite need updating

I'd be more comfortable if we merged this in after the release. Updating the test baselines will delay the release considerably - I would want the new baselines to be verified manually which is always time consuming. How many tests are affected? On Fri, Mar 4, 2016 at 10:03 AM, Jacques Nadeau

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user kbotzum commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-192389699 Sorry to be dense, but what are the Hadoop terms? In my understanding Hadoop uses the term impersonation to mean what I'm calling outbound impersonation. I'm not aware

Re: Heads up on trivial project fix: plan baselines in regression suite need updating

Do you think we should back out? It seemed like this could likely cause correctness issues although we may be safe with our name based resolution. On Mar 4, 2016 9:56 AM, "Aman Sinha" wrote: > @jacques, thanks for the heads-up, although it comes too close to the > release

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user NeerajaRentachintala commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-192382894 Folks Why do we need to invent new terms here. What Drill is trying to here is a very common use case for other tools in Hadoop eco system as well.

Re: Heads up on trivial project fix: plan baselines in regression suite need updating

@jacques, thanks for the heads-up, although it comes too close to the release date :). I agree that the plan tests should be targeted to a narrow scope by specifying the sub-pattern it is supposed to test. That said, it is a lot easier for the tester to capture the entire plan since he/she may

[GitHub] drill pull request: DRILL-4449: Wrong results when metadata cache ...

Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/392#issuecomment-192361296 +1. I understand based on conversation with @adeneche (before he went on vacation) that he could not easily repro through a unit test. However, functional

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/403#issuecomment-192332765 Patch update. + Address review comments including unittest for HardAffinityFragmentParallelizer + Fix Limit0 issue when one of the GroupScans in limit0 query

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user kbotzum commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-192320077 One suggestion. The terms I use when discussing the concepts with customers are Drill inbound impersonation and Drill outbound impersonation. That is absolutely clear.

Heads up on trivial project fix: plan baselines in regression suite need updating

I just merged a simple fix that Laurent found for DRILL-4467. This fix ensures consistent column ordering when pushing projection into a scan and invalid plans. This is good and was causing excessive operators and pushdown failure in some cases. However, this fix removes a number of trivial

[jira] [Resolved] (DRILL-4467) Invalid projection created using PrelUtil.getColumns

[ https://issues.apache.org/jira/browse/DRILL-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Nadeau resolved DRILL-4467. --- Resolution: Fixed Fixed with edea8b1cf4e5476d803e8b87c79e08e8c3263e04 > Invalid projection