It seems like we are reaching a conclusion here in terms of starting with a
simpler implementation i.e being able to deploy UDFs dynamically without
Drillbit restarts based off a jars in DFS location. Dropping functions
dynamically is out of scope for version 1 of this feature (we assume
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71825128
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -267,6 +276,15 @@ private TransferPair
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/534#discussion_r71823822
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -90,6 +91,62 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/549#discussion_r71816190
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java ---
@@ -1195,4 +1195,25 @@ public void testDateImplicitCasting() throws
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/534#discussion_r71816185
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -90,6 +91,62 @@ public void validate(OptionValue v) {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/551#discussion_r71811276
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -176,12 +176,18 @@ message QueryData {
optional RecordBatchDef def = 3;
}
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/551#discussion_r71810483
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -107,6 +107,42 @@
FOREMAN:
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/426#discussion_r71810206
--- Diff:
exec/interpreter/src/test/java/org/apache/drill/exec/expr/TestPrune.java ---
@@ -1,38 +0,0 @@
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/502
@jcmote can you please close this PR?
The changes were merged as part of #512
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/541
tl;dr +1, please open a ticket.
Moving conversation. Vitalii said:
> I checked every schema#getTable and found that every method can throw
exception only if something go wrong
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/545
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/546
I picked the latest commit, and am running the regression. Will merge to
master if everything runs fine.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/546
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Hi,
Good Afternoon!
I work as an engineer at Symantec. My team works on Multi-tenant Event
Processing System. Just a high level background, our customers write data to
kafka brokers though agents like logstash and we process the events and save
the log data in Elastic Search and S3.
Use
Avatica has changed a lot since Drill first started using it. Now its default
wire format is protobuf (driven by the need for something more compact and
efficient than JSON, and also better at supporting mismatched client/server
versions) and there are also a bunch of improvements relating to
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/546
Thanks, @jaltekruse . I'll make the change you recommended, and squashed
into Chunhui's patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Khurram Faraaz created DRILL-4797:
-
Summary: Partition by aggregate function in a window query results
in IllegalStateException
Key: DRILL-4797
URL: https://issues.apache.org/jira/browse/DRILL-4797
Recognize the difficulty. Not suggesting this be addressed in first
version. Just suggesting some thought about how a real user will
workaround. Maybe some doc and/or small changes can make this easier.
Keys
___
Keys Botzum
Senior Principal Technologist
Github user jaltekruse commented on the issue:
https://github.com/apache/drill/pull/546
One small last comment. The method testNoResult() doesn't actually verify
that they query has no results, it just ignores whatever the query returns. I
would recommend instead using the
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/546
+1
Overall LGTM.
@jaltekruse , do you have any further comment? thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/546#discussion_r71760001
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/flatten/FlattenRecordBatch.java
---
@@ -267,10 +276,21 @@ private TransferPair
Hi All,
By the way, the class loading/unloading issue, while new to us Drillers, is a
well-known technology in projects such as Tomcat which loads & unloads web
apps, each with their own class name space (implemented by a class loader.)
To make the dynamic UDF function fully usable, we’d need
[
https://issues.apache.org/jira/browse/DRILL-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aman Sinha resolved DRILL-4794.
---
Resolution: Fixed
Fix Version/s: 1.8.0
Fixed in commit #: 4377670
> Regression: Wrong result
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Hi All,
Adding a dynamic DROP would, of course, be a great addition! The reason for
suggesting we skip that was to control project scope.
Dynamic DROP requires a synchronization step. Here’s the scenario:
* Foreman A starts a query using UDF U.
* Foreman B receives a request to drop UDF U,
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/550
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Neeraja,
Can you clarify your "requirements", specifically
So any design that requires restarts I would think would beat the purpose.
Earlier in the thread, Paul had suggested deferring dynamic DROP FUNCTION
from v1 because of the complexity of class unloading. However, Keys notes
that if that
The whole point of this feature is to avoid Drill cluster restarts as the
name indicates 'Dynamic' UDFs.
So any design that requires restarts I would think would beat the purpose.
I also think this is an example of a feature we start with a simple design
to serve the purpose, take feedback on how
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/551
DRILL-4792: Include session options used for a query as part of the pâ¦
â¦rofile
You can merge this pull request into a Git repository by running:
$ git pull
I think there are a lot of great ideas here. My one concern is the lack of
unload and thus presumably replace functionality. I'm just thinking about
typical actual usage.
In a typical development cycle someone writes something, tries it, learns,
changes it, and tries again. Assuming I
Khurram Faraaz created DRILL-4796:
-
Summary: AssertionError - Nested sum(avg(c1)) over window
Key: DRILL-4796
URL: https://issues.apache.org/jira/browse/DRILL-4796
Project: Apache Drill
Khurram Faraaz created DRILL-4795:
-
Summary: Nested aggregate windowed query fails -
IllegalStateException
Key: DRILL-4795
URL: https://issues.apache.org/jira/browse/DRILL-4795
Project: Apache Drill
[
https://issues.apache.org/jira/browse/DRILL-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roman Lozovyk resolved DRILL-4744.
--
Resolution: Fixed
Fix Version/s: 1.7.0
This issue can be reproduced on drill 1.6.0, but
Always good to have options… Another is to try an eventual consistency model.
The invariant here is the one that was mentioned earlier. Whenever a query is
submitted with UDF U, that query either fails in planning (because U is
unknown) or succeeds on all nodes (at least with respect to U.)
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/546
Update based on Jinfeng's comment. Jinfeng, could you check if I addressed
your concern? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user amansinha100 opened a pull request:
https://github.com/apache/drill/pull/550
DRILL-4794: Fix a premature exit of the outer loop during pruning.
You can merge this pull request into a Git repository by running:
$ git pull
37 matches
Mail list logo
