[GitHub] drill issue #602: Improve Drill C++ connector

2016-10-19 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/602 I just put the FindCppUnit hack in my branch here: https://github.com/parthchandra/drill/tree/DRILL-4420 I hit another issue (bit of a show stopper) with windows. In order to get on with the

[GitHub] drill issue #624: Fix printing Strings when `allTextMode` is ON for MapR-DB ...

2016-10-19 Thread Ben-Zvi
Github user Ben-Zvi commented on the issue: https://github.com/apache/drill/pull/624 LGTM (also tested this change -- worked as expected). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: ZK lost connectivity issue on large cluster

2016-10-19 Thread François Méthot
We had problem on the 220 nodes cluster. No problem on the 12 nodes cluster. I agree that the data may not be distributed evenly. It would be a long and tedious process for me to produce a report. Here is a drawing of the fragments overview before and after the changes of the affinity factory

[GitHub] drill pull request #624: Fix printing Strings when `allTextMode` is ON for M...

2016-10-19 Thread spanchamiamapr
GitHub user spanchamiamapr opened a pull request: https://github.com/apache/drill/pull/624 Fix printing Strings when `allTextMode` is ON for MapR-DB JSON tables. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill issue #602: Improve Drill C++ connector

2016-10-19 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/602 Thanks @parthchandra for the feedback 1) I'm still struggling having a working Windows dev environment. Regarding CppUnit, it seems the LibreOffice folks are using the version hosted on FDo

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84189493 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -71,8 +63,16 @@ import

[GitHub] drill issue #622: DRILL-4369: Exchange name and version infos during handsha...

2016-10-19 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/622 @paul-rogers I missed your comments, but I don't mind doing a follow up. Let me know --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84189349 --- Diff: exec/java-exec/src/main/codegen/templates/DrillVersionInfo.java --- @@ -0,0 +1,71 @@

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84189362 --- Diff: exec/java-exec/src/main/codegen/templates/DrillVersionInfo.java --- @@ -0,0 +1,71 @@

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84189164 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -330,6 +352,19 @@ public void close() { connected =

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84188853 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -98,6 +100,8 @@ * String into ByteBuf. */

[GitHub] drill issue #602: Improve Drill C++ connector

2016-10-19 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/602 @laurentgo These changes are looking good. I just have the following observations - 1) The build on Windows was a problem for me. I found CppUnit here

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84187250 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -71,8 +63,16 @@ import

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84153946 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -98,6 +100,8 @@ * String into ByteBuf. */

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84152744 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -330,6 +352,19 @@ public void close() { connected =

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84153322 --- Diff: exec/java-exec/src/main/codegen/templates/DrillVersionInfo.java --- @@ -0,0 +1,71 @@

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84153766 --- Diff: exec/java-exec/src/main/codegen/templates/DrillVersionInfo.java --- @@ -0,0 +1,71 @@

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84154532 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -176,6 +181,23 @@ public void setAutoRead(boolean

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84155289 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -71,9 +75,14 @@ public UserClient(DrillConfig config, boolean

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84153194 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -330,6 +352,19 @@ public void close() { connected =

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84152957 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -176,6 +181,23 @@ public void setAutoRead(boolean

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84155576 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserRpcUtils.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84145567 --- Diff: exec/jdbc-all/src/test/java/org/apache/drill/jdbc/ITTestShadedJar.java --- @@ -67,6 +70,33 @@ public void run() { } @Test

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84145465 --- Diff: exec/java-exec/src/main/codegen/templates/DrillVersionInfo.java --- @@ -0,0 +1,97 @@

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84145164 --- Diff: exec/java-exec/src/main/codegen/templates/DrillVersionInfo.java --- @@ -0,0 +1,97 @@

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread julienledem
Github user julienledem commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84140755 --- Diff: exec/java-exec/src/main/codegen/templates/DrillVersionInfo.java --- @@ -0,0 +1,97 @@

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread julienledem
Github user julienledem commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84140015 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/DriverTest.java --- @@ -17,6 +17,15 @@ */ package org.apache.drill.jdbc;

[GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...

2016-10-19 Thread julienledem
Github user julienledem commented on a diff in the pull request: https://github.com/apache/drill/pull/622#discussion_r84139026 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java --- @@ -96,6 +96,8 @@ protected DrillConnectionImpl(DriverImpl

[jira] [Created] (DRILL-4952) AVG() returns SchemaChangeException

2016-10-19 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-4952: - Summary: AVG() returns SchemaChangeException Key: DRILL-4952 URL: https://issues.apache.org/jira/browse/DRILL-4952 Project: Apache Drill Issue Type: Bug

[jira] [Resolved] (DRILL-4342) Drill fails to read a date column from hive generated parquet

2016-10-19 Thread Vitalii Diravka (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vitalii Diravka resolved DRILL-4342. Resolution: Duplicate > Drill fails to read a date column from hive generated parquet >

[jira] [Resolved] (DRILL-4763) Parquet file with DATE logical type produces wrong results for simple SELECT

2016-10-19 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-4763. - Resolution: Duplicate Merged into master with three commits with Jira DRILL-4203: