Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/717
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/717
LGTM. +1. Thanks for the detailed writeup, comments and the responses to
code review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100710188
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1456 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100708912
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1456 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100710124
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1456 @@
+/*
+ *
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100711041
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -0,0 +1,293 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100708660
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -0,0 +1,293 @@
+/*
+ * Licensed to
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100708601
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -0,0 +1,293 @@
+/*
+ * Licensed to
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709767
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709733
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709630
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709564
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100709555
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708749
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/746
Drill 5254: Enhance default reduction factors in optimizer
Provides enhanced default selectivity rules as defined in DRILL-5254.
Please see the JIRA entry for the details.
The rules are
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708249
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708181
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708170
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100708172
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100707677
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100707129
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100706700
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java
---
@@ -0,0 +1,256 @@
+/**
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100705997
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/InternalBatch.java
---
@@ -88,4 +91,7 @@ public void clear() {
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100705962
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/InternalBatch.java
---
@@ -54,6 +56,7 @@ public
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100703843
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1456 @@
+/*
+ *
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100703657
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1456 @@
+/*
+ *
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100703575
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java
---
@@ -0,0 +1,1456 @@
+/*
+ *
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100705782
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -0,0 +1,293 @@
+/*
+ * Licensed
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/717#discussion_r100686638
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -0,0 +1,293 @@
+/*
+ * Licensed
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/729#discussion_r100703479
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/StatisticsAggregate.java
---
@@ -0,0 +1,73 @@
+/**
+ * Licensed to the
30 matches
Mail list logo
