[GitHub] drill issue #866: Drill 5657: Implement size-aware result set loader

2017-07-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/866 This commit provides another two levels of foundation for size-aware vector writers in the Drill record readers. Much of the material below appears in Javadoc throughout the code. But, it

[GitHub] drill pull request #866: Drill 5657: Implement size-aware result set loader

2017-07-03 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/866 Drill 5657: Implement size-aware result set loader You can merge this pull request into a Git repository by running: $ git pull https://github.com/paul-rogers/drill DRILL-5657

[jira] [Created] (DRILL-5657) Extend column accessors to be size-aware

2017-07-03 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-5657: -- Summary: Extend column accessors to be size-aware Key: DRILL-5657 URL: https://issues.apache.org/jira/browse/DRILL-5657 Project: Apache Drill Issue Type:

[GitHub] drill pull request #861: DRILL-4722: Fix EqualityVisitor for interval day ex...

2017-07-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/861 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #863: DRILL-4970: Prevent changing the negative value of ...

2017-07-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/863 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #862: DRILL-5420: ParquetAsyncPgReader goes into infinite...

2017-07-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/862 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill issue #863: DRILL-4970: Prevent changing the negative value of input h...

2017-07-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/863 Not entirely thrilled with focusing on one bug without cleaning up the entire area, but that is another discussion. +1 --- If your project is set up for it, you can reply to this email and

[GitHub] drill issue #831: DRILL-5432: Added pcap-format support

2017-07-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/831 Squashed commits and committed to Apache master. Congratulations! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

2017-07-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/831 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #851: DRILL-5518: Test framework enhancements

2017-07-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #840: DRILL-5517: Size-aware set methods in value vectors

2017-07-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/840 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill issue #831: DRILL-5432: Added pcap-format support

2017-07-03 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/831 Looks like we're good to go. Will be working on pulling the PR into Apache master today and will post any issues that arise as I run the code through the detailed tests used in that process.

[GitHub] drill issue #831: DRILL-5432: Added pcap-format support

2017-07-03 Thread dmitriyHavrilovich
Github user dmitriyHavrilovich commented on the issue: https://github.com/apache/drill/pull/831 @paul-rogers , is anything else we can do for this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] drill pull request #863: DRILL-4970: Prevent changing the negative value of ...

2017-07-03 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/863#discussion_r125332767 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java --- @@ -78,4 +81,71 @@ public void testToDateForTimeStamp()

[GitHub] drill pull request #863: DRILL-4970: Prevent changing the negative value of ...

2017-07-03 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/863#discussion_r125331522 --- Diff: exec/java-exec/src/main/codegen/templates/CastFunctions.java --- @@ -54,14 +56,14 @@ public void setup() {} public void eval() {

[GitHub] drill pull request #863: DRILL-4970: Prevent changing the negative value of ...

2017-07-03 Thread vvysotskyi
Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/863#discussion_r125332691 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java --- @@ -78,4 +81,71 @@ public void testToDateForTimeStamp()

[jira] [Resolved] (DRILL-4511) refresh over empty folder results in error, we need a better error message

2017-07-03 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-4511. - Resolution: Fixed > refresh over empty folder results in error, we need a better error

[jira] [Resolved] (DRILL-3434) Applying kvgen on a scalar (field within a map) results in "Unable to get holder type for minor type [LATE] and mode [OPTIONAL]"

2017-07-03 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-3434. - Resolution: Fixed Fix Version/s: (was: Future) > Applying kvgen on a scalar

[jira] [Resolved] (DRILL-4519) File system directory-based partition pruning doesn't work correctly with parquet metadata

2017-07-03 Thread Miroslav Holubec (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Holubec resolved DRILL-4519. - Resolution: Fixed Fixed probably as part of some other fix. Haven't observed it since

[jira] [Resolved] (DRILL-3837) Metadata Caching : refresh metadata command on an empty dir should throw proper error message

2017-07-03 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-3837. - Resolution: Fixed > Metadata Caching : refresh metadata command on an empty dir should

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125243537 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java --- @@ -0,0 +1,315 @@ +/** + * Licensed to

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125248545 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoHelperFunctions.java --- @@ -0,0 +1,85 @@ +/** + * Licensed

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125248660 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoHelperFunctions.java --- @@ -0,0 +1,85 @@ +/** + * Licensed

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125249038 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java --- @@ -0,0 +1,315 @@ +/** + * Licensed to

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125242571 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java --- @@ -0,0 +1,315 @@ +/** --- End diff --

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125246241 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCryptoFunctions.java --- @@ -0,0 +1,91 @@ +/** + * Licensed to the

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125244029 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java --- @@ -0,0 +1,315 @@ +/** + * Licensed to

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125243335 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java --- @@ -0,0 +1,315 @@ +/** + * Licensed to

[GitHub] drill pull request #865: DRILL-5634 - Add Crypto and Hash Functions

2017-07-03 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/865#discussion_r125244592 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java --- @@ -0,0 +1,315 @@ +/** + * Licensed to

Re: Problems building Drill

2017-07-03 Thread Muhammad Gelbana
I tried a building from source using the same branch (i.e. *master*) after creating a fresh clone and I faced some trouble but its none of what you are mentioning here. Are you running the tests from the command line or from eclipse ? Try the

Re: Why rules from all plugins contribute into optimizing any type of query ?

2017-07-03 Thread Muhammad Gelbana
​Thanks a lot everyone. Aman, your answer is very convincing. You made it clear that since a single query can involve multiple plugins, then all rules provided by at least the involved plugins must be considered by the planner. -- Gelbana On Mon, Jul 3, 2017 at 4:04 AM, Aman Sinha