[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153407376 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/ThrottledResourceManager.java --- @@ -314,13 +315,49 @@ public void exit()

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153394006 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -426,48 +413,25 @@ private void runPhysicalPlan(final

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153406144 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153389793 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/QueryWorkUnit.java --- @@ -112,4 +115,46 @@ public void applyPlan(PhysicalPlanReader

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153403800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153404245 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153406881 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/DefaultResourceManager.java --- @@ -73,13 +75,20 @@ public void

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153403438 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -873,105 +791,133 @@ public void close() throws Exception

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153405107 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153405899 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153405303 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153402805 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -426,48 +413,25 @@ private void runPhysicalPlan(final

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153407221 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/QueryResourceManager.java --- @@ -38,22 +35,17 @@ * For some cases

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153404840 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153389627 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileUtil.java --- @@ -19,30 +19,35 @@ import

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153403903 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153389550 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileUtil.java --- @@ -19,30 +19,35 @@ import

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153406564 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java --- @@ -280,29 +280,29 @@ public void interrupted(final

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153405696 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/FragmentsRunner.java --- @@ -0,0 +1,439 @@ +/* + * Licensed to the

Drill Hangout Nov 28 2017

2017-11-27 Thread Parth Chandra
We'll have the Drill Hangout tomorrow Nov 28th, at 10 AM PST. As usual, please send email if you have any topics to discuss or bring them up on the call. We'll start with the release plan :) Hangout link: https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc Thanks Parth

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r153388800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java --- @@ -30,18 +30,24 @@ public class WorkspaceConfig

[GitHub] drill issue #1027: DRILL-4779 : Kafka storage plugin

2017-11-27 Thread akumarb2010
Github user akumarb2010 commented on the issue: https://github.com/apache/drill/pull/1027 As this PR is corrupted, we have created a new PR with single commit https://github.com/apache/drill/pull/1052 ---

[GitHub] drill pull request #1052: DRILL-4779: Kafka storage plugin new PR(Kamesh Bha...

2017-11-27 Thread akumarb2010
GitHub user akumarb2010 opened a pull request: https://github.com/apache/drill/pull/1052 DRILL-4779: Kafka storage plugin new PR(Kamesh Bhallamudi & Anil Kumar Batchu) As https://github.com/apache/drill/pull/1027 PR is corrupted while squash, creating a new PR with same codebase,

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r153336979 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java --- @@ -30,18 +30,24 @@ public class

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r153337275 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java --- @@ -30,18 +30,25 @@ public class

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153297425 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -873,105 +791,133 @@ public void close() throws Exception {

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153278034 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -221,11 +200,15 @@ public QueryManager getQueryManager() {

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153285121 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -256,12 +239,14 @@ public void run() { // track

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153293973 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -177,9 +155,10 @@ public Foreman(final WorkerBee bee, final

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153268878 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileUtil.java --- @@ -19,30 +19,35 @@ import

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153323467 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/ThrottledResourceManager.java --- @@ -314,13 +315,49 @@ public void exit() {

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153294703 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileUtil.java --- @@ -19,30 +19,35 @@ import

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153296504 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -873,105 +791,133 @@ public void close() throws Exception {

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153290872 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -426,48 +413,25 @@ private void runPhysicalPlan(final

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r15422 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/rm/ThrottledResourceManager.java --- @@ -288,8 +287,10 @@ public void

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/1051#discussion_r153297806 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -873,105 +791,133 @@ public void close() throws Exception {

[GitHub] drill issue #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-27 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/921 Interesting issue! Let's think about this a bit. In a production system, we do want the grace period; it is an essential part of the graceful shutdown procedure. However, if we

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r152862636 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -252,11 +252,15 @@ private static String

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r152862954 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java --- @@ -30,18 +30,24 @@ public class WorkspaceConfig

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r152862722 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -359,15 +363,30 @@ private static Path

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r153318818 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/dfs/TestFileSelection.java --- @@ -59,4 +61,53 @@ public void

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r152862665 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -359,15 +363,30 @@ private static Path

[GitHub] drill pull request #1050: DRILL-5964: Do not allow queries to access paths o...

2017-11-27 Thread parthchandra
Github user parthchandra commented on a diff in the pull request: https://github.com/apache/drill/pull/1050#discussion_r152862693 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -359,15 +363,30 @@ private static Path

[GitHub] drill issue #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-27 Thread dvjyothsna
Github user dvjyothsna commented on the issue: https://github.com/apache/drill/pull/921 This was due to grace_period during shutdown of drillbits. Fixed it by changing grace_period = 0 in .conf ---

[jira] [Created] (DRILL-5993) Allow Copier to Copy a Record to an Arbitrary Index

2017-11-27 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-5993: - Summary: Allow Copier to Copy a Record to an Arbitrary Index Key: DRILL-5993 URL: https://issues.apache.org/jira/browse/DRILL-5993 Project: Apache Drill

[GitHub] drill issue #1047: DRILL-5970: DrillParquetReader always builds the schema w...

2017-11-27 Thread priteshm
Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1047 @sachouche can you please review this? ---

Re: [DISCUSS] Drill 1.12.0 release

2017-11-27 Thread Arina Yelchiyeva
Current status: DRILL-4779: Kafka storage plugin support (developer - Anil & Kamesh, code reviewer - Paul) - fix is expected by the EOD in new pull request. DRILL-4286: Graceful shutdown of drillbit (developer - Jyothsna, code reviewer - Paul) - unit test failures are fixed. Unit test performance

[GitHub] drill pull request #1051: DRILL-5963: Query state process improvements

2017-11-27 Thread arina-ielchiieva
GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/1051 DRILL-5963: Query state process improvements 1. Added two new query states: PREPARING (when foreman is initialized) and PLANNING (includes logical and / or physical planning). 2.

[jira] [Created] (DRILL-5992) Move html code generation for query profile from Java into freemarker

2017-11-27 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-5992: --- Summary: Move html code generation for query profile from Java into freemarker Key: DRILL-5992 URL: https://issues.apache.org/jira/browse/DRILL-5992 Project:

[GitHub] drill issue #921: DRILL-4286 Graceful shutdown of drillbit

2017-11-27 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/921 @dvjyothsna all tests has passed. Though there is significant performance degradation. Before your changes unit test run takes ~ 33 minutes, after ~ 1 hour 18 minutes. For example,