[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171479641 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -224,4 +226,64 @@ public Void

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171480227 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java --- @@ -55,18 +62,21 @@ public void

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171478117 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -224,4 +226,64 @@ public Void

[GitHub] drill pull request #1096: DRILL-6099 : Push limit past flatten(project) with...

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1096#discussion_r171478085 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -224,4 +226,64 @@ public Void

Re: [ANNOUNCE] New Committer: Kunal Khatua

Congrats Kunal. On Thu, Mar 1, 2018 at 1:36 AM, Ramana I N wrote: > Congrats Kunal! > > Regards > Ramana > > > On Wed, Feb 28, 2018 at 11:02 AM, Robert Hou wrote: > > > Congrats Kunal! > > > > > > --Robert > > > > > > From:

Re: [DISCUSS] 1.13.0 release

Moved Ted's PR's down in the list. Let's see where we are at the end of the week. Arina, Volodymyr, ank ETA on JDK 8 work? It's the gating factor for the release. Meanwhile, people, feel free to commit your work as usual. Updated list: DRILL-6185: Error is displaying while accessing query

[GitHub] drill issue #1133: DRILL-6190 - Fix handling of packets longer than legally ...

Github user tdunning commented on the issue: https://github.com/apache/drill/pull/1133 Fixed the test regression. Deferring investigation into why the data field doesn't look unique to Drill because we will probably need to revamp how raw data is returned anyway. ---

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/1141#discussion_r171431227 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentStats.java --- @@ -31,6 +32,13 @@ public class FragmentStats { //

[GitHub] drill pull request #1141: DRILL-6197: Skip duplicate entry for OperatorStats

GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/1141 DRILL-6197: Skip duplicate entry for OperatorStats `org.apache.drill.exec.ops.FragmentStats` should skip injecting the `org.apache.drill.exec.ops.OperatorStats` instance for these operators:

[GitHub] drill issue #1141: DRILL-6197: Skip duplicate entry for OperatorStats

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1141 @amansinha100 please review ---

[jira] [Created] (DRILL-6197) Duplicate entries in inputProfiles of minor fragments for specific operators

Kunal Khatua created DRILL-6197: --- Summary: Duplicate entries in inputProfiles of minor fragments for specific operators Key: DRILL-6197 URL: https://issues.apache.org/jira/browse/DRILL-6197 Project:

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

Github user cchang738 commented on the issue: https://github.com/apache/drill/pull/1101 My test fail with OOM. @ilooner has test log. ---

Re: [ANNOUNCE] New Committer: Kunal Khatua

Congrats Kunal! Regards Ramana On Wed, Feb 28, 2018 at 11:02 AM, Robert Hou wrote: > Congrats Kunal! > > > --Robert > > > From: Robert Wu > Sent: Wednesday, February 28, 2018 10:50 AM > To: dev@drill.apache.org > Subject:

[GitHub] drill issue #1140: DRILL-6195: Quering Hive non-partitioned transactional ta...

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/1140 @arina-ielchiieva Current implementation of creating schema for Drill Hive embedded metastore doesn't allow to create transactional tables. That's why I have created a separate Jira task to update

[GitHub] drill issue #1129: DRILL-6180: Use System Option "output_batch_size" for Ext...

Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1129 @paul-rogers Made the change you suggested. Please take a look when you get a chance. ---

Re: [ANNOUNCE] New Committer: Kunal Khatua

Congrats Kunal! --Robert From: Robert Wu Sent: Wednesday, February 28, 2018 10:50 AM To: dev@drill.apache.org Subject: RE: [ANNOUNCE] New Committer: Kunal Khatua Congratulations, Kunal! Best regards, Rob -Original Message- From:

[GitHub] drill issue #1101: DRILL-6032: Made the batch sizing for HashAgg more accura...

Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1101 Spoke with Chun, he will run the tests and update the PR with the test results. ---

[GitHub] drill issue #1137: DRILL-6185: Fixed error while displaying system profiles ...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1137 the purpose of parsing the plan as a String is primarily to extract the alternative operator names for the UI. The rest of the items are irrelevant for that usecase. Were you looking to figure out a

RE: [ANNOUNCE] New Committer: Kunal Khatua

Congratulations, Kunal! Best regards, Rob -Original Message- From: Vitalii Diravka [mailto:vitalii.dira...@gmail.com] Sent: Wednesday, February 28, 2018 10:48 AM To: dev@drill.apache.org Subject: Re: [ANNOUNCE] New Committer: Kunal Khatua Congrats, Kunal! Kind regards Vitalii On

Re: [ANNOUNCE] New Committer: Kunal Khatua

Congrats, Kunal! Kind regards Vitalii On Wed, Feb 28, 2018 at 6:39 PM, Timothy Farkas wrote: > Congrats! > > > From: Paul Rogers > Sent: Wednesday, February 28, 2018 9:58:32 AM > To: dev@drill.apache.org > Subject:

Re: [ANNOUNCE] New Committer: Kunal Khatua

Congrats! From: Paul Rogers Sent: Wednesday, February 28, 2018 9:58:32 AM To: dev@drill.apache.org Subject: Re: [ANNOUNCE] New Committer: Kunal Khatua Congrats, Kunal! Well deserved. - Paul > On Feb 27, 2018, at 10:42 AM, Prasad

[GitHub] drill issue #1140: DRILL-6195: Quering Hive non-partitioned transactional ta...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1140 Looks good, could you add unit test? ---

Re: [ANNOUNCE] New Committer: Kunal Khatua

Congrats, Kunal! Well deserved. - Paul > On Feb 27, 2018, at 10:42 AM, Prasad Nagaraj Subramanya > wrote: > > Congratulations Kunal! > > > On Tue, Feb 27, 2018 at 10:41 AM, Padma Penumarthy > wrote: > >> Congratulations Kunal ! >> >> Thanks >>

[GitHub] drill issue #1125: DRILL-6126: Allocate memory for value vectors upfront in ...

Github user ppadma commented on the issue: https://github.com/apache/drill/pull/1125 @paul-rogers Paul, Thanks a lot for your review comments and bringing up some good issues. Just want to let you know. I am working on refactoring the batch sizer code, writing bunch of unit tests to

Avro storage format behaviour

Hi all, I am working on DRILL-4120: dir0 does not work when the directory structure contains Avro files. In DRILL-3810 was added validation of query using avro schema before start executing the query. Therefore with these changes Drill throws an exception when the query contains non-existent

[GitHub] drill issue #1112: DRILL-6114: Metadata revisions

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1112 @arina-ielchiieva, @parthchandra can either of you perhaps give this one a committer review? Thanks! ---

[GitHub] drill issue #1140: DRILL-6195: Quering Hive non-partitioned transactional ta...

Github user vdiravka commented on the issue: https://github.com/apache/drill/pull/1140 @arina-ielchiieva Please review ---

[GitHub] drill pull request #1135: DRILL-6040: Added usage for graceful_stop in drill...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1135#discussion_r171319850 --- Diff: distribution/src/resources/drillbit.sh --- @@ -45,7 +45,7 @@ # configuration file. The option takes precedence over the #

[GitHub] drill pull request #1140: DRILL-6195: Quering Hive non-partitioned transacti...

GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/1140 DRILL-6195: Quering Hive non-partitioned transactional tables via Drill You can merge this pull request into a Git repository by running: $ git pull https://github.com/vdiravka/drill

[GitHub] drill issue #1138: DRILL-4120: Allow implicit columns for Avro storage forma...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1138 General comment: if we could move to the new scan framework; it handles implicit columns for all file-based readers. It also handles projection, missing columns, etc... ---

[GitHub] drill pull request #1129: DRILL-6180: Use System Option "output_batch_size" ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1129#discussion_r171314892 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortConfig.java --- @@ -71,8 +72,8 @@ private

[GitHub] drill pull request #1129: DRILL-6180: Use System Option "output_batch_size" ...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1129#discussion_r171315310 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -421,7 +416,7 @@ drill.exec.options: {

[jira] [Created] (DRILL-6196) Upgrade HiveTestDataGenerator to leverage "schematool"

Vitalii Diravka created DRILL-6196: -- Summary: Upgrade HiveTestDataGenerator to leverage "schematool" Key: DRILL-6196 URL: https://issues.apache.org/jira/browse/DRILL-6196 Project: Apache Drill

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171308023 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java --- @@ -5798,6 +5798,34 @@ public static UserToBitHandshake

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171307607 --- Diff: logical/src/main/java/org/apache/drill/common/config/LogicalPlanPersistence.java --- @@ -52,6 +53,7 @@ public

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1139#discussion_r171307292 --- Diff: contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStorageConfig.java --- @@ -17,13 +17,15 @@ */ package

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

GitHub user vladimirtkach opened a pull request: https://github.com/apache/drill/pull/1139 DRILL-6189: Security: passwords logging and file permisions 1. Overrided serialization methods for instances with passwords 2. Changed file permissions for configuration files You can

[jira] [Created] (DRILL-6195) Quering Hive non-partitioned transactional tables via Drill

Vitalii Diravka created DRILL-6195: -- Summary: Quering Hive non-partitioned transactional tables via Drill Key: DRILL-6195 URL: https://issues.apache.org/jira/browse/DRILL-6195 Project: Apache Drill

[jira] [Created] (DRILL-6194) Allow un-caching of parquet metadata or stop queries from failing when metadata is old.

John Humphreys created DRILL-6194: - Summary: Allow un-caching of parquet metadata or stop queries from failing when metadata is old. Key: DRILL-6194 URL: https://issues.apache.org/jira/browse/DRILL-6194

Re: [DISCUSS] 1.13.0 release

6190 and/or 6191 cause test failures that I have been unable to spend time on yet. I don't think that they are ready to commit. At least one of these is likely to be something very simple like a test that didn't clean up after itself. The other should be as simple, but I can't understand it yet.

[GitHub] drill issue #1138: DRILL-4120: Allow implicit columns for Avro storage forma...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1138 You are basically reverting changes done in DRILL-3810 to support schema validation in Avro. Avro format is strict and has schema. Should Drill treat it the same way or do loosen

Re: [DISCUSS] 1.13.0 release

OK. So let's try to get as many of the following as we can without breaking anything. As far as I can see none of the open items below are show stoppers for a release, but I'm happy to give in to popular demand for JDK 8 :). Note that the last three appear to be big ticket items that have no PR

[GitHub] drill issue #1132: DRILL-6188: Fix C++ client build on Centos7, OS X

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1132 +1 ---

[GitHub] drill pull request #1138: DRILL-4120: Allow implicit columns for Avro storag...

GitHub user vvysotskyi opened a pull request: https://github.com/apache/drill/pull/1138 DRILL-4120: Allow implicit columns for Avro storage format Existing implementation of `AvroDrillTabl` does not allow dynamic columns discovering. `AvroDrillTable.getRowType()` method returns

[GitHub] drill issue #1134: DRILL-6191 - Add acknowledgement sequence number and flag...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1134 +1 ---

[GitHub] drill issue #1133: DRILL-6190 - Fix handling of packets longer than legally ...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1133 @tdunning travis fails with ` Failed tests: TestPcapRecordReader.testDistinctQuery:51->runSQLVerifyCount:56->printResultAndVerifyRowCount:68 expected:<1> but was:<2>` ---

[GitHub] drill issue #1133: DRILL-6190 - Fix handling of packets longer than legally ...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1133 +1 ---

[GitHub] drill issue #1137: DRILL-6185: Fixed error while displaying system profiles ...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1137 +1, LGTM. ---