Non-batch review comments?

Hi All, Two years ago, when I started with Drill, Github would send out an e-mail for each review comment. Later, GitHub thankfully implemented a feature that combined comments into a single e-mail. But, for some time now, GitHub is back to spamming this list with each individual comment.

[GitHub] drill pull request #1125: DRILL-6126: Allocate memory for value vectors upfr...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1125#discussion_r172105917 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -199,12 +422,18 @@ public String toString() {

[GitHub] drill pull request #1125: DRILL-6126: Allocate memory for value vectors upfr...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1125#discussion_r172105268 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -525,4 +763,11 @@ public VectorInitializer

[GitHub] drill pull request #1125: DRILL-6126: Allocate memory for value vectors upfr...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1125#discussion_r172104808 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -76,110 +82,327 @@ * greater than (but

[GitHub] drill pull request #1125: DRILL-6126: Allocate memory for value vectors upfr...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1125#discussion_r172105435 --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java --- @@ -608,4 +608,22 @@ public void collectLedgers(Set

[GitHub] drill pull request #1125: DRILL-6126: Allocate memory for value vectors upfr...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1125#discussion_r172105104 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -76,110 +82,327 @@ * greater than (but

[GitHub] drill pull request #1125: DRILL-6126: Allocate memory for value vectors upfr...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1125#discussion_r172103839 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java --- @@ -492,8 +504,12 @@ private void

[GitHub] drill pull request #1125: DRILL-6126: Allocate memory for value vectors upfr...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1125#discussion_r172104598 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -76,110 +82,327 @@ * greater than (but

[GitHub] drill pull request #1125: DRILL-6126: Allocate memory for value vectors upfr...

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1125#discussion_r172104395 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java --- @@ -76,110 +82,327 @@ * greater than (but

[GitHub] drill issue #896: WIP: Made UI links relative.

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/896 The latest CI has introduced numerous fixes. Can you file a JIRA for this PR, with the reason behind this PR? I think you'll also need to rebase the Commit on top of the current master to resolve

[GitHub] drill issue #131: Initial commit for memory storage plugin

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/131 @aleph-zero What was this feature? Do you have a corresponding Drill JIRA that explains this in more detail? ---

[GitHub] drill issue #897: Drill-5703 Added Syntax Highlighting and Limited Autocompl...

Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/897 Thanks, @cgivre ! I don't have permissions to close the PR. Perhaps you can close it instead. ---

Re: Batch Sizing for Parquet Flat Reader

Hi Paul, thanks for your comments. I have added my thoughts in the DRILL-6147 JIRA as well. Regarding the hangout, let me find out about availability of other folks too and will circle back with you. thanks, Aman On Sun, Mar 4, 2018 at 1:23 PM, Paul Rogers wrote: >

[GitHub] drill issue #1150: DRILL-6210: Enhanced test schema utilities

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1150 @padma, can you review this? @ilooner, you might want to take a look also since you've taken an interest in improving our test structures. ---

[GitHub] drill pull request #1150: DRILL-6210: Enhanced test schema utilities

GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/1150 DRILL-6210: Enhanced test schema utilities The result set loader project enhanced the schema builder used in tests to handle Drill's complex types: maps, unions, lists and repeated lists. The

[jira] [Created] (DRILL-6210) Enhance the test schema builder for remaining types

Paul Rogers created DRILL-6210: -- Summary: Enhance the test schema builder for remaining types Key: DRILL-6210 URL: https://issues.apache.org/jira/browse/DRILL-6210 Project: Apache Drill Issue

Re: Batch Sizing for Parquet Flat Reader

Hi Aman, To follow up, we should look at all sides of the issue. One factor overlooked in my previous note is that code now is better than code later. DRILL-6147 is available today and will immediately give users a performance boost. The result set loader is large and will take some months to

Re: Batch Sizing for Parquet Flat Reader

Hi Aman, Please see my comment in DRILL-6147. For the hangout to be productive, perhaps we should create test cases that will show the benefit of DRILL-6147 relative to the result set loader. The test case of interest has three parts: * Multiple variable-width fields (say five) with a large

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 @arina-ielchiieva, thanks much for your help with this PR. Glad to see it is finally in Drill master after all this time! ---

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1011 @kr-arjun, thanks for the text file. The error is related to security. DoY, in its current for, is an "MVP": it works, but leaves off advanced features. One of those missing features is to work

Re: Batch Sizing for Parquet Flat Reader

Hi all, with reference to DRILL-6147 given the overlapping approaches, I feel like we should have a separate hangout session with interested parties and discuss the details. Let me know and I can setup one. Aman On Mon, Feb 12, 2018 at 8:50

Re: [DISCUSS] 1.13.0 release

Merged Drill on Yarn. Paul thanks for making the changes. Regarding JDK8 there is an open PR ( https://github.com/apache/drill/pull/1143) which needs to be merged. As Volodymyr mentioned there were some issues with unit tests and Travis. Padma and I have addressed unit tests issues but we still

[GitHub] drill pull request #1011: Drill 1170: Drill-on-YARN

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1011 ---

[GitHub] drill pull request #1139: DRILL-6189: Security: passwords logging and file p...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1139 ---

[GitHub] drill pull request #1149: DRILL-6208: Fix FunctionInitializerTest#testConcur...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/1149 ---

[jira] [Created] (DRILL-6209) Spark generated Parquet file reading fails when 'store.parquet.reader.int96_as_timestamp' is used

Robert V created DRILL-6209: --- Summary: Spark generated Parquet file reading fails when 'store.parquet.reader.int96_as_timestamp' is used Key: DRILL-6209 URL: https://issues.apache.org/jira/browse/DRILL-6209

[GitHub] drill pull request #1011: Drill 1170: Drill-on-YARN

Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1011#discussion_r172052984 --- Diff: distribution/src/assemble/bin.xml --- @@ -323,6 +333,21 @@ src/resources/sqlline.bat bin + ---

[GitHub] drill issue #1139: DRILL-6189: Security: passwords logging and file permisio...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1139 +1, LGTM. ---

Re: [DISCUSS] 1.13.0 release

Sounds good. On Sun, Mar 4, 2018 at 1:18 PM, Paul Rogers wrote: > Hi Parth, > Issues with DRILL-1170 are resolved. Needs one final review by Arina, then > we should be good to do. > Thanks to everyone for getting the other two "batch size" PRs committed > recently. >

[GitHub] drill issue #1011: Drill 1170: Drill-on-YARN

Github user kr-arjun commented on the issue: https://github.com/apache/drill/pull/1011 @paul-rogers The client error message changes look good. I did quick test with client error message changes and could verify that error message are logged. > Where you using the start