[GitHub] HanumathRao commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner

2018-08-01 Thread GitBox
HanumathRao commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner URL: https://github.com/apache/drill/pull/1414#issuecomment-409805900 @sachouche code changes look good to me. This is an

Re: [VOTE] Apache Drill release 1.14.0 - RC3

2018-08-01 Thread Kunal Khatua
Built from source and tried the binaries. Tested spill-to-disk behavior, a couple of concurrent queries and general UX checks. LGTM. +1 (non-binding) On 8/1/2018 4:58:08 PM, Boaz Ben-Zvi wrote: Thanks Vlad for bringing these two points to our attention. Therefore the vote on RC3 should be

Re: Metadata management improvement

2018-08-01 Thread Padma Penumarthy
I think the simplest thing that should be done first is to provide option to skip the check. The default behavior for that option will be what we do today i.e. check root directory and all sub directories underneath. Thanks Padma On Mon, Jul 30, 2018 at 3:01 AM, Joel Pfaff wrote: > Hello, >

[GitHub] paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support

2018-08-01 Thread GitBox
paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support URL: https://github.com/apache/drill/pull/1244#issuecomment-409801351 @vrozov, thanks for the explanation. This is exactly what we've discussed multiple times over the last several months.

[GitHub] paul-rogers commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner

2018-08-01 Thread GitBox
paul-rogers commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner URL: https://github.com/apache/drill/pull/1414#issuecomment-409800290 As it turns out, optimized processing for implicit columns is available in the long-stalled result set loader pull

[GitHub] sachouche commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner

2018-08-01 Thread GitBox
sachouche commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner URL: https://github.com/apache/drill/pull/1414#issuecomment-409783718 @HanumathRao can you also please review this PR? thanks!

[GitHub] sachouche commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner

2018-08-01 Thread GitBox
sachouche commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner URL: https://github.com/apache/drill/pull/1414#issuecomment-409783289 @ilooner fixed the formatting issue; thanks for the review!

[GitHub] Ben-Zvi commented on issue #1416: Updates mongo-java-driver to 3.8.0

2018-08-01 Thread GitBox
Ben-Zvi commented on issue #1416: Updates mongo-java-driver to 3.8.0 URL: https://github.com/apache/drill/pull/1416#issuecomment-409769145 A Drill pull-request must correspond to a Jira case (e.g. DRILL-1234) explaining the problem being addressed.

[GitHub] ilooner commented on a change in pull request #1414: DRILL-6101: Optimized implicit columns handling within scanner

2018-08-01 Thread GitBox
ilooner commented on a change in pull request #1414: DRILL-6101: Optimized implicit columns handling within scanner URL: https://github.com/apache/drill/pull/1414#discussion_r207013797 ## File path:

Re: [VOTE] Apache Drill release 1.14.0 - RC3

2018-08-01 Thread Boaz Ben-Zvi
 Thanks Vlad for bringing these two points to our attention. Therefore the vote on RC3 should be open till Friday, August 3rd, at 6 PM PDT. And we should (sans any new issue) get enough PMC +1 votes on RC3 by Friday.    Thanks,     Boaz On 8/1/18 8:40 AM, Vlad Rozov wrote: Apache

[GitHub] pkfoury opened a new pull request #1416: Updates mongo-java-driver to 3.8.0

2018-08-01 Thread GitBox
pkfoury opened a new pull request #1416: Updates mongo-java-driver to 3.8.0 URL: https://github.com/apache/drill/pull/1416 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sohami commented on issue #1407: DRILL-6652: PartitionLimit changes for Lateral and Unnest

2018-08-01 Thread GitBox
sohami commented on issue #1407: DRILL-6652: PartitionLimit changes for Lateral and Unnest URL: https://github.com/apache/drill/pull/1407#issuecomment-409719987 Rebased on latest master. Removed Ignores from TestE2EUnnestAndLateral Squashed 2 commits related to DRILL-6636 since it's

Re: [VOTE] Apache Drill release 1.14.0 - RC3

2018-08-01 Thread Boaz Ben-Zvi
 Thanks Vlad for bringing these two points to our attention. Therefore the vote on RC3 should be open till Friday, August 3rd, at 6 PM PDT. And we should (sans any new issue) get enough PMC +1 votes on RC3 by Friday.    Thanks,     Boaz On 8/1/18 8:40 AM, Vlad Rozov wrote: Apache

[GitHub] ilooner opened a new pull request #1415: DRILL-6656: Disallow extra semicolons in import statements.

2018-08-01 Thread GitBox
ilooner opened a new pull request #1415: DRILL-6656: Disallow extra semicolons in import statements. URL: https://github.com/apache/drill/pull/1415 Due to this jdk bug https://bugs.openjdk.java.net/browse/JDK-8072390, IntelliJ and openjdk 7 and 8 allow extra semicolons in imports. This is

[GitHub] ilooner commented on issue #1415: DRILL-6656: Disallow extra semicolons in import statements.

2018-08-01 Thread GitBox
ilooner commented on issue #1415: DRILL-6656: Disallow extra semicolons in import statements. URL: https://github.com/apache/drill/pull/1415#issuecomment-409700776 @arina-ielchiieva Please review. This is an automated

[GitHub] sachouche commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner

2018-08-01 Thread GitBox
sachouche commented on issue #1414: DRILL-6101: Optimized implicit columns handling within scanner URL: https://github.com/apache/drill/pull/1414#issuecomment-409696784 @HanumathRao and @ilooner can you please review this PR.

[GitHub] sachouche opened a new pull request #1414: DRILL-6101: Optimized implicit columns handling within scanner

2018-08-01 Thread GitBox
sachouche opened a new pull request #1414: DRILL-6101: Optimized implicit columns handling within scanner URL: https://github.com/apache/drill/pull/1414 Problem Description - File based implicit columns are projected only if explicitly requested within the query Note that

[GitHub] sachouche commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-01 Thread GitBox
sachouche commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r206995312 ## File path:

[GitHub] sachouche commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-01 Thread GitBox
sachouche commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r206999463 ## File path:

[GitHub] sachouche commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

2018-08-01 Thread GitBox
sachouche commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework. URL: https://github.com/apache/drill/pull/1344#discussion_r206996050 ## File path:

[GitHub] ilooner closed pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

2018-08-01 Thread GitBox
ilooner closed pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ilooner closed pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

2018-08-01 Thread GitBox
ilooner closed pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ilooner closed pull request #1403: DRILL-6634: Add udf module under contrib directory and move some udfs into it

2018-08-01 Thread GitBox
ilooner closed pull request #1403: DRILL-6634: Add udf module under contrib directory and move some udfs into it URL: https://github.com/apache/drill/pull/1403 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Created] (DRILL-6660) Exchange operators Analysis

2018-08-01 Thread salim achouche (JIRA)
salim achouche created DRILL-6660: - Summary: Exchange operators Analysis Key: DRILL-6660 URL: https://issues.apache.org/jira/browse/DRILL-6660 Project: Apache Drill Issue Type: Sub-task

[jira] [Created] (DRILL-6659) Batch sizing functionality for exchange operators

2018-08-01 Thread salim achouche (JIRA)
salim achouche created DRILL-6659: - Summary: Batch sizing functionality for exchange operators Key: DRILL-6659 URL: https://issues.apache.org/jira/browse/DRILL-6659 Project: Apache Drill

[GitHub] parthchandra opened a new pull request #1413: DRILL-6657: Unnest reports one batch less than the actual number of b…

2018-08-01 Thread GitBox
parthchandra opened a new pull request #1413: DRILL-6657: Unnest reports one batch less than the actual number of b… URL: https://github.com/apache/drill/pull/1413 …atches This is an automated message from the Apache

Re: [VOTE] Apache Drill release 1.14.0 - RC3

2018-08-01 Thread Charles Givre
- Downloaded and built drill from source - All tests passed - Ran various queries in sqlline and webUI +1 LGTM (non-binding) > On Aug 1, 2018, at 11:20, Vitalii Diravka wrote: > > - Verified the signatures for archives from [2]. > - Downloaded Drill tarball from [2]. Launched it in distributed

[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature

2018-08-01 Thread GitBox
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-409629930 @sohami pls see if your comments are addressed. @weijietong just FYI, the ongoing 1.14.0 release is yet to be finished (it is in voting stage), so

Re: [VOTE] Apache Drill release 1.14.0 - RC2

2018-08-01 Thread Vlad Rozov
Apache release votes should be open for at least 72 hours [1] and every new RC requires that PMC "Before voting +1 PMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that

Re: [VOTE] Apache Drill release 1.14.0 - RC3

2018-08-01 Thread Vitalii Diravka
- Verified the signatures for archives from [2]. - Downloaded Drill tarball from [2]. Launched it in distributed mode on Linux/Ubuntu machine. Ran different queries with cp tpch tables. Checked Storage Plugins Handler functionality. Looks good. - Downloaded sources from [4]. Successfully build it

[jira] [Created] (DRILL-6658) UnrecognizedPropertyException happens when submitting a physical plan for a Mapr-DB table query

2018-08-01 Thread Anton Gozhiy (JIRA)
Anton Gozhiy created DRILL-6658: --- Summary: UnrecognizedPropertyException happens when submitting a physical plan for a Mapr-DB table query Key: DRILL-6658 URL: https://issues.apache.org/jira/browse/DRILL-6658

[GitHub] arina-ielchiieva commented on issue #1412: DRILL-6655: Require package declaration in files.

2018-08-01 Thread GitBox
arina-ielchiieva commented on issue #1412: DRILL-6655: Require package declaration in files. URL: https://github.com/apache/drill/pull/1412#issuecomment-409493978 +1 This is an automated message from the Apache Git Service.