[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230651903 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReader.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230652873 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReader.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230653365 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReaderContext.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230646240 ## File path: contrib/codec-zstd/src/main/java/org/apache/hadoop/io/compress/zstd/ZstdDecompressor.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230646939 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackFormatPlugin.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230655032 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReader.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230651284 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackFormatPlugin.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230651403 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackFormatPlugin.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230652021 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReader.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230651829 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackParsingException.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230650119 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackFormatPlugin.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230650357 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackFormatPlugin.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230655213 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReader.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230645699 ## File path: contrib/codec-zstd/src/main/java/org/apache/hadoop/io/compress/zstd/ZstdCompressor.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230650798 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackFormatPlugin.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230653151 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReader.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230654602 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReader.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230653927 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackReader.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230646553 ## File path: contrib/format-msgpack/pom.xml ## @@ -0,0 +1,94 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230645848 ## File path: contrib/codec-zstd/src/main/java/org/apache/hadoop/io/compress/zstd/ZstdCompressor.java ## @@

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230651243 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackFormatPlugin.java

[GitHub] paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader

paul-rogers commented on a change in pull request #1500: DRILL-6820: Msgpack format reader URL: https://github.com/apache/drill/pull/1500#discussion_r230649580 ## File path: contrib/format-msgpack/src/main/java/org/apache/drill/exec/store/msgpack/MsgpackFormatPlugin.java

[GitHub] lushuifeng edited a comment on issue #1519: DRILL-6760: Retain original exception in Verbose Error Message

lushuifeng edited a comment on issue #1519: DRILL-6760: Retain original exception in Verbose Error Message URL: https://github.com/apache/drill/pull/1519#issuecomment-435772426 @arina-ielchiieva Could you please review this? Please note that at `ProfileTest:51` profile sometimes is not

[GitHub] lushuifeng commented on issue #1519: DRILL-6760: Retain original exception in Verbose Error Message

lushuifeng commented on issue #1519: DRILL-6760: Retain original exception in Verbose Error Message URL: https://github.com/apache/drill/pull/1519#issuecomment-435772426 @arina-ielchiieva Could you please review this? The tests are succeeded but timeout

[GitHub] paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework

paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework URL: https://github.com/apache/drill/pull/1501#discussion_r230644180 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/ScanTestUtils.java ##

[GitHub] paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework

paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework URL: https://github.com/apache/drill/pull/1501#discussion_r230641861 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/project/NoOpMetadataManager.java

[GitHub] paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework

paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework URL: https://github.com/apache/drill/pull/1501#discussion_r230642040 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/project/ScanLevelProjection.java

[GitHub] paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework

paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework URL: https://github.com/apache/drill/pull/1501#discussion_r230645237 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/project/TestScanBatchWriters.java

[GitHub] paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework

paul-rogers commented on a change in pull request #1501: DRILL-6791: Scan projection framework URL: https://github.com/apache/drill/pull/1501#discussion_r230644967 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/ScanTestUtils.java ##

Apache Drill Meetup on Nov 14th!

Hello, Drillers! We are restarting meetups for Apache Drill! The next meet up will be on Nov 14th at 6:30 PM at the MapR Headquarters. We will have two speakers for the meetup - Nitin Sharma @ Netflix who will talk about Netflix's Personalization Infrastructure - Aman Sinha @ MapR who will talk

Re: logging in test cases produces two outputs

Hi JC, Logback will look for logback-test.xml. If not found, it looks for logback.xml. Each search is on the class path. When Logback finds more than one, it picks one at random, then dumps warning messages about the problem. Drill used to have an issue with an excess of logback config files.

Re: logging in test cases produces two outputs

The problem is with the toConsole(). I've removed it and now I get only one output (I'm logging at debug level). I've modified my logback.xml so the console definition is in the file. > %msg%n Removed the .toConsole(), LogFixtureBuilder logBuilder = LogFixture.builder() // Log