[GitHub] KazydubB opened a new pull request #1668: DRILL-7041: CompileException happens if a nested coalesce function returns null

2019-02-28 Thread GitBox
KazydubB opened a new pull request #1668: DRILL-7041: CompileException happens if a nested coalesce function returns null URL: https://github.com/apache/drill/pull/1668 - Made `NullExpression`s in `IfExpression` with nested `IfExpression`s to be rewritten to typed ones recursively if

[GitHub] nareshgbhat commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues

2019-02-28 Thread GitBox
nareshgbhat commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues URL: https://github.com/apache/drill/pull/1651#discussion_r261489591 ## File path: distribution/pom.xml ## @@ -371,42 +369,81 @@

[GitHub] nareshgbhat commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues

2019-02-28 Thread GitBox
nareshgbhat commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues URL: https://github.com/apache/drill/pull/1651#discussion_r261486274 ## File path: distribution/pom.xml ## @@ -371,42 +369,81 @@

[GitHub] Ben-Zvi opened a new pull request #1667: DRILL-7069: Moved version checks outside loops in transformBinaryInMetadataCache

2019-02-28 Thread GitBox
Ben-Zvi opened a new pull request #1667: DRILL-7069: Moved version checks outside loops in transformBinaryInMetadataCache URL: https://github.com/apache/drill/pull/1667 Performing the metadata version checks inside three level nested loops (in *transformBinaryInMetadataCache*) had a

[GitHub] cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds

2019-02-28 Thread GitBox
cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds URL: https://github.com/apache/drill/pull/1665#issuecomment-468514038 I can do review if you'd like. This looks good, but can we add a unit test? Also, we should probably do this for PCAP-NG if it doesn't already, but

[jira] [Created] (DRILL-7069) Poor performance of transformBinaryInMetadataCache

2019-02-28 Thread Boaz Ben-Zvi (JIRA)
Boaz Ben-Zvi created DRILL-7069: --- Summary: Poor performance of transformBinaryInMetadataCache Key: DRILL-7069 URL: https://issues.apache.org/jira/browse/DRILL-7069 Project: Apache Drill Issue

[jira] [Created] (DRILL-7068) Support of memory adjustment framework for resource management with Queues

2019-02-28 Thread Hanumath Rao Maduri (JIRA)
Hanumath Rao Maduri created DRILL-7068: -- Summary: Support of memory adjustment framework for resource management with Queues Key: DRILL-7068 URL: https://issues.apache.org/jira/browse/DRILL-7068

[GitHub] priteshm commented on issue #1665: DRILL-7054: timestamp in milliseconds

2019-02-28 Thread GitBox
priteshm commented on issue #1665: DRILL-7054: timestamp in milliseconds URL: https://github.com/apache/drill/pull/1665#issuecomment-468462193 @arina-ielchiieva @vdiravka could you please review? This is an automated message

[GitHub] gparai commented on issue #729: Drill 1328: Support table statistics for Parquet

2019-02-28 Thread GitBox
gparai commented on issue #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729#issuecomment-468447932 Thank you so much @amansinha100 and @paul-rogers for painstakingly reviewing this PR! I have address most of the review comments. I will

[jira] [Resolved] (DRILL-1328) Support table statistics

2019-02-28 Thread Gautam Parai (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Parai resolved DRILL-1328. - Resolution: Fixed Merged with commit IDsĀ  469be17597e7b7c6bc1de9863dcb6c5604a55f0c

[GitHub] gparai closed pull request #729: Drill 1328: Support table statistics for Parquet

2019-02-28 Thread GitBox
gparai closed pull request #729: Drill 1328: Support table statistics for Parquet URL: https://github.com/apache/drill/pull/729 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (DRILL-7067) Querying parquet file with null value field error

2019-02-28 Thread Jardhel Cachola (JIRA)
Jardhel Cachola created DRILL-7067: -- Summary: Querying parquet file with null value field error Key: DRILL-7067 URL: https://issues.apache.org/jira/browse/DRILL-7067 Project: Apache Drill

Re: Anouncing Powered-By-Drill page

2019-02-28 Thread hanu mapr
Great work! It is good to know about the use cases. On Thu, Feb 28, 2019 at 12:25 PM Gautam Parai wrote: > Great work team! Looks great :) > > Gautam > > On Thu, Feb 28, 2019 at 11:56 AM Jyothsna Reddy > wrote: > > > This is some awesome addition to the website!! > > > > > > > > On Thu, Feb

Re: Anouncing Powered-By-Drill page

2019-02-28 Thread Gautam Parai
Great work team! Looks great :) Gautam On Thu, Feb 28, 2019 at 11:56 AM Jyothsna Reddy wrote: > This is some awesome addition to the website!! > > > > On Thu, Feb 28, 2019 at 9:38 AM Pritesh Maker wrote: > > > This is awesome! Thanks for driving this and also to Aashreya for his > >

Re: Anouncing Powered-By-Drill page

2019-02-28 Thread Jyothsna Reddy
This is some awesome addition to the website!! On Thu, Feb 28, 2019 at 9:38 AM Pritesh Maker wrote: > This is awesome! Thanks for driving this and also to Aashreya for his > contribution with creating the page! > > On Wed, Feb 27, 2019 at 4:21 PM Abhishek Girish > wrote: > > > This is great!

[GitHub] dvjyothsna opened a new pull request #1666: DRILL-7058: Refresh command to support subset of columns

2019-02-28 Thread GitBox
dvjyothsna opened a new pull request #1666: DRILL-7058: Refresh command to support subset of columns URL: https://github.com/apache/drill/pull/1666 @gparai Please review This is an automated message from the Apache Git

[GitHub] vvysotskyi commented on a change in pull request #1646: DRILL-6852: Adapt current Parquet Metadata cache implementation to use Drill Metastore API

2019-02-28 Thread GitBox
vvysotskyi commented on a change in pull request #1646: DRILL-6852: Adapt current Parquet Metadata cache implementation to use Drill Metastore API URL: https://github.com/apache/drill/pull/1646#discussion_r261341058 ## File path:

[GitHub] jculio opened a new pull request #1665: DRILL-7054: timestamp in milliseconds

2019-02-28 Thread GitBox
jculio opened a new pull request #1665: DRILL-7054: timestamp in milliseconds URL: https://github.com/apache/drill/pull/1665 A column has been added for retrieving the timestamp in microseconds. The pcap provides microseconds accuracy and such a parameter is really important for

Re: [DISCUSS] Whether to create separate 2.0 branch

2019-02-28 Thread Parth Chandra
+1 for a 2.0 branch. Feature specific branches can be created off the 2.0 branch, and should ideally be merged periodically. I would also suggest that we adopt a C-T-R policy [1] for the 2.0 branch until it is at a stable point. Finally, I would assume that it is up to the feature developers to

Re: Anouncing Powered-By-Drill page

2019-02-28 Thread Pritesh Maker
This is awesome! Thanks for driving this and also to Aashreya for his contribution with creating the page! On Wed, Feb 27, 2019 at 4:21 PM Abhishek Girish wrote: > This is great! Thanks for making it happen. > > On Wed, Feb 27, 2019 at 4:12 PM Kunal Khatua wrote: > > > Hi everyone > > > > It

Re: [DISCUSS] Whether to create separate 2.0 branch

2019-02-28 Thread Arina Yelchiyeva
+1 for option a. I think backward compatibility can be handled via temp options, for interfaces since we use Java 8 default methods can be used. In case of more extreme cases, they should be postponed till 2.0 branch is created. Kind regards, Arina > On Feb 28, 2019, at 7:25 PM, Pritesh Maker

Re: [DISCUSS] Whether to create separate 2.0 branch

2019-02-28 Thread Vitalii Diravka
Looks like Drill Metastore will not break backward compatibility. Therefore I think as long as this is true, (a) option will be preferable for changes related to Drill Metastore Kind regards Vitalii On Thu, Feb 28, 2019 at 7:26 PM Pritesh Maker wrote: > I think option (a) is better in terms

Re: [DISCUSS] Whether to create separate 2.0 branch

2019-02-28 Thread Pritesh Maker
I think option (a) is better in terms of maintaining branches. With option (a) how do we handle a situation where one of these features breaks backward compatibility or deprecates some functionality? Pritesh On Wed, Feb 27, 2019 at 4:23 PM Abhishek Girish wrote: > My opinion would be option

[GitHub] nareshgbhat commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues

2019-02-28 Thread GitBox
nareshgbhat commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues URL: https://github.com/apache/drill/pull/1651#discussion_r261299408 ## File path: distribution/pom.xml ## @@ -371,42 +369,81 @@

[GitHub] vdiravka commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues

2019-02-28 Thread GitBox
vdiravka commented on a change in pull request #1651: DRILL-7042: Fix deb and rpm package issues URL: https://github.com/apache/drill/pull/1651#discussion_r261236035 ## File path: distribution/pom.xml ## @@ -371,42 +369,81 @@ -

[GitHub] vvysotskyi commented on issue #1646: DRILL-6852: Adapt current Parquet Metadata cache implementation to use Drill Metastore API

2019-02-28 Thread GitBox
vvysotskyi commented on issue #1646: DRILL-6852: Adapt current Parquet Metadata cache implementation to use Drill Metastore API URL: https://github.com/apache/drill/pull/1646#issuecomment-468230125 Here is a class diagram for some classes from this PR: