[GitHub] [drill] kkhatua opened a new pull request #1742: DRILL-7160: e.q.max_rows QUERY-level option shown even if not set

2019-04-08 Thread GitBox
kkhatua opened a new pull request #1742: DRILL-7160: e.q.max_rows QUERY-level option shown even if not set URL: https://github.com/apache/drill/pull/1742 The fix is to force setting to zero IFF autoLimit was intended to be set originally but is inapplicable; such as 'SHOW DATABASES'. If

[GitHub] [drill] dvjyothsna commented on issue #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
dvjyothsna commented on issue #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#issuecomment-481106364 Looks good to me. This is an automated message

[GitHub] [drill] Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r273302668 ## File path:

[GitHub] [drill] Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r273302407 ## File path:

[GitHub] [drill] Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r273302288 ## File path:

[GitHub] [drill] Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r273302187 ## File path:

[GitHub] [drill] Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r273300809 ## File path:

[GitHub] [drill] Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r273300586 ## File path:

[GitHub] [drill] amansinha100 commented on issue #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
amansinha100 commented on issue #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#issuecomment-481070256 @vvysotskyi , @dvjyothsna I have addressed your review comments. Pls take a look.

[GitHub] [drill] amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273299242 ## File path:

[GitHub] [drill] amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273299198 ## File path:

[GitHub] [drill] amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273299166 ## File path:

[GitHub] [drill] amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273298899 ## File path:

[GitHub] [drill] dvjyothsna commented on issue #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata

2019-04-08 Thread GitBox
dvjyothsna commented on issue #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata URL: https://github.com/apache/drill/pull/1723#issuecomment-481062555 Thank you @amansinha100. Squashed the commits into one commit.

[GitHub] [drill] amansinha100 merged pull request #1733: DRILL-7119: Compute range predicate selectivity using histograms.

2019-04-08 Thread GitBox
amansinha100 merged pull request #1733: DRILL-7119: Compute range predicate selectivity using histograms. URL: https://github.com/apache/drill/pull/1733 This is an automated message from the Apache Git Service. To respond

Re: [DISCUSS] 1.16.0 release

2019-04-08 Thread Sorabh Hamirwasia
Hi All, I will create 1.16.0 branch later today and will merge in all ready-to-commit JIRA's. Please try to close most of the PR's by EOD today (around 5:30 P.M. PST). Once the branch is created I will work on reverting the protobuf changes on 1.16.0 branch. There are few other JIRA's which are

[GitHub] [drill] dvjyothsna commented on issue #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata

2019-04-08 Thread GitBox
dvjyothsna commented on issue #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata URL: https://github.com/apache/drill/pull/1723#issuecomment-481014934 @amansinha100 I have addressed the review comments. Can you please take a look at it.

[GitHub] [drill] dvjyothsna commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata

2019-04-08 Thread GitBox
dvjyothsna commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata URL: https://github.com/apache/drill/pull/1723#discussion_r273244597 ## File path:

[GitHub] [drill] dvjyothsna commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata

2019-04-08 Thread GitBox
dvjyothsna commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata URL: https://github.com/apache/drill/pull/1723#discussion_r273244458 ## File path:

[GitHub] [drill] amansinha100 commented on issue #1733: DRILL-7119: Compute range predicate selectivity using histograms.

2019-04-08 Thread GitBox
amansinha100 commented on issue #1733: DRILL-7119: Compute range predicate selectivity using histograms. URL: https://github.com/apache/drill/pull/1733#issuecomment-481012094 @gparai I added a unit test for histogram usage and addressed your comment. Could you pls take another look ?

[GitHub] [drill] amansinha100 commented on a change in pull request #1733: DRILL-7119: Compute range predicate selectivity using histograms.

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1733: DRILL-7119: Compute range predicate selectivity using histograms. URL: https://github.com/apache/drill/pull/1733#discussion_r273239384 ## File path:

[GitHub] [drill] amansinha100 commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata URL: https://github.com/apache/drill/pull/1723#discussion_r273224323 ## File path:

[GitHub] [drill] amansinha100 commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata URL: https://github.com/apache/drill/pull/1723#discussion_r273217885 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
vvysotskyi commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273213654 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
vvysotskyi commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273211742 ## File path:

[GitHub] [drill] dvjyothsna commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
dvjyothsna commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273161135 ## File path:

[GitHub] [drill] dvjyothsna commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
dvjyothsna commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273158196 ## File path:

[GitHub] [drill] amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273124323 ## File path:

[jira] [Created] (DRILL-7160) exec.query.max_rows QUERY-level options are shown on Profiles tab

2019-04-08 Thread Volodymyr Vysotskyi (JIRA)
Volodymyr Vysotskyi created DRILL-7160: -- Summary: exec.query.max_rows QUERY-level options are shown on Profiles tab Key: DRILL-7160 URL: https://issues.apache.org/jira/browse/DRILL-7160 Project:

[GitHub] [drill] arina-ielchiieva commented on issue #1741: DRILL-7159: Fix typeString method to return correct name for MAP (aka STRUCT)

2019-04-08 Thread GitBox
arina-ielchiieva commented on issue #1741: DRILL-7159: Fix typeString method to return correct name for MAP (aka STRUCT) URL: https://github.com/apache/drill/pull/1741#issuecomment-480907197 @vvysotskyi please review. This

[GitHub] [drill] arina-ielchiieva opened a new pull request #1741: DRILL-7159: Fix typeString method to return correct name for MAP (aka STRUCT)

2019-04-08 Thread GitBox
arina-ielchiieva opened a new pull request #1741: DRILL-7159: Fix typeString method to return correct name for MAP (aka STRUCT) URL: https://github.com/apache/drill/pull/1741 Jira [DRILL-7159](https://issues.apache.org/jira/browse/DRILL-7159).

[GitHub] [drill] amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates.

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1736: DRILL-7064: Leverage the summary metadata for plain COUNT aggregates. URL: https://github.com/apache/drill/pull/1736#discussion_r273124323 ## File path:

[jira] [Created] (DRILL-7159) After renaming MAP to STRUCT typeString method still outputs MAP name

2019-04-08 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-7159: --- Summary: After renaming MAP to STRUCT typeString method still outputs MAP name Key: DRILL-7159 URL: https://issues.apache.org/jira/browse/DRILL-7159 Project:

[GitHub] [drill] amansinha100 commented on issue #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API

2019-04-08 Thread GitBox
amansinha100 commented on issue #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API URL: https://github.com/apache/drill/pull/1728#issuecomment-480885230 @vvysotskyi thanks for the explanations. I am mostly good

[jira] [Created] (DRILL-7158) null values for varchar, interval, boolean are displayed as empty in SqLine

2019-04-08 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-7158: --- Summary: null values for varchar, interval, boolean are displayed as empty in SqLine Key: DRILL-7158 URL: https://issues.apache.org/jira/browse/DRILL-7158

[jira] [Resolved] (DRILL-7144) sqlline option : !set useLineContinuation false, fails with ParseException

2019-04-08 Thread Arina Ielchiieva (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-7144. - Resolution: Fixed > sqlline option : !set useLineContinuation false, fails with

[GitHub] [drill] arina-ielchiieva closed pull request #1734: DRILL-7045: UDF string_binary java.lang.IndexOutOfBoundsException

2019-04-08 Thread GitBox
arina-ielchiieva closed pull request #1734: DRILL-7045: UDF string_binary java.lang.IndexOutOfBoundsException URL: https://github.com/apache/drill/pull/1734 This is an automated message from the Apache Git Service. To

[GitHub] [drill] arina-ielchiieva commented on issue #1734: DRILL-7045: UDF string_binary java.lang.IndexOutOfBoundsException

2019-04-08 Thread GitBox
arina-ielchiieva commented on issue #1734: DRILL-7045: UDF string_binary java.lang.IndexOutOfBoundsException URL: https://github.com/apache/drill/pull/1734#issuecomment-480780319 Merged with commits: a1986a3fec1634812712e47be0be2565b303ea2d 771fd270b684bbf388c0e2fa10b359eba3dfdb7c

[GitHub] [drill] asfgit closed pull request #1739: DRILL-7049: REST API returns the toString of byte arrays (VARBINARY types)

2019-04-08 Thread GitBox
asfgit closed pull request #1739: DRILL-7049: REST API returns the toString of byte arrays (VARBINARY types) URL: https://github.com/apache/drill/pull/1739 This is an automated message from the Apache Git Service. To

[GitHub] [drill] asfgit closed pull request #1740: DRILL-7157: Wrap SchemaParsingException into UserException when creating schema

2019-04-08 Thread GitBox
asfgit closed pull request #1740: DRILL-7157: Wrap SchemaParsingException into UserException when creating schema URL: https://github.com/apache/drill/pull/1740 This is an automated message from the Apache Git Service. To

[GitHub] [drill] asfgit closed pull request #1726: DRILL-7143: Support default value for empty columns

2019-04-08 Thread GitBox
asfgit closed pull request #1726: DRILL-7143: Support default value for empty columns URL: https://github.com/apache/drill/pull/1726 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [drill] vvysotskyi commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API

2019-04-08 Thread GitBox
vvysotskyi commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API URL: https://github.com/apache/drill/pull/1728#discussion_r272945631 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API

2019-04-08 Thread GitBox
vvysotskyi commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API URL: https://github.com/apache/drill/pull/1728#discussion_r272964601 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API

2019-04-08 Thread GitBox
vvysotskyi commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API URL: https://github.com/apache/drill/pull/1728#discussion_r272954092 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API

2019-04-08 Thread GitBox
vvysotskyi commented on a change in pull request #1728: DRILL-7089: Implement caching for TableMetadataProvider at query level and adapt statistics to use Drill metastore API URL: https://github.com/apache/drill/pull/1728#discussion_r272945731 ## File path:

[GitHub] [drill] agozhiy commented on issue #1739: DRILL-7049: REST API returns the toString of byte arrays (VARBINARY types)

2019-04-08 Thread GitBox
agozhiy commented on issue #1739: DRILL-7049: REST API returns the toString of byte arrays (VARBINARY types) URL: https://github.com/apache/drill/pull/1739#issuecomment-480757987 +1 This is an automated message from the

[GitHub] [drill] arina-ielchiieva commented on issue #1739: DRILL-7049: REST API returns the toString of byte arrays (VARBINARY types)

2019-04-08 Thread GitBox
arina-ielchiieva commented on issue #1739: DRILL-7049: REST API returns the toString of byte arrays (VARBINARY types) URL: https://github.com/apache/drill/pull/1739#issuecomment-480720296 +1, LGTM. This is an automated

[GitHub] [drill] arina-ielchiieva commented on issue #1734: DRILL-7045: UDF string_binary java.lang.IndexOutOfBoundsException

2019-04-08 Thread GitBox
arina-ielchiieva commented on issue #1734: DRILL-7045: UDF string_binary java.lang.IndexOutOfBoundsException URL: https://github.com/apache/drill/pull/1734#issuecomment-480719700 +1 This is an automated message from the

[GitHub] [drill] vdiravka closed pull request #1672: DRILL-7049 return VARBINARY as a string with escaped non printable bytes

2019-04-08 Thread GitBox
vdiravka closed pull request #1672: DRILL-7049 return VARBINARY as a string with escaped non printable bytes URL: https://github.com/apache/drill/pull/1672 This is an automated message from the Apache Git Service. To

[GitHub] [drill] arina-ielchiieva commented on issue #1740: DRILL-7157: Wrap SchemaParsingException into UserException when creating schema

2019-04-08 Thread GitBox
arina-ielchiieva commented on issue #1740: DRILL-7157: Wrap SchemaParsingException into UserException when creating schema URL: https://github.com/apache/drill/pull/1740#issuecomment-480718133 @vvysotskyi please review. This

[GitHub] [drill] arina-ielchiieva opened a new pull request #1740: DRILL-7157: Wrap SchemaParsingException into UserException when creating schema

2019-04-08 Thread GitBox
arina-ielchiieva opened a new pull request #1740: DRILL-7157: Wrap SchemaParsingException into UserException when creating schema URL: https://github.com/apache/drill/pull/1740 Jira - [DRILL-7157](https://issues.apache.org/jira/browse/DRILL-7157)

[GitHub] [drill] paul-rogers commented on issue #1726: DRILL-7143: Support default value for empty columns

2019-04-08 Thread GitBox
paul-rogers commented on issue #1726: DRILL-7143: Support default value for empty columns URL: https://github.com/apache/drill/pull/1726#issuecomment-480707171 Squashed commits. Should be ready to go. This is an automated

[GitHub] [drill] Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
Ben-Zvi commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r272902214 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java

[GitHub] [drill] amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r272898686 ## File path:

[GitHub] [drill] amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r272896651 ## File path:

[GitHub] [drill] amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning

2019-04-08 Thread GitBox
amansinha100 commented on a change in pull request #1738: DRILL-7062: Initial implementation of run-time row-group pruning URL: https://github.com/apache/drill/pull/1738#discussion_r272898010 ## File path:

[jira] [Created] (DRILL-7157) Wrap SchemaParsingException into UserException when creating schema

2019-04-08 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-7157: --- Summary: Wrap SchemaParsingException into UserException when creating schema Key: DRILL-7157 URL: https://issues.apache.org/jira/browse/DRILL-7157 Project: