[GitHub] [drill] cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

2020-04-11 Thread GitBox
cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#issuecomment-612551648 @paul-rogers I rebased this branch on master. This is an

[jira] [Resolved] (DRILL-6672) Drill table functions cannot handle "setFoo" accessors

2020-04-11 Thread Paul Rogers (Jira)
[ https://issues.apache.org/jira/browse/DRILL-6672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Rogers resolved DRILL-6672. Resolution: Not A Problem Storage and format plugins must be immutable since their entire values

[GitHub] [drill] asfgit closed pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup

2020-04-11 Thread GitBox
asfgit closed pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup URL: https://github.com/apache/drill/pull/2050 This is an automated message from the Apache Git Service. To respond

[GitHub] [drill] asfgit closed pull request #2045: DRILL-7683: Add "message parsing" to new JSON loader

2020-04-11 Thread GitBox
asfgit closed pull request #2045: DRILL-7683: Add "message parsing" to new JSON loader URL: https://github.com/apache/drill/pull/2045 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [drill] asfgit closed pull request #2044: DRILL-7678: Update Yauaa Dependency

2020-04-11 Thread GitBox
asfgit closed pull request #2044: DRILL-7678: Update Yauaa Dependency URL: https://github.com/apache/drill/pull/2044 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [drill] asfgit closed pull request #2040: DRILL-7668: Allow Time Bucket Function to Accept Floats and Timestamps

2020-04-11 Thread GitBox
asfgit closed pull request #2040: DRILL-7668: Allow Time Bucket Function to Accept Floats and Timestamps URL: https://github.com/apache/drill/pull/2040 This is an automated message from the Apache Git Service. To respond to

[GitHub] [drill] asfgit closed pull request #2047: DRILL-7675: Work around for partitions sender memory use

2020-04-11 Thread GitBox
asfgit closed pull request #2047: DRILL-7675: Work around for partitions sender memory use URL: https://github.com/apache/drill/pull/2047 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407075167 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407075244 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407075338 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407074984 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407073746 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407074717 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DynamicColumn.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407073237 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407074119 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407074521 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/AbstractColumnMetadata.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407074862 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/TupleSchema.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407074770 ## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DynamicColumn.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407073123 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2051: DRILL-7696: EVF v2 scan schema resolution URL: https://github.com/apache/drill/pull/2051#discussion_r407073811 ## File path:

[GitHub] [drill] arina-ielchiieva commented on issue #2045: DRILL-7683: Add "message parsing" to new JSON loader

2020-04-11 Thread GitBox
arina-ielchiieva commented on issue #2045: DRILL-7683: Add "message parsing" to new JSON loader URL: https://github.com/apache/drill/pull/2045#issuecomment-612423451 Changes look ok, but I don't think we should do this since PR has been already reviewed. I will send follow-up email

[GitHub] [drill] arina-ielchiieva commented on issue #2052: DRILL-7603 and DRILL-7604: Add schema, options to REST query

2020-04-11 Thread GitBox
arina-ielchiieva commented on issue #2052: DRILL-7603 and DRILL-7604: Add schema, options to REST query URL: https://github.com/apache/drill/pull/2052#issuecomment-612420174 @paul-rogers changes look good but I have two questions: 1. the screenshot in the PR title does not show how

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2052: DRILL-7603 and DRILL-7604: Add schema, options to REST query

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2052: DRILL-7603 and DRILL-7604: Add schema, options to REST query URL: https://github.com/apache/drill/pull/2052#discussion_r407062664 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2052: DRILL-7603 and DRILL-7604: Add schema, options to REST query

2020-04-11 Thread GitBox
arina-ielchiieva commented on a change in pull request #2052: DRILL-7603 and DRILL-7604: Add schema, options to REST query URL: https://github.com/apache/drill/pull/2052#discussion_r407062641 ## File path:

[GitHub] [drill] arina-ielchiieva commented on issue #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup

2020-04-11 Thread GitBox
arina-ielchiieva commented on issue #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup URL: https://github.com/apache/drill/pull/2050#issuecomment-612414695 +1, LGTM. This is an automated message