cgivre commented on a change in pull request #2428:
URL: https://github.com/apache/drill/pull/2428#discussion_r785378826
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##
@@ -364,6 +368,36 @@ private void
pjfanning commented on a change in pull request #2428:
URL: https://github.com/apache/drill/pull/2428#discussion_r785377804
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##
@@ -364,6 +368,36 @@ private void
cgivre commented on a change in pull request #2428:
URL: https://github.com/apache/drill/pull/2428#discussion_r785376820
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##
@@ -364,6 +368,27 @@ private void
pjfanning commented on a change in pull request #2428:
URL: https://github.com/apache/drill/pull/2428#discussion_r785376059
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##
@@ -364,6 +368,27 @@ private void
pjfanning commented on a change in pull request #2428:
URL: https://github.com/apache/drill/pull/2428#discussion_r785376059
##
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##
@@ -364,6 +368,27 @@ private void
cgivre commented on pull request #2428:
URL: https://github.com/apache/drill/pull/2428#issuecomment-1013781073
@pjfanning Would you mind doing a quick review of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cgivre opened a new pull request #2428:
URL: https://github.com/apache/drill/pull/2428
# [DRILL-8108](https://issues.apache.org/jira/browse/DRILL-8108): Excel
Reader Fails with Duplicate Columns
## Description
In its current implementation, if Drill encounters an Excel file which
Charles Givre created DRILL-8108:
Summary: Excel Reader Fails with Duplicate Columns
Key: DRILL-8108
URL: https://issues.apache.org/jira/browse/DRILL-8108
Project: Apache Drill
Issue Type:
cgivre commented on pull request #2427:
URL: https://github.com/apache/drill/pull/2427#issuecomment-1013770006
> tbh styles should used if you are inferring the schema - I just thought
the existing code wasn't using them
>
> One enhancement that I think Drill needs is to allow the
pjfanning commented on pull request #2427:
URL: https://github.com/apache/drill/pull/2427#issuecomment-1013769560
tbh styles should used if you are inferring the schema - I just thought the
existing code wasn't using them
One enhancement that I think Drill needs is to allow the
[
https://issues.apache.org/jira/browse/DRILL-8095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PJ Fanning resolved DRILL-8095.
---
Fix Version/s: 1.20.0
Resolution: Fixed
PR merged
> format-excel reader - upgrade to POI
cgivre merged pull request #2427:
URL: https://github.com/apache/drill/pull/2427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cgivre commented on pull request #2427:
URL: https://github.com/apache/drill/pull/2427#issuecomment-1013768959
> @cgivre see latest comment on
https://issues.apache.org/jira/browse/DRILL-8095 - not loading the styles
breaks existing Drill tests - so I abandoned that bit of the change
pjfanning commented on pull request #2427:
URL: https://github.com/apache/drill/pull/2427#issuecomment-1013768187
@cgivre see latest comment on
https://issues.apache.org/jira/browse/DRILL-8095 - not loading the styles
breaks existing Drill tests - so I abandoned that bit of the change
pjfanning opened a new pull request #2427:
URL: https://github.com/apache/drill/pull/2427
# [DRILL-8095](https://issues.apache.org/jira/browse/DRILL-8095): upgrade to
poi 5.2.0 and ignore cell styles
## Description
upgrade to poi 5.2.0 and ignore cell styles (to avoid
15 matches
Mail list logo
