[GitHub] [drill] paul-rogers commented on issue #2446: Expose `org.apache.drill.test` artifact so that end-users can use `ClusterFixtureBuilder` to create embedded Drill applications

2022-01-31 Thread GitBox
paul-rogers commented on issue #2446: URL: https://github.com/apache/drill/issues/2446#issuecomment-1026540149 Great idea. I wrote a lot of that code originally, let me know if you have questions. The dependencies might be related to things like the test-only row set classes, integrations

[GitHub] [drill] lgtm-com[bot] commented on pull request #2445: DRILL-8121: Add Partial Support for Per-User Credentials

2022-01-31 Thread GitBox
lgtm-com[bot] commented on pull request #2445: URL: https://github.com/apache/drill/pull/2445#issuecomment-1026502775 This pull request **introduces 2 alerts** when merging 95bdfdccbfc01673f093c8ba92b90ea763738624 into 2b47cec3a95966e119dac643050544c93b45be15 - [view on

[GitHub] [drill] jnturton edited a comment on issue #2446: Expose `org.apache.drill.test` artifact so that end-users can use `ClusterFixtureBuilder` to create embedded Drill applications

2022-01-31 Thread GitBox
jnturton edited a comment on issue #2446: URL: https://github.com/apache/drill/issues/2446#issuecomment-1026489976 There was some discussion in the mailing list in Novemever that might help you, maybe you can collaborate with @rymarm (who sent the emails) on this... EDIT: Oh dear,

[GitHub] [drill] jnturton commented on issue #2446: Expose `org.apache.drill.test` artifact so that end-users can use `ClusterFixtureBuilder` to create embedded Drill applications

2022-01-31 Thread GitBox
jnturton commented on issue #2446: URL: https://github.com/apache/drill/issues/2446#issuecomment-1026489976 There was some discussion in the mailing list in Novemever that might help you, maybe you can collaborate with @rymarm (who sent the emails) on this...

[GitHub] [drill] GavinRay97 opened a new issue #2446: Expose `org.apache.drill.test` artifact so that end-users can use `ClusterFixtureBuilder` to create embedded Drill applications

2022-01-31 Thread GitBox
GavinRay97 opened a new issue #2446: URL: https://github.com/apache/drill/issues/2446 Hello, I would like to embed Drill in a JVM application, running as a single node in-memory. I will feed it Calcite `RelNode` relational expressions to execute that my application is generating.

[GitHub] [drill] cgivre opened a new pull request #2445: DRILL-8121: Add Partial Support for Per-User Credentials

2022-01-31 Thread GitBox
cgivre opened a new pull request #2445: URL: https://github.com/apache/drill/pull/2445 # [DRILL-8121](https://issues.apache.org/jira/browse/DRILL-8121): Add Partial Support for Per-User Credentials ## Description One of the major limitations of Drill is that per-user credentials

[jira] [Created] (DRILL-8121) Add Partial Support for Per-User Credentials

2022-01-31 Thread Charles Givre (Jira)
Charles Givre created DRILL-8121: Summary: Add Partial Support for Per-User Credentials Key: DRILL-8121 URL: https://issues.apache.org/jira/browse/DRILL-8121 Project: Apache Drill Issue

[GitHub] [drill] cgivre merged pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-31 Thread GitBox
cgivre merged pull request #2401: URL: https://github.com/apache/drill/pull/2401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cgivre commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-31 Thread GitBox
cgivre commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r796000232 ## File path: pom.xml ## @@ -467,6 +467,7 @@ **/*.dbf **/*.cnf **/*.access_log +**/success.ftl Review

[GitHub] [drill] cgivre commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-31 Thread GitBox
cgivre commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r795987213 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/oauth/Tokens.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-31 Thread GitBox
cgivre commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r795985634 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/oauth/Tokens.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] cgivre commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-31 Thread GitBox
cgivre commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r795983922 ## File path: logical/src/main/java/org/apache/drill/common/logical/security/CredentialsProvider.java ## @@ -33,6 +37,20 @@ * Returns map with

[GitHub] [drill] cgivre commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-31 Thread GitBox
cgivre commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r795983829 ## File path: logical/src/main/java/org/apache/drill/common/logical/security/PlainCredentialsProvider.java ## @@ -47,6 +51,18 @@ public

[GitHub] [drill] cgivre commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-31 Thread GitBox
cgivre commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r795982198 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/oauth/TokenRegistry.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (DRILL-8120) Make Drill functional tests viable again.

2022-01-31 Thread Anton Gozhiy (Jira)
Anton Gozhiy created DRILL-8120: --- Summary: Make Drill functional tests viable again. Key: DRILL-8120 URL: https://issues.apache.org/jira/browse/DRILL-8120 Project: Apache Drill Issue Type:

[GitHub] [drill] vvysotskyi commented on a change in pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

2022-01-31 Thread GitBox
vvysotskyi commented on a change in pull request #2401: URL: https://github.com/apache/drill/pull/2401#discussion_r795927690 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/oauth/Tokens.java ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

[GitHub] [drill] vvysotskyi commented on pull request #2433: DRILL-8111: Remove lombok usage

2022-01-31 Thread GitBox
vvysotskyi commented on pull request #2433: URL: https://github.com/apache/drill/pull/2433#issuecomment-1025847513 @paul-rogers, thanks for the review, I've addressed the CR comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [drill] luocooong commented on a change in pull request #2419: DRILL-8085: EVF V2 support in the "Easy" format plugin

2022-01-31 Thread GitBox
luocooong commented on a change in pull request #2419: URL: https://github.com/apache/drill/pull/2419#discussion_r795558592 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/project/ReaderSchemaOrchestrator.java ## @@ -68,10 +71,11 @@ public

[GitHub] [drill] luocooong commented on a change in pull request #2419: DRILL-8085: EVF V2 support in the "Easy" format plugin

2022-01-31 Thread GitBox
luocooong commented on a change in pull request #2419: URL: https://github.com/apache/drill/pull/2419#discussion_r795557310 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/ScanOperatorExec.java ## @@ -32,6 +32,24 @@ * Implementation of

[GitHub] [drill] jnturton commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-31 Thread GitBox
jnturton commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r795533511 ## File path: contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcWriterWithH2.java ## @@ -142,14 +142,14 @@ public void

[GitHub] [drill] jnturton commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-31 Thread GitBox
jnturton commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r795532467 ## File path: contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcWriterWithH2.java ## @@ -142,14 +142,14 @@ public void

[jira] [Resolved] (DRILL-7989) Use the UTC formatter in the JSON reader

2022-01-31 Thread James Turton (Jira)
[ https://issues.apache.org/jira/browse/DRILL-7989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton resolved DRILL-7989. - Resolution: Fixed > Use the UTC formatter in the JSON reader >

[jira] [Resolved] (DRILL-8028) Add PDF Format Plugin

2022-01-31 Thread James Turton (Jira)
[ https://issues.apache.org/jira/browse/DRILL-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Turton resolved DRILL-8028. - Resolution: Fixed > Add PDF Format Plugin > - > > Key:

[GitHub] [drill] vdiravka commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-31 Thread GitBox
vdiravka commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r795453094 ## File path: distribution/pom.xml ## @@ -199,28 +199,30 @@ io.netty netty-tcnative - 2.0.1.Final + 2.0.47.Final

Re: [VOTE] Freeze for Drill 1.20

2022-01-31 Thread James Turton
In addition to the vulnerable dependencies, of which H2 does not upgrade cleanly, there is now another new release blocker: DRILL-8119 - MongoDB query regression: mem leak and data type error Regards James On 2022/01/30 01:51, Charles Givre

[jira] [Created] (DRILL-8119) MongoDB query regression: mem leak and data type error

2022-01-31 Thread James Turton (Jira)
James Turton created DRILL-8119: --- Summary: MongoDB query regression: mem leak and data type error Key: DRILL-8119 URL: https://issues.apache.org/jira/browse/DRILL-8119 Project: Apache Drill

[GitHub] [drill] vdiravka commented on a change in pull request #2432: DRILL-7994: Dependency version updates for severe vulnerabilities

2022-01-31 Thread GitBox
vdiravka commented on a change in pull request #2432: URL: https://github.com/apache/drill/pull/2432#discussion_r795446355 ## File path: contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcWriterWithH2.java ## @@ -142,14 +142,14 @@ public void