[GitHub] [drill] jnturton commented on a diff in pull request #2659: DRILL-8317: Convert LogRegex Format Plugin to EVF V2

2022-09-22 Thread GitBox
jnturton commented on code in PR #2659: URL: https://github.com/apache/drill/pull/2659#discussion_r978279426 ## contrib/format-log/src/main/java/org/apache/drill/exec/store/log/LogBatchReader.java: ## @@ -215,18 +208,14 @@ public boolean next() { } private boolean

[GitHub] [drill] cgivre commented on pull request #2599: DRILL-4232 Support for EXCEPT and INTERSECT set operator

2022-09-22 Thread GitBox
cgivre commented on PR #2599: URL: https://github.com/apache/drill/pull/2599#issuecomment-1255460340 Hi @Leon-WTF how is this coming? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [drill] cgivre opened a new pull request, #2659: DRILL-8317: Convert LogRegex Format Plugin to EVF V2

2022-09-22 Thread GitBox
cgivre opened a new pull request, #2659: URL: https://github.com/apache/drill/pull/2659 # [DRILL-8317](https://issues.apache.org/jira/browse/DRILL-8317): Convert LogRegex Format Plugin to EVF V2 ## Description This PR converts the log/regex reader to use EVF V2. It also

[GitHub] [drill] cgivre merged pull request #2654: DRILL-8311: Convert SPSS Format Plugin to EVF V2

2022-09-22 Thread GitBox
cgivre merged PR #2654: URL: https://github.com/apache/drill/pull/2654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] cgivre merged pull request #2656: DRILL-8315: Convert SAS Format Plugin to EVF V2

2022-09-22 Thread GitBox
cgivre merged PR #2656: URL: https://github.com/apache/drill/pull/2656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[jira] [Created] (DRILL-8317) Convert LogRegex Format Plugin to EVF V2

2022-09-22 Thread Charles Givre (Jira)
Charles Givre created DRILL-8317: Summary: Convert LogRegex Format Plugin to EVF V2 Key: DRILL-8317 URL: https://issues.apache.org/jira/browse/DRILL-8317 Project: Apache Drill Issue Type:

[GitHub] [drill] jnturton commented on a diff in pull request #2652: DRILL-8190: Fix mongo project pushdown for queries with joins

2022-09-22 Thread GitBox
jnturton commented on code in PR #2652: URL: https://github.com/apache/drill/pull/2652#discussion_r977498910 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/plan/rule/PluginIntermediatePrelConverterRule.java: ## @@ -53,7 +54,7 @@ public void onMatch(RelOptRuleCall

[GitHub] [drill] jnturton commented on pull request #2652: DRILL-8190: Fix mongo project pushdown for queries with joins

2022-09-22 Thread GitBox
jnturton commented on PR #2652: URL: https://github.com/apache/drill/pull/2652#issuecomment-1254813953 I don't have the expertise to spot any problems here so LGTM and I'll just ask some general questions here and there. -- This is an automated message from the Apache Git Service. To