vvysotskyi commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r981716643
##
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java:
##
@@ -52,12 +59,81 @@ public QueryContext getContext() {
return
vvysotskyi commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r981705289
##
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java:
##
@@ -130,11 +132,18 @@ private static PhysicalPlan convertPlan(QueryContext
jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r981328928
##
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java:
##
@@ -130,11 +132,18 @@ private static PhysicalPlan convertPlan(QueryContext
vvysotskyi commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r980305587
##
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java:
##
@@ -1094,6 +1095,35 @@ public static String bootDefaultFor(String name) {
new
jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979835243
##
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java:
##
@@ -1094,6 +1095,35 @@ public static String bootDefaultFor(String name) {
new
jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979835243
##
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java:
##
@@ -1094,6 +1095,35 @@ public static String bootDefaultFor(String name) {
new
jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979833628
##
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java:
##
@@ -1094,6 +1095,35 @@ public static String bootDefaultFor(String name) {
new
jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979823862
##
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java:
##
@@ -34,12 +34,22 @@ public interface StoragePluginRegistry extends
Iterable
jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979818742
##
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java:
##
@@ -52,12 +59,81 @@ public QueryContext getContext() {
return
jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979810768
##
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java:
##
@@ -130,11 +132,18 @@ private static PhysicalPlan convertPlan(QueryContext
jnturton commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979810768
##
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java:
##
@@ -130,11 +132,18 @@ private static PhysicalPlan convertPlan(QueryContext
jnturton merged PR #2652:
URL: https://github.com/apache/drill/pull/2652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jnturton commented on PR #2652:
URL: https://github.com/apache/drill/pull/2652#issuecomment-1257540369
Thanks for the explanations +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vvysotskyi commented on code in PR #2652:
URL: https://github.com/apache/drill/pull/2652#discussion_r979593075
##
exec/java-exec/src/main/java/org/apache/drill/exec/store/plan/rel/PluginAggregateRel.java:
##
@@ -51,7 +51,7 @@ public Aggregate copy(RelTraitSet traitSet, RelNode
vvysotskyi commented on code in PR #2652:
URL: https://github.com/apache/drill/pull/2652#discussion_r979588979
##
exec/java-exec/src/main/java/org/apache/drill/exec/store/enumerable/DynamicTypeResolverBuilder.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
vvysotskyi commented on code in PR #2655:
URL: https://github.com/apache/drill/pull/2655#discussion_r979578252
##
exec/java-exec/src/main/java/org/apache/calcite/jdbc/DynamicRootSchema.java:
##
@@ -91,22 +91,69 @@ private CalciteSchema getSchema(String schemaName, boolean
jnturton commented on PR #1750:
URL: https://github.com/apache/drill/pull/1750#issuecomment-1256165816
Or, if we do want to keep this built in ability to partition existing
profiles, perhaps we should have it launched from a button on the Profiles page
in the web UI instead of on Drillbit
jnturton commented on PR #1750:
URL: https://github.com/apache/drill/pull/1750#issuecomment-1256153990
Hi Kunal! Thank you for this contribution, I'd like to help to move it
forward.
> However, I am not sure if we should automatically index any new profile
that has been copy-pasted
cgivre merged PR #2659:
URL: https://github.com/apache/drill/pull/2659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre commented on PR #2659:
URL: https://github.com/apache/drill/pull/2659#issuecomment-1256130697
@jnturton Thanks for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jnturton commented on PR #2655:
URL: https://github.com/apache/drill/pull/2655#issuecomment-1255872622
Switched to Draft to prevent merging because the second reviewer has
requested an opportunity to review (likely on Monday).
--
This is an automated message from the Apache Git Service.
jnturton commented on code in PR #2659:
URL: https://github.com/apache/drill/pull/2659#discussion_r978279426
##
contrib/format-log/src/main/java/org/apache/drill/exec/store/log/LogBatchReader.java:
##
@@ -215,18 +208,14 @@ public boolean next() {
}
private boolean
cgivre commented on PR #2599:
URL: https://github.com/apache/drill/pull/2599#issuecomment-1255460340
Hi @Leon-WTF how is this coming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cgivre opened a new pull request, #2659:
URL: https://github.com/apache/drill/pull/2659
# [DRILL-8317](https://issues.apache.org/jira/browse/DRILL-8317): Convert
LogRegex Format Plugin to EVF V2
## Description
This PR converts the log/regex reader to use EVF V2. It also
cgivre merged PR #2654:
URL: https://github.com/apache/drill/pull/2654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre merged PR #2656:
URL: https://github.com/apache/drill/pull/2656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
jnturton commented on code in PR #2652:
URL: https://github.com/apache/drill/pull/2652#discussion_r977498910
##
exec/java-exec/src/main/java/org/apache/drill/exec/store/plan/rule/PluginIntermediatePrelConverterRule.java:
##
@@ -53,7 +54,7 @@ public void onMatch(RelOptRuleCall
jnturton commented on PR #2652:
URL: https://github.com/apache/drill/pull/2652#issuecomment-1254813953
I don't have the expertise to spot any problems here so LGTM and I'll just
ask some general questions here and there.
--
This is an automated message from the Apache Git Service.
To
warcry2000 opened a new issue, #2658:
URL: https://github.com/apache/drill/issues/2658
**Describe the bug**
2022-09-21 14:15:43,683 [qtp122612345-1489] ERROR
o.a.d.e.server.rest.QueryResources - Query from Web UI Failed: {}
org.apache.drill.common.exceptions.UserRemoteException:
cgivre opened a new pull request, #2657:
URL: https://github.com/apache/drill/pull/2657
# [DRILL-8316](https://issues.apache.org/jira/browse/DRILL-8316): Convert
Druid Storage Plugin to EVF & V2 JSON Reader
## Description
Converts the Druid storage plugin to use the V2 JSON
cgivre opened a new pull request, #2656:
URL: https://github.com/apache/drill/pull/2656
# [DRILL-8315](https://issues.apache.org/jira/browse/DRILL-8315): Convert
SAS Format Plugin to EVF V2
## Description
Converts SAS Format Plugin to EVF V2. This is part of
jnturton opened a new pull request, #2655:
URL: https://github.com/apache/drill/pull/2655
# [DRILL-8314](https://issues.apache.org/jira/browse/DRILL-8314): Add
support for automatically disabling broken storage plugins
## Description
Enabled storage plugins may malfunction for
cgivre merged PR #2653:
URL: https://github.com/apache/drill/pull/2653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
jnturton commented on PR #2653:
URL: https://github.com/apache/drill/pull/2653#issuecomment-1251850425
A totally straightforward conversion, thanks +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jnturton merged PR #2638:
URL: https://github.com/apache/drill/pull/2638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cgivre opened a new pull request, #2654:
URL: https://github.com/apache/drill/pull/2654
# [DRILL-8311](https://issues.apache.org/jira/browse/DRILL-8311): Convert
SPSS Format Plugin to EVF V2
## Description
This PR converts the SPSS format plugin to use EVF V2.
##
cgivre opened a new pull request, #2653:
URL: https://github.com/apache/drill/pull/2653
# [DRILL-8310](https://issues.apache.org/jira/browse/DRILL-8310): Convert
Syslog Format to EVF V2
## Description
This PR converts the Syslog format reader to use EVF V2.
##
cgivre merged PR #2651:
URL: https://github.com/apache/drill/pull/2651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
vvysotskyi opened a new pull request, #2652:
URL: https://github.com/apache/drill/pull/2652
# [DRILL-8190](https://issues.apache.org/jira/browse/DRILL-8190): Fix mongo
project pushdown for queries with joins
## Description
Improved costs calculation for vertex drel to consider
jnturton commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973710035
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/RestClientWrapper.java:
##
@@ -17,38 +17,36 @@
*/
package
pjfanning commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973688572
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/RestClientWrapper.java:
##
@@ -17,38 +17,36 @@
*/
package
jnturton commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973688571
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/RestClientWrapper.java:
##
@@ -17,38 +17,36 @@
*/
package
pjfanning commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973687912
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/RestClientWrapper.java:
##
@@ -17,38 +17,36 @@
*/
package
jnturton merged PR #2650:
URL: https://github.com/apache/drill/pull/2650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cgivre commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973642947
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/DruidQueryClient.java:
##
@@ -48,20 +48,21 @@ public DruidQueryClient(String brokerURI,
cgivre commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973642898
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/DruidQueryClient.java:
##
@@ -48,20 +48,21 @@ public DruidQueryClient(String brokerURI,
pjfanning opened a new pull request, #2651:
URL: https://github.com/apache/drill/pull/2651
## Description
Upgrade POI libs and related libs
## Documentation
(Please describe user-visible changes similar to what should appear in the
Drill documentation.)
##
jnturton commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973543624
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/DruidQueryClient.java:
##
@@ -48,20 +48,21 @@ public DruidQueryClient(String brokerURI,
jnturton commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973144234
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/DruidQueryClient.java:
##
@@ -48,20 +48,21 @@ public DruidQueryClient(String brokerURI,
jnturton commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973144234
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/DruidQueryClient.java:
##
@@ -48,20 +48,21 @@ public DruidQueryClient(String brokerURI,
cgivre merged PR #2637:
URL: https://github.com/apache/drill/pull/2637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre commented on code in PR #2650:
URL: https://github.com/apache/drill/pull/2650#discussion_r973137352
##
contrib/storage-druid/src/main/java/org/apache/drill/exec/store/druid/rest/DruidQueryClient.java:
##
@@ -48,20 +48,21 @@ public DruidQueryClient(String brokerURI,
vvysotskyi commented on code in PR #2638:
URL: https://github.com/apache/drill/pull/2638#discussion_r972233224
##
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/DefaultFunctionResolver.java:
##
@@ -58,27 +56,20 @@ public DrillFuncHolder getBestMatch(List
methods,
jnturton commented on PR #2650:
URL: https://github.com/apache/drill/pull/2650#issuecomment-1248220657
I see I missed a spot, converting to draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jnturton opened a new pull request, #2650:
URL: https://github.com/apache/drill/pull/2650
# [DRILL-8307](https://issues.apache.org/jira/browse/DRILL-8307): Ensure
thread safety in the Druid plugin HTTP client
## Description
Replaces the Apache HttpClient in the Druid storage
jnturton commented on code in PR #2638:
URL: https://github.com/apache/drill/pull/2638#discussion_r971630497
##
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/DefaultFunctionResolver.java:
##
@@ -58,27 +56,20 @@ public DrillFuncHolder getBestMatch(List
methods,
cgivre closed issue #2561: Support RDBMS update, INSERT,delete
URL: https://github.com/apache/drill/issues/2561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
cgivre merged PR #2646:
URL: https://github.com/apache/drill/pull/2646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
vvysotskyi commented on code in PR #2638:
URL: https://github.com/apache/drill/pull/2638#discussion_r971097106
##
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/ResolverTypePrecedence.java:
##
@@ -21,148 +21,211 @@
import java.util.HashSet;
import java.util.Map;
vvysotskyi commented on code in PR #2646:
URL: https://github.com/apache/drill/pull/2646#discussion_r971063658
##
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java:
##
@@ -219,11 +220,14 @@ private static PhysicalPlan getQueryPlan(QueryContext
jnturton commented on code in PR #2646:
URL: https://github.com/apache/drill/pull/2646#discussion_r969561053
##
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java:
##
@@ -219,11 +220,14 @@ private static PhysicalPlan getQueryPlan(QueryContext
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1246863598
Getting through UT proved to be a veritable warren of rabbit holes! Which
probably says good things about the UT.
--
This is an automated message from the Apache Git Service.
To respond
cgivre merged PR #2612:
URL: https://github.com/apache/drill/pull/2612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre merged PR #2649:
URL: https://github.com/apache/drill/pull/2649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
pjfanning opened a new pull request, #2649:
URL: https://github.com/apache/drill/pull/2649
## Description
Another snakeyaml release and looks like another security issue
## Documentation
(Please describe user-visible changes similar to what should appear in the
Drill
jnturton commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r969754103
##
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws
kingswanwho commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r969746071
##
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws
cgivre merged PR #2648:
URL: https://github.com/apache/drill/pull/2648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre commented on PR #2648:
URL: https://github.com/apache/drill/pull/2648#issuecomment-1245420763
Just a note here, but my plan is to add additional fields. However Google's
access controls are tricky.
--
This is an automated message from the Apache Git Service.
To respond to the
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1245043064
Many of the casts exhibited above do already work in Drill. What we get here
is the elimination of some obscure broken cases like sqrt('5') and what is
hopefully a more intelligible and
kingswanwho commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r968518305
##
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws
jnturton commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r968538795
##
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws
kingswanwho commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r968518305
##
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws
kingswanwho commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r968518305
##
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws
cgivre commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1243728471
> Turns out this particular one isn't possible without breaking other things
that need VARCHAR to go to INT before it goes to DATE.
>
> ```
> apache drill> select
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1243628238
Turns out this particular one isn't possible without breaking other things
that need VARCHAR to go to INT before it goes to DATE.
```
apache drill> select date_diff('2022-09-08',
cgivre closed pull request #2461: DRILL-8136: Overload existing Math UDFs to
allow for VARCHAR input
URL: https://github.com/apache/drill/pull/2461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cgivre commented on PR #2461:
URL: https://github.com/apache/drill/pull/2461#issuecomment-1243197346
This PR is not necessary once https://github.com/apache/drill/pull/2638 is
merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cgivre merged PR #2642:
URL: https://github.com/apache/drill/pull/2642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre opened a new pull request, #2648:
URL: https://github.com/apache/drill/pull/2648
# [DRILL-8305](https://issues.apache.org/jira/browse/DRILL-8305): Add
Implicit Fields to Google Sheets Reader
## Description
See below.
## Documentation
Adds the following implicit
pjfanning commented on PR #2647:
URL: https://github.com/apache/drill/pull/2647#issuecomment-1242918756
adding 'security' label because of the XXE CVE this fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jnturton commented on PR #2647:
URL: https://github.com/apache/drill/pull/2647#issuecomment-1242884917
No fork, no cherry picking, just a library upgrade :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cgivre merged PR #2647:
URL: https://github.com/apache/drill/pull/2647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre merged PR #2645:
URL: https://github.com/apache/drill/pull/2645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
vvysotskyi opened a new pull request, #2647:
URL: https://github.com/apache/drill/pull/2647
# [DRILL-8304](https://issues.apache.org/jira/browse/DRILL-8304): Update
Calcite to 1.32.0
## Description
NA
## Documentation
NA
## Testing
Unit tests pass
--
vvysotskyi opened a new pull request, #2646:
URL: https://github.com/apache/drill/pull/2646
# [DRILL-8303](https://issues.apache.org/jira/browse/DRILL-8303): Add
support for inserts into JDBC storage
## Description
This PR contains changes required for adding support for inserts
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1242077430
```
Apache Drill 2.0.0-SNAPSHOT
"Drill must go on."
apache drill> select true = 'TrUe';
EXPR$0 true
1 row selected (3.336 seconds)
apache drill> select true =
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1242025805
> > I wonder whether ResolverTypePrecedence should cache computed casting
costs, or whether that would be premature optimisation.
>
> Maybe make that a separate PR. In theory the
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1242020822
> This is really a MAJOR usability improvement. Will it also be able to cast
`"true"` and `"false"` as boolean values? Likewise for:
>
> * True
>
> * TRUE
>
>
cgivre commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1241993355
@jnturton Did you see my question about boolean values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cgivre commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1241992856
> I wonder whether ResolverTypePrecedence should cache computed casting
costs, or whether that would be premature optimisation.
Maybe make that a separate PR. In theory the whole
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1241991578
I wonder whether ResolverTypePrecedence should cache computed casting costs,
or whether that would be premature optimisation.
--
This is an automated message from the Apache Git
jnturton merged PR #2640:
URL: https://github.com/apache/drill/pull/2640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cgivre merged PR #2641:
URL: https://github.com/apache/drill/pull/2641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
cgivre commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1240788876
>
This is really a MAJOR usability improvement. Will it also be able to cast
`"true"` and `"false"` as boolean values? Likewise for:
* True
* TRUE
* TrUe
etc
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1240784918
> >
>
> That brings a tear to me eye!
A piece I haven't added is a cast function implementation going from BIT to
INT using the normal 0 = false, 1 = true correspondence to
cgivre commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1240779567
>
That brings a tear to me eye!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jnturton commented on PR #2638:
URL: https://github.com/apache/drill/pull/2638#issuecomment-1240777691
> Queries like that will work in MySQL and other RDBMS. In Drill I think
they won't fail, but the results are not what people expect. For cases like
this, would '2020-01-01' be
cgivre merged PR #2631:
URL: https://github.com/apache/drill/pull/2631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
meyergin commented on issue #2644:
URL: https://github.com/apache/drill/issues/2644#issuecomment-1240739019
>
Yes, the backticks ` have been used. And I have tested dfs and s3 storage,
no one works.
1. dfs storage config:
{
"type": "file",
"connection": "file:///",
401 - 500 of 17907 matches
Mail list logo
