[GitHub] [drill] jnturton closed pull request #2609: DRILL-8267: Remove commons-configuration dependency management

jnturton closed pull request #2609: DRILL-8267: Remove commons-configuration dependency management URL: https://github.com/apache/drill/pull/2609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1196540449 > @jnturton, looks like this PR causes extra warnings: Thanks for catching this, I believe it's fixed now. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [drill] jnturton closed issue #2614: Missing 1.20.1 Release

jnturton closed issue #2614: Missing 1.20.1 Release URL: https://github.com/apache/drill/issues/2614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on issue #2614: Missing 1.20.1 Release

jnturton commented on issue #2614: URL: https://github.com/apache/drill/issues/2614#issuecomment-1196284912 Thank you for opening this. You're right that we're currently missing our 1.20.1 build due to some technical reasons but the good news is that we're just about to put up a 1.20.2

[GitHub] [drill] ankane opened a new issue, #2614: Missing 1.20.1 Release

ankane opened a new issue, #2614: URL: https://github.com/apache/drill/issues/2614 **Describe the bug** Hi, it looks like Drill 1.20.1 was released on May 16 according to [this post](https://drill.apache.org/blog/2022/05/16/drill-1.20.1-released/) and the [release

[GitHub] [drill] vvysotskyi commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

vvysotskyi commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1195743563 @jnturton, looks like this PR causes extra warnings: ``` 2022-07-26T14:35:28.5702064Z [WARNING] 2022-07-26T14:35:28.5703626Z [WARNING] Some problems were encountered while

[GitHub] [drill] martin-g commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

martin-g commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1195684710 Good job, James! On Tue, Jul 26, 2022, 18:37 James Turton ***@***.***> wrote: > @luocooong See > https://stackoverflow.com/a/61267496/497381

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1195642829 > @luocooong See https://stackoverflow.com/a/61267496/497381 ` java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;` is not available in JDK 1.8. It is available since Java 11. In 1.8 the

[GitHub] [drill] jnturton commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r930036634 ## pom.xml: ## @@ -3965,6 +3977,46 @@ + Review Comment: My audit of jars that were not present in 1.20.1-hadoop2

[GitHub] [drill] luocooong commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

luocooong commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1195301013 @cgivre @Z0ltrix I added two new options. If `namespace` is used, the `namespace:table` semantics are applied. And we can also use the `table` configuration only. The `family` is also an

[GitHub] [drill] cgivre merged pull request #2611: DRILL-8269: Classified metrics for easier maintenance

cgivre merged PR #2611: URL: https://github.com/apache/drill/pull/2611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] jnturton commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r929457387 ## exec/vector/pom.xml: ## @@ -25,7 +25,7 @@ org.apache.drill.exec 2.0.0-SNAPSHOT - vector + drill-vector Review Comment: @luocooong it is only the

[GitHub] [drill] jnturton commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r929457387 ## exec/vector/pom.xml: ## @@ -25,7 +25,7 @@ org.apache.drill.exec 2.0.0-SNAPSHOT - vector + drill-vector Review Comment: @luocooong it is only the

[GitHub] [drill] jnturton merged pull request #2613: DRILL-8272: Skip MAP column without children when creating parquet tables

jnturton merged PR #2613: URL: https://github.com/apache/drill/pull/2613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on a diff in pull request #2613: DRILL-8272: Skip MAP column without children when creating parquet tables

jnturton commented on code in PR #2613: URL: https://github.com/apache/drill/pull/2613#discussion_r929453717 ## exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java: ## @@ -94,23 +94,165 @@ public void setUp(MessageType schema, RecordConsumer consumer) {

[GitHub] [drill] luocooong commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

luocooong commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r929442941 ## exec/vector/pom.xml: ## @@ -25,7 +25,7 @@ org.apache.drill.exec 2.0.0-SNAPSHOT - vector + drill-vector Review Comment: Good point. It is

[GitHub] [drill] cgivre merged pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre merged PR #2585: URL: https://github.com/apache/drill/pull/2585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

[GitHub] [drill] vvysotskyi opened a new pull request, #2613: DRILL-8272: Skip MAP column without children when creating parquet tables

vvysotskyi opened a new pull request, #2613: URL: https://github.com/apache/drill/pull/2613 # [DRILL-8272](https://issues.apache.org/jira/browse/DRILL-8272): Skip MAP column without children when creating parquet tables ## Description TBA ## Documentation NA ##

[GitHub] [drill] vdiravka commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

vdiravka commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929183640 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929119471 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929116137 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929111001 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929029434 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929065365 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] vdiravka commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

vdiravka commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929060432 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] cgivre opened a new pull request, #2612: DRILL-8271: Make Storage and Format Config Case Insensitive

cgivre opened a new pull request, #2612: URL: https://github.com/apache/drill/pull/2612 # [DRILL-8271](https://issues.apache.org/jira/browse/DRILL-8271): Make Storage and Format Config Case Insensitive ## Description Allows format and storage configs to be case insensitive.

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929038841 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -33,6 +34,7 @@ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929030265 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929029434 ## contrib/native/client/patches/zookeeper-3.4.6-x64.patch: ## @@ -1,163 +0,0 @@ -From 64697ddd8a90f29d1693658f04e975e435e3c869 Mon Sep 17 00:00:00 2001 Review Comment:

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r929020952 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -33,6 +34,7 @@ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")

[GitHub] [drill] jnturton commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r928870530 ## exec/vector/pom.xml: ## @@ -25,7 +25,7 @@ org.apache.drill.exec 2.0.0-SNAPSHOT - vector + drill-vector Review Comment: @luocooong it was seeing

[GitHub] [drill] kingswanwho opened a new pull request, #2611: DRILL-8269: Classified metrics for easier maintenance

kingswanwho opened a new pull request, #2611: URL: https://github.com/apache/drill/pull/2611 # [DRILL-8269](https://issues.apache.org/jira/browse/DRILL-8269): Classified metrics for easier maintenance ## Description 1. Add classified prefix for metrics indicators like thread,

[GitHub] [drill] martin-g commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

martin-g commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1193986421 @luocooong See https://stackoverflow.com/a/61267496/497381 ` java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;` is not available in JDK 1.8. It is available since Java 11. In 1.8

[GitHub] [drill] luocooong commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

luocooong commented on code in PR #2610: URL: https://github.com/apache/drill/pull/2610#discussion_r928797183 ## exec/vector/pom.xml: ## @@ -25,7 +25,7 @@ org.apache.drill.exec 2.0.0-SNAPSHOT - vector + drill-vector Review Comment: Change is not the best

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1193860317 @luocooong @paul-rogers a bit of data related to the heap memory usage limiting from some experiments run by a helpful user. I did test the recommendation given by you and it worked

[GitHub] [drill] vvysotskyi commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

vvysotskyi commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1193350318 @jnturton, looks like this change causes Travis CI failures: ``` (java.lang.RuntimeException) java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;

[GitHub] [drill] Leon-WTF commented on pull request #2599: DRILL-4232 Support for EXCEPT and INTERSECT set operator

Leon-WTF commented on PR #2599: URL: https://github.com/apache/drill/pull/2599#issuecomment-1193267131 > @Leon-WTF You might want to wait until #2602 is merged before you continue this. #2602 is very cool, I will focus on implementing the operator firstly, and adapt to the new

[GitHub] [drill] cgivre commented on pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on PR #2585: URL: https://github.com/apache/drill/pull/2585#issuecomment-1193245110 @jnturton Thank you very much for your review of this beast. I believe I have addressed all your comments, as well as fixed the final bugs with the writer. -- This is an automated

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928194222 ## logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java: ## @@ -33,6 +34,7 @@ @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = "type")

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928194017 ## contrib/storage-googlesheets/src/test/java/org/apache/drill/exec/store/googlesheets/TestGoogleSheetsWriter.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928190871 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/columns/GoogleSheetsDateColumnWriter.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r928189718 ## exec/java-exec/src/main/java/org/apache/drill/exec/store/security/OAuthTokenCredentials.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton commented on PR #2610: URL: https://github.com/apache/drill/pull/2610#issuecomment-1193118355 @luocooong the main goal of this PR is to solve issues in RC0 of Drill 1.20.2 and produce RC1. Unrelated to that, I can expand a bit more on my reasoning for the commit disabling

[GitHub] [drill] Z0ltrix commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

Z0ltrix commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1193070802 > > Why compaction_enabled": false? I thought compaction is important for hbase to boost performance? > > As you know, HBase is a nightmare for operational services due to the

[GitHub] [drill] luocooong commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

luocooong commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1193070577 > Why compaction_enabled": false? I thought compaction is important for hbase to boost performance? As you know, HBase is a nightmare for operational services due to the

[GitHub] [drill] luocooong commented on a diff in pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

luocooong commented on code in PR #2596: URL: https://github.com/apache/drill/pull/2596#discussion_r928083609 ## contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStoreProvider.java: ## @@ -20,116 +20,233 @@ import java.io.IOException;

[GitHub] [drill] Z0ltrix commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

Z0ltrix commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1193058897 Why compaction_enabled": false? I thought compaction is important for hbase to boost performance? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [drill] Z0ltrix commented on a diff in pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

Z0ltrix commented on code in PR #2596: URL: https://github.com/apache/drill/pull/2596#discussion_r928077049 ## contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStoreProvider.java: ## @@ -20,116 +20,233 @@ import java.io.IOException;

[GitHub] [drill] Z0ltrix commented on a diff in pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

Z0ltrix commented on code in PR #2596: URL: https://github.com/apache/drill/pull/2596#discussion_r928076445 ## contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStoreProvider.java: ## @@ -20,116 +20,233 @@ import java.io.IOException;

[GitHub] [drill] luocooong commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

luocooong commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1192952208 @cgivre Hi, Thank you for the questions. Actually, Drill PStore' variables are split from the storage configurations, because the goal is to define the initial variables before the Drill

[GitHub] [drill] cgivre commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

cgivre commented on PR #2596: URL: https://github.com/apache/drill/pull/2596#issuecomment-1192943886 @luocooong Thanks for submitting this. I was wondering, is there a reason why we are storing these variables in `drill-override.conf` instead of the configuration for the storage plugin?

[GitHub] [drill] jnturton opened a new pull request, #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

jnturton opened a new pull request, #2610: URL: https://github.com/apache/drill/pull/2610 # [DRILL-8268](https://issues.apache.org/jira/browse/DRILL-8268): Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default ## Description New exclusions of

[GitHub] [drill] jnturton commented on pull request #2609: DRILL-8267: Remove commons-configuration dependency management

jnturton commented on PR #2609: URL: https://github.com/apache/drill/pull/2609#issuecomment-1192225931 @pjfanning are you happy to close this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] jnturton commented on a diff in pull request #2609: DRILL-8267: Remove commons-configuration dependency management

jnturton commented on code in PR #2609: URL: https://github.com/apache/drill/pull/2609#discussion_r926359954 ## pom.xml: ## @@ -1984,17 +1983,6 @@ xercesImpl ${xerces.version} - Review Comment: Okay @pjfanning, based on @vdiravka's comments I

[GitHub] [drill] vdiravka commented on a diff in pull request #2609: DRILL-8267: Remove commons-configuration dependency management

vdiravka commented on code in PR #2609: URL: https://github.com/apache/drill/pull/2609#discussion_r926320649 ## pom.xml: ## @@ -1984,17 +1983,6 @@ xercesImpl ${xerces.version} - Review Comment: This management is for two purposes: 1. Per

[GitHub] [drill] jnturton commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

jnturton commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r926253092 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsBatchReader.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r926191991 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsBatchReader.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache

[GitHub] [drill] jnturton merged pull request #2600: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 Phase 2

jnturton merged PR #2600: URL: https://github.com/apache/drill/pull/2600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton merged pull request #2597: DRILL-7960: Column metadata DECIMAL precision can exceed max supported value

jnturton merged PR #2597: URL: https://github.com/apache/drill/pull/2597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cgivre commented on pull request #2599: DRILL-4232 Support for EXCEPT and INTERSECT set operator

cgivre commented on PR #2599: URL: https://github.com/apache/drill/pull/2599#issuecomment-1190414440 @Leon-WTF You might want to wait until https://github.com/apache/drill/pull/2602 is merged before you continue this. -- This is an automated message from the Apache Git Service. To

[GitHub] [drill] lgtm-com[bot] commented on pull request #2600: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 Phase 2

lgtm-com[bot] commented on PR #2600: URL: https://github.com/apache/drill/pull/2600#issuecomment-1190172585 This pull request **fixes 9 alerts** when merging 76fe42a5c224a135e8e918fa1dedb94423d0db96 into da7f2da01cd7174ba93fa01c60dda9d5f090f059 - [view on

[GitHub] [drill] jnturton commented on pull request #2597: DRILL-7960: Column metadata DECIMAL precision can exceed max supported value

jnturton commented on PR #2597: URL: https://github.com/apache/drill/pull/2597#issuecomment-1190132339 > If I correctly understand the test you intend (my implementation is shown below) then the answer is that it does not reproduce the issue... Ignore this, I just hadn't run things

[GitHub] [drill] jnturton commented on pull request #2597: DRILL-7960: Column metadata DECIMAL precision can exceed max supported value

jnturton commented on PR #2597: URL: https://github.com/apache/drill/pull/2597#issuecomment-1190101257 > Yes, please add such a test. We have test methods that allow obtaining row set for query results. Doesn't this issue is reproduced when they are used? If I correctly understand

[GitHub] [drill] jnturton commented on a diff in pull request #2609: DRILL-8267: Remove commons-configuration dependency management

jnturton commented on code in PR #2609: URL: https://github.com/apache/drill/pull/2609#discussion_r925256805 ## pom.xml: ## @@ -1984,17 +1983,6 @@ xercesImpl ${xerces.version} - Review Comment: Note that what we're doing here is removing the

[GitHub] [drill] jnturton merged pull request #2608: DRILL-8266: number narrowing issues

jnturton merged PR #2608: URL: https://github.com/apache/drill/pull/2608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] jnturton commented on pull request #2605: DRILL-8265: Bump aws-java-sdk-s3 from 1.12.211 to 1.12.261 in /distribution

jnturton commented on PR #2605: URL: https://github.com/apache/drill/pull/2605#issuecomment-1189830423 @pjfanning yes, please label any patch / bugfix library upgrades with backport-to-stable. Major version number increases in libs are generally not candidates, by contrast. -- This is

[GitHub] [drill] jnturton commented on pull request #2604: Upgrade to netty 4.1.77

jnturton commented on PR #2604: URL: https://github.com/apache/drill/pull/2604#issuecomment-1189808590 Yes, unfortunately it looks like we'll need to do a bit of work in this instance. C.f. https://issues.apache.org/jira/browse/DRILL-8258 -- This is an automated message from the Apache

[GitHub] [drill] pjfanning commented on pull request #2605: DRILL-8265: Bump aws-java-sdk-s3 from 1.12.211 to 1.12.261 in /distribution

pjfanning commented on PR #2605: URL: https://github.com/apache/drill/pull/2605#issuecomment-1189779742 @jnturton is this a candidate for backporting ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [drill] pjfanning closed pull request #2604: Upgrade to netty 4.1.77

pjfanning closed pull request #2604: Upgrade to netty 4.1.77 URL: https://github.com/apache/drill/pull/2604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [drill] pjfanning commented on pull request #2604: Upgrade to netty 4.1.77

pjfanning commented on PR #2604: URL: https://github.com/apache/drill/pull/2604#issuecomment-1189778297 closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [drill] jnturton commented on pull request #2607: DRILL-8262: Remove Xalan Dependency

jnturton commented on PR #2607: URL: https://github.com/apache/drill/pull/2607#issuecomment-1189777929 @kingswanwho another one to backport to the stable branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [drill] pjfanning commented on pull request #2609: DRILL-8267: try to remove commons-configuration jar

pjfanning commented on PR #2609: URL: https://github.com/apache/drill/pull/2609#issuecomment-1189772826 I suspect that maybe hadoop (or some other lib) used to use commons-configuration instead of commons-configuration2 as it does now - and that Drill added the dependency to try to keep

[GitHub] [drill] luocooong merged pull request #2605: DRILL-8265: Bump aws-java-sdk-s3 from 1.12.211 to 1.12.261 in /distribution

luocooong merged PR #2605: URL: https://github.com/apache/drill/pull/2605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] luocooong merged pull request #2607: DRILL-8262: Remove Xalan Dependency

luocooong merged PR #2607: URL: https://github.com/apache/drill/pull/2607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] luocooong merged pull request #2606: DRILL-8264: upgrade joda-time

luocooong merged PR #2606: URL: https://github.com/apache/drill/pull/2606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] luocooong merged pull request #2603: DRILL-8263: upgrade libpam4j due to CVE

luocooong merged PR #2603: URL: https://github.com/apache/drill/pull/2603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r925114706 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsGroupScan.java: ## @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r925113788 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r925113509 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/utils/GoogleSheetsTypifier.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache

[GitHub] [drill] pjfanning opened a new pull request, #2609: DRILL-8267: try to remove commons-configuration jar

pjfanning opened a new pull request, #2609: URL: https://github.com/apache/drill/pull/2609 ## Description (Please describe the change. If more than one ticket is fixed, include a reference to those tickets.) ## Documentation (Please describe user-visible changes similar to

[GitHub] [drill] lgtm-com[bot] commented on pull request #2608: DRILL-8266: number narrowing issues

lgtm-com[bot] commented on PR #2608: URL: https://github.com/apache/drill/pull/2608#issuecomment-1189666470 This pull request **fixes 9 alerts** when merging b3774e573414bb84a6c865e8ab8d47c6c5efe404 into 2cb1cec4af8c65348511a126100323b3eee0b252 - [view on

[GitHub] [drill] pjfanning opened a new pull request, #2608: DRILL-8266: number narrowing issues

pjfanning opened a new pull request, #2608: URL: https://github.com/apache/drill/pull/2608 ## Description (Please describe the change. If more than one ticket is fixed, include a reference to those tickets.) ## Documentation (Please describe user-visible changes similar to

[GitHub] [drill] pjfanning commented on pull request #2605: Bump aws-java-sdk-s3 from 1.12.211 to 1.12.261 in /distribution

pjfanning commented on PR #2605: URL: https://github.com/apache/drill/pull/2605#issuecomment-1189545802 https://issues.apache.org/jira/browse/DRILL-8265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [drill] pjfanning opened a new pull request, #2607: DRILL-8264: remove xalan dependency

pjfanning opened a new pull request, #2607: URL: https://github.com/apache/drill/pull/2607 ## Description The mapr contrib component still pulls xalan transitively via https://mvnrepository.com/artifact/com.mapr.hadoop/maprfs/6.1.0-mapr ## Documentation (Please describe

[GitHub] [drill] pjfanning opened a new pull request, #2606: DRILL-8264: upgrade joda-time

pjfanning opened a new pull request, #2606: URL: https://github.com/apache/drill/pull/2606 ## Description (Please describe the change. If more than one ticket is fixed, include a reference to those tickets.) ## Documentation (Please describe user-visible changes similar to

[GitHub] [drill] pjfanning commented on pull request #2604: Upgrade to netty 4.1.77

pjfanning commented on PR #2604: URL: https://github.com/apache/drill/pull/2604#issuecomment-1189494317 Seems to cause a test failure: VectorTest.testEmptyValuePopulator:304 expected:<0> but was:<41138> -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [drill] dependabot[bot] opened a new pull request, #2605: Bump aws-java-sdk-s3 from 1.12.211 to 1.12.261 in /distribution

dependabot[bot] opened a new pull request, #2605: URL: https://github.com/apache/drill/pull/2605 Bumps [aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.211 to 1.12.261. Changelog Sourced from

[GitHub] [drill] cgivre commented on pull request #2604: Upgrade to netty 4.1.77

cgivre commented on PR #2604: URL: https://github.com/apache/drill/pull/2604#issuecomment-1189492404 @pjfanning There was some major bug involving netty. We had to roll back to this version to get things to work. @jnturton Can you please advise on this? -- This is an automated

[GitHub] [drill] pjfanning opened a new pull request, #2604: Upgrade to netty 4.1.77

pjfanning opened a new pull request, #2604: URL: https://github.com/apache/drill/pull/2604 # [DRILL-](https://issues.apache.org/jira/browse/DRILL-): PR Title (Please replace `PR Title` with actual PR Title) ## Description (Please describe the change. If more than

[GitHub] [drill] cgivre commented on pull request #2603: DRILL-8263: upgrade libpam4j due to CVE

cgivre commented on PR #2603: URL: https://github.com/apache/drill/pull/2603#issuecomment-1189486650 @jnturton Can we get this into Drill 1.20.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [drill] pjfanning opened a new pull request, #2603: DRILL-8263: upgrade libpam4j due to CVE

pjfanning opened a new pull request, #2603: URL: https://github.com/apache/drill/pull/2603 ## Description CVE in libpam4j ## Documentation (Please describe user-visible changes similar to what should appear in the Drill documentation.) ## Testing (Please describe

[GitHub] [drill] vvysotskyi commented on pull request #2597: DRILL-7960: Column metadata DECIMAL precision can exceed max supported value

vvysotskyi commented on PR #2597: URL: https://github.com/apache/drill/pull/2597#issuecomment-1189475834 Yes, please add such a test. We have test methods that allow obtaining row set for query results. Doesn't this issue is reproduced when they are used? -- This is an automated message

[GitHub] [drill] jnturton commented on pull request #2597: DRILL-7960: Column metadata DECIMAL precision can exceed max supported value

jnturton commented on PR #2597: URL: https://github.com/apache/drill/pull/2597#issuecomment-1189411225 > @jnturton, I meant the test case that reproduces the issue from the ticket, when an error is thrown during creating a row set with results of the query execution. It is also possible

[GitHub] [drill] vvysotskyi commented on pull request #2597: DRILL-7960: Column metadata DECIMAL precision can exceed max supported value

vvysotskyi commented on PR #2597: URL: https://github.com/apache/drill/pull/2597#issuecomment-1189388641 @jnturton, I meant the test case that reproduces the issue from the ticket, when an error is thrown during creating a row set with results of the query execution. It is also possible

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924590296 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsGroupScan.java: ## @@ -0,0 +1,369 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924588140 ## contrib/storage-googlesheets/src/test/java/org/apache/drill/exec/store/googlesheets/TestGoogleSheetsQueries.java: ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924473537 ## contrib/storage-googlesheets/src/test/java/org/apache/drill/exec/store/googlesheets/TestGoogleSheetsLimitPushdown.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924465376 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsStoragePlugin.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924455886 ## contrib/storage-googlesheets/src/main/java/org/apache/drill/exec/store/googlesheets/GoogleSheetsPushDownListener.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the

[GitHub] [drill] cgivre commented on a diff in pull request #2585: DRILL-8235: Add Storage Plugin for Google Sheets

cgivre commented on code in PR #2585: URL: https://github.com/apache/drill/pull/2585#discussion_r924454323 ## contrib/storage-googlesheets/README.md: ## @@ -0,0 +1,156 @@ +# Google Sheets Connector for Apache Drill +This connector enables you to query and write to Google

<    3   4   5   6   7   8   9   10   11   12   >