GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/498
DRILL-4510: Revert DRILL-4476 since UnionAllRecordBatch cannot determâ¦
â¦ine if a given record batch is from an empty file or not, just according
to the number of rows
You can merge this pull
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/497
Drill 3764 preview
The feature for skip records. This PR is just for the record.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsuanyi
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/489#discussion_r62118608
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -734,6 +772,41 @@ public static FunctionCall
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/489#discussion_r62117749
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestFunctionsWithTypeExpoQueries.java
---
@@ -719,4 +727,73 @@ public void testWindowSumConstant
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/489#discussion_r62117505
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestFunctionsWithTypeExpoQueries.java
---
@@ -213,7 +221,7 @@ public void tesIsNull() throws
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/439#issuecomment-216920059
merge this PR with https://github.com/apache/drill/pull/489. So close this
one.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/439
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/490#issuecomment-216919724
merge this PR with https://github.com/apache/drill/pull/489. So close this
one.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-215801663
Hi @jcmcote,
I see. But can you do us a favor. Regex_replace()'s behavior changes after
your patch
https://issues.apache.org/jira/browse/DRILL-4645
Can
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/490
DRILL-3823, DRILL-4507: Add unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsuanyi/incubator-drill DRILL-3823
Alternatively you
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/489#issuecomment-215490663
@jinfengni Can you help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/489#issuecomment-215490190
DrillCalcite can be found at here:
https://github.com/hsuanyi/incubator-calcite/tree/DRILL-4642
---
If your project is set up for it, you can reply to this email
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/489
DRILL-4642: Remove customized RexBuilder.ensureType()
Bump calcite version to 1.4.0-drill-r12
You can merge this pull request into a Git repository by running:
$ git pull https
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-214905327
Yes, it passed the tests. I will push it shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-213650898
@jcmcote Sorry for the delay. Let me run some tests and commit it if it
passes the tests.
Your contribution is highly appreciated.
---
If your project is set up
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/461#issuecomment-210144139
In the background, Chun, Rahul and Jinfeng have done some experiments:
1. Functional-wise: If Hive uses storage-based impersonation, when a user
does "Show T
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/468#issuecomment-207904379
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-207904016
And can you share the details regarding the performance improvement? For
example, how the setting and data look like? Observed % of improvements?
---
If your project
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-207903918
Except for the comments, LGTM. Do you run the unit test ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/458#discussion_r59125828
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java
---
@@ -0,0 +1,49 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/458#discussion_r59125807
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java
---
@@ -0,0 +1,49 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58986459
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -72,4 +80,76 @@ public String
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58824977
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58824883
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -148,13 +139,41 @@ public String getName(int
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58758201
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -72,4 +80,76 @@ public String
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58758011
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -72,4 +80,76 @@ public String
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58751518
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -72,4 +80,56 @@ public String
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58750954
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java ---
@@ -194,4 +195,26 @@ public void dropTable(String tableName
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/461
DRILL-4577: Construct a specific path for querying all the tables froâ¦
â¦m a hive database
@vkorukanti Can you help review? Thanks.
You can merge this pull request into a Git repository
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/439#issuecomment-200919168
In addition to @jinfengni's point:
@sudheeshkatkam did a proposal to add a new SqlAvgAggFunction (the
inference mechanism of the original is not ideal for Drill
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/439
DRILL-4525: Allow SqlBetweenOperator to accept LOWER_OPERAND and UPPEâ¦
â¦R_OPERAND with different types
You can merge this pull request into a Git repository by running:
$ git pull https
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/438
DRILL-4525: Allow SqlBetweenOperator to accept LOWER_OPERAND and UPPEâ¦
â¦R_OPERAND with different types
You can merge this pull request into a Git repository by running:
$ git pull https
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/405#issuecomment-199650953
Except for my comments (which are for future improvements and can be filed
as follow-up jira issues)
LGTM +1 (non-binding)
---
If your project is set up
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/405#discussion_r56783075
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/DirectScanPrule.java
---
@@ -0,0 +1,40 @@
+/**
+ * Licensed
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hsuanyi closed the pull request at:
https://github.com/apache/drill/pull/433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56456027
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,740 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56455656
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,23 +118,106 @@ public DrillFunctionRegistry
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56455794
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
---
@@ -26,34 +33,88 @@
import
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56455331
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HiveUDFOperatorNotInfer.java
---
@@ -0,0 +1,44
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56455344
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -122,6 +127,13 @@ public int size
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56457961
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
---
@@ -26,34 +33,88 @@
import
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56453928
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperatorNotInfer.java
---
@@ -0,0 +1,76 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56455160
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java
---
@@ -204,4 +220,46 @@ private HiveFuncHolder
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56459546
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDFs.java
---
@@ -43,4 +43,32 @@ public void testEncode
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56453956
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperatorNotInfer.java
---
@@ -0,0 +1,76 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56704717
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,23 +114,100 @@ public DrillFunctionRegistry
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56456528
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillAvgVarianceConvertlet.java
---
@@ -40,7 +43,16 @@
public class
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56453886
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
---
@@ -62,11 +123,70 @@ public void lookupOperatorOverloads
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56527875
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -364,4 +401,35 @@ private static SchemaPlus rootSchema
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56456844
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -64,4 +108,47 @@ public boolean isDeterministic
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56454823
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -64,4 +108,47 @@ public boolean isDeterministic
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56527238
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -364,4 +401,35 @@ private static SchemaPlus rootSchema
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56455114
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,23 +118,106 @@ public DrillFunctionRegistry
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56458586
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -364,4 +401,35 @@ private static SchemaPlus rootSchema
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56431658
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
@@ -135,6 +135,16 @@ public RuleSet getRules(OptimizerRulesContext
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56458266
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -140,6 +140,10 @@ public DrillSqlOperatorBuilder
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/433
DRILL-4510: Force Union-All to happen in a single node
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsuanyi/incubator-drill DRILL-4510
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56523015
--- Diff:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDFs.java
---
@@ -43,4 +43,32 @@ public void testEncode
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56454252
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HiveUDFOperator.java
---
@@ -18,28 +18,20 @@
package
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56454010
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlAggOperator.java
---
@@ -17,47 +17,76 @@
*/
package
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56455697
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,23 +118,106 @@ public DrillFunctionRegistry
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56528868
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
---
@@ -26,34 +33,88 @@
import
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56454944
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
---
@@ -26,34 +33,88 @@
import
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56440041
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperatorNotInfer.java
---
@@ -0,0 +1,76 @@
+/**
+ * Licensed
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/407#issuecomment-195794797
Comments were added to the code; Also passed all the pre commit test. Can
you help commit this patch ?
---
If your project is set up for it, you can reply
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/423#discussion_r55730852
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java
---
@@ -460,4 +466,23 @@ public void
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/423
DRILL-4490: Ensure the count generated by ConvertCountToDirectScan isâ¦
⦠non-nullable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsuanyi
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/423#issuecomment-194618931
@jinfengni Can you help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/407#issuecomment-194598924
@amansinha100 I consolidated the two logic into one:
https://github.com/hsuanyi/incubator-drill/blob/DRILL-4476/exec/java-exec/src/main/java/org/apache/drill/exec
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55605493
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -491,6 +556,25 @@ private void
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55597867
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -294,13 +313,41 @@ public UnionAllInput
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55597640
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -527,6 +532,52 @@ public void testUnionAllRightEmptyJson() throws
Exception
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55596051
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -527,6 +532,52 @@ public void testUnionAllRightEmptyJson() throws
Exception
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/407#discussion_r55595195
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -162,6 +162,25 @@ private IterOutcome doWork
Github user hsuanyi commented on the pull request:
https://github.com/apache/drill/pull/407#issuecomment-192523111
@amansinha100 can you help review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/407
DRILL-4476: Allow UnionAllRecordBatch to manager situations where lefâ¦
â¦t input side or both sides come(s) from empty source(s).
You can merge this pull request into a Git repository by running
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54965064
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -17,40 +17,60 @@
*/
package
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54964989
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,568 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54964785
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,568 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54956465
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
---
@@ -100,8 +108,13 @@ public void onMatch
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54956169
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
---
@@ -100,8 +108,13 @@ public void onMatch
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54955354
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,568 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54955290
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,568 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54954482
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
---
@@ -770,6 +770,65 @@ public void eval
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54954517
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Checker.java ---
@@ -17,18 +17,51 @@
*/
package
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54952798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -17,40 +17,60 @@
*/
package
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54952793
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,38 +112,58 @@ public DrillFunctionRegistry
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54916226
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54916158
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54916066
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54915844
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -0,0 +1,571 @@
+/**
+ * Licensed
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54915765
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,38 +94,110 @@ public DrillFunctionRegistry
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54831804
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -92,38 +94,110 @@ public DrillFunctionRegistry
Github user hsuanyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r54787960
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -18,69 +18,43 @@
package
1 - 100 of 187 matches
Mail list logo
