[GitHub] drill issue #1178: DRILL-6278: Removed temp codegen directory in testing fra...

2018-03-24 Thread ilooner-mapr
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/1178 @vvysotskyi thanks for catching this. I've removed it from TopNBatchTest . ---

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner-mapr
Github user ilooner-mapr commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145572262 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueue.java --- @@ -20,22 +20,58 @@ import

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner-mapr
Github user ilooner-mapr commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145571158 --- Diff: common/src/test/java/org/apache/drill/test/DirTestWatcher.java --- @@ -32,23 +32,50 @@ public class DirTestWatcher extends TestWatcher

[GitHub] drill pull request #984: DRILL-5783 Made a unit test for generated Priority ...

2017-10-18 Thread ilooner-mapr
Github user ilooner-mapr commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r145561373 --- Diff: common/src/main/java/org/apache/drill/common/util/TestTools.java --- @@ -17,15 +17,28 @@ */ package org.apache.drill.common.util

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-25 Thread ilooner-mapr
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov I've fixed the source.skip switch to be maven.source.skip as you pointed out. For now I also made the **script** tag a noop since as you said the mvn package command is redundant

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

2017-08-25 Thread ilooner-mapr
Github user ilooner-mapr commented on a diff in the pull request: https://github.com/apache/drill/pull/913#discussion_r135312783 --- Diff: .travis.yml --- @@ -13,8 +13,9 @@ # See the License for the specific language governing permissions and # limitations under

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-24 Thread ilooner-mapr
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov I got it working with Trusty and explicitly configuring openjdk7. One thing to note is that Trusty was running out of memory doing the build with the default 4gb container size. So I had

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-24 Thread ilooner-mapr
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov It looks like the default jdk for Trusty on travis is jdk8. I'll check to see if explicitly telling travis to use jdk7 with Trusty is also a possible fix. --- If your project is set up

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-21 Thread ilooner-mapr
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov Spoke with Parth. Could you take a look at this PR? There are other issues with the travis build. For example it doesn't even run the unit tests right now. But this is a first step

[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build

2017-08-17 Thread ilooner-mapr
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @parthchandra --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

2017-08-17 Thread ilooner-mapr
GitHub user ilooner-mapr opened a pull request: https://github.com/apache/drill/pull/913 - DRILL-5729 Fix Travis Build You can merge this pull request into a Git repository by running: $ git pull https://github.com/ilooner-mapr/drill DRILL-5729 Alternatively you can review

[GitHub] drill pull request #912: - Test travis fix

2017-08-17 Thread ilooner-mapr
Github user ilooner-mapr closed the pull request at: https://github.com/apache/drill/pull/912 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request #912: - Test travis fix

2017-08-17 Thread ilooner-mapr
GitHub user ilooner-mapr opened a pull request: https://github.com/apache/drill/pull/912 - Test travis fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/ilooner-mapr/drill travisFix Alternatively you can review and apply

[GitHub] drill issue #911: - DRILL-5507 Made verbose info logging message debug level...

2017-08-17 Thread ilooner-mapr
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/911 Applied comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill issue #911: - DRILL-5507 Made verbose info logging message debug level...

2017-08-17 Thread ilooner-mapr
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/911 @paul-rogers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #911: - DRILL-5507 Made verbose info logging message debu...

2017-08-17 Thread ilooner-mapr
GitHub user ilooner-mapr opened a pull request: https://github.com/apache/drill/pull/911 - DRILL-5507 Made verbose info logging message debug level and print… …ed it less frequently You can merge this pull request into a Git repository by running: $ git pull https