Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/519
Other than prior comments, the pruning logic looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70532442
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java
---
@@ -211,9 +217,76 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70529269
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -143,6 +144,11 @@ public static final
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70527515
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/ParquetPartitionDescriptor.java
---
@@ -130,13 +131,13 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70524663
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -212,8 +223,12 @@ public TableScan
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70514652
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r70514381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -607,7 +607,14 @@ public long getRowCount
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/543#discussion_r70490413
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java
---
@@ -129,7 +132,7 @@ public
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/436
LGTM.
+1
Thanks for the PR, @arina-ielchiieva !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70379773
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java
---
@@ -0,0 +1,129
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70379333
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java
---
@@ -0,0 +1,129
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70379318
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java
---
@@ -0,0 +1,129
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70378389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java
---
@@ -0,0 +1,129
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70377349
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java ---
@@ -351,4 +359,51 @@ public void showFilesWithDefaultSchema
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/543#discussion_r70361935
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java
---
@@ -209,8 +213,10 @@ private
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/543#discussion_r70360847
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java
---
@@ -209,8 +213,10 @@ private
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/543
Revise the patch based on @vkorukanti 's comments.
Pls let me know if you have any further comment. Otherwise, I'll run
regression and merge the patch. Thanks.
---
If your project
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/518
@chunhui-shi , I saw you made comments days ago. Can you pls take a look at
the new patch to see if it addressed your comment? thx.
---
If your project is set up for it, you can reply
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/543
@sudheeshkatkam and @vkorukanti , can one of you review this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/543
DRILL-4768: Fix leaking hive meta store connection in Drill's hive meâ¦
â¦tastore client call.
do not call reconnect if the connection is still alive and the error is
caused by either
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/436
The new output looks better.
I checked hive's command. Seems it lists schema name
and its relevant properties. Does it make sense to add schema | database name
in the output
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69997781
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -36,6 +42,7 @@
*/
class
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69997455
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -219,11 +226,26 @@ public boolean
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69997336
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
@@ -219,11 +226,26 @@ public boolean
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69990725
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
@@ -61,7 +61,8 @@ public static PhysicalPlan getPlan
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/520#discussion_r69990123
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -274,6 +274,9 @@
String ENABLE_BULK_LOAD_TABLE_LIST_KEY
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r68814702
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -47,16 +47,25 @@
private List statuses
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/515
I cherry-picked CALCITE-528 from Calcite master branch, and put it into
Drill forked version.
@amansinha100 , could you please review this PR? thanks!
---
If your project is set up
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/521
@sudheeshkatkam , do you want to take a quick look and see if I have
addressed your comments? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68148042
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -186,4 +186,9 @@ public boolean
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68148064
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestCastFunctions.java
---
@@ -17,18 +17,16 @@
*/
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68148021
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -247,11 +275,13 @@ void flushCode() {
outer._throws
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68147991
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -215,22 +218,47 @@ public JVar
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68102519
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/SizedJBlock.java ---
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68102435
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -215,22 +219,47 @@ public JVar
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/521#discussion_r68102305
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -86,14 +88,16 @@ public static MappingSet getDefaultMapping
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/531#discussion_r68070931
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestImplicitFileColumns.java
---
@@ -110,4 +111,20 @@ public void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67716686
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -47,16 +47,25 @@
private List statuses
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67711244
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67709299
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -320,7 +377,17 @@ protected void doOnMatch
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67567993
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67567703
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java
---
@@ -151,7 +152,7 @@ protected void
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/519#discussion_r67567343
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
@@ -269,13 +283,54 @@ protected void
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/512
I did the following small changes to this PR, and I'm going to rebase and
re-run the regression suite before merge this PR.
1) fix one bug which causes regression failure (IOBE).
2) add
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/521
@jacques-n @amansinha100 , can you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/521
DRILL-4715: Fix java compilation error in run-time generated code wheâ¦
â¦n query has large number of expressions.
You can merge this pull request into a Git repository by running:
$ git
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/512
@jcmcote ,
Overall the patch looks good to me. Once you revise the code, I'll run the
regression and merge the code if no problem is found. Thanks for your patch!
---
If your project
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/512#discussion_r66894981
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
---
@@ -114,6 +114,19 @@ public void testRegexpMatches
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/512#discussion_r66894665
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java
---
@@ -17,13 +17,52 @@
*/
package
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/512#discussion_r65994802
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
---
@@ -114,6 +114,19 @@ public void testRegexpMatches
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/515
DRILL-4707: Fix memory leak or incorrect query result in case two colâ¦
â¦umn names are case-insensitive identical
Fix is mainly in CALCITE-528.
You can merge this pull request
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/512
@jcmcote , thanks for the new PR. I'll take a look tomorrow, and let you
know my feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/508#issuecomment-221749835
LGGM.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-221648222
@jcmcote , just wanna to check the current status of your latest fix.
FYI, you may consider using couple of existing methods [1] [2], when you
decode
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r64299811
--- Diff: exec/java-exec/src/main/resources/bootstrap-storage-plugins.json
---
@@ -6,11 +6,13 @@
workspaces: {
"
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r64299337
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java
---
@@ -25,23 +25,27 @@
* - location which is a path
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/504#discussion_r64064412
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -136,6 +145,10 @@ public VectorContainer
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/504#discussion_r64063077
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
@@ -146,6 +159,27 @@ protected IterOutcome
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-220393770
@jcmcote , I opened DRILL-4688 to track this incorrect regression. Please
use DRILL-4688 to submit either a patch or pull request to address this issue
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-219858967
@jcmcote ,
(copy from my comment in DRILL-4573)
I re-visited your first patch. Looks like that the change you made would
cause incorrect result when
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/502#issuecomment-219577333
@jcmcote , I'll take a look at the patch shortly. You are right that the
build issue should not be caused by your code change.
---
If your project is set up
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/436#issuecomment-218841649
I'm not talking about implementation side
(AbstractStoragePlugin.getPhysicalLocation etc). Before we go to
implementation, we probably want to define what's
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-218839576
@jcmcote
I'll review your new patch if it's ready.
Can you please submit the new patch as a new PR (or maybe I miss some part
of conversation and just
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/436#issuecomment-218786032
@arina-ielchiieva ,
1. the link you posted is actually not a public document. People in the
community could not see the content. You may paste some discussion
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/436#issuecomment-218630539
The patch will show "schema_name, location" for "describe schema xxx" when
it applied to file system schema. I'm not sure why you only want to ma
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/489#discussion_r62089298
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestFunctionsWithTypeExpoQueries.java
---
@@ -719,4 +727,73 @@ public void testWindowSumConstant
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/489#discussion_r62085424
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestFunctionsWithTypeExpoQueries.java
---
@@ -213,7 +221,7 @@ public void tesIsNull() throws
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/489#discussion_r62084962
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java
---
@@ -734,6 +772,41 @@ public static FunctionCall
Github user jinfengni closed the pull request at:
https://github.com/apache/drill/pull/379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r59090757
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -72,4 +80,76 @@ public String
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/468#issuecomment-207115616
@amansinha100 and @hsuanyi , I revised PR based on your comments. Can you
take another look? thx.
---
If your project is set up for it, you can reply
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58953148
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58949303
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/471
DRILL-4592: Explain plan statement should show plan in WebUI
@amansinha100 , could you review this small code patch? Thanks.
For now, there is lack of a way to add unit test for all WebUI
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58912269
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java
---
@@ -0,0 +1,70 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/468#discussion_r58911205
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
@@ -148,13 +139,41 @@ public String getName(int
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/468#issuecomment-206611168
@amansinha100 , could you please review this PR? thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/468
DRILL-4589: Reduce planning time for file system partition pruning byâ¦
⦠reducing filter evaluation overhead
You can merge this pull request into a Git repository by running:
$ git pull
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/461#issuecomment-205991638
@hsuanyi , did you do some preliminary performance comparison, to measure
the performance gain, with bulk loading and skip get_partition() for hive table
when doing
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58616431
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java ---
@@ -194,4 +195,26 @@ public void dropTable(String tableName
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/452#issuecomment-203744127
Other than one comment, look good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/452#discussion_r57998932
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java
---
@@ -40,6 +42,41 @@
public class
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/447#issuecomment-203461091
Since we have use same approach for regular sum() aggregate, it makes sense
to apply to window sum() aggregate function.
LGTM
+1.
---
If your
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/452#discussion_r57819554
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctionHelpers.java
---
@@ -213,11 +213,39 @@ public static long getDate
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/452#discussion_r57818552
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java
---
@@ -40,6 +41,36 @@
public class
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/444#issuecomment-201430413
I agree that your expectation for RelSubset makes sense to me. However, for
now it does not happen that way. The following is the trace for the query which
went
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/444
DRILL-4531: Add a Drill customized rule for pushing filter past aggreâ¦
â¦gate
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinfengni
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/439#issuecomment-200907542
My understanding is adding another operator will not work, since Calcite
parser has put the built-in between operator in the sql expression tree[1]. The
validator
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/439#issuecomment-200883747
Looks like the root cause of the problem is Calcite does not allow the
comparison of Date and Timestamp.
{code}
select CAST('1990-01-01' AS DATE) < C
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/405#issuecomment-20859
LGTM.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56426515
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java
---
@@ -122,6 +127,13 @@ public int size
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56427623
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperatorNotInfer.java
---
@@ -0,0 +1,76 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56435067
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -64,4 +108,47 @@ public boolean isDeterministic
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/397#issuecomment-198407062
Looks good to me.
+1
Some additional info
1. This PR has added an option to enable/disable the type inference feature
(by default, it's
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56524249
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -364,4 +401,35 @@ private static SchemaPlus rootSchema
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56458894
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java
---
@@ -64,4 +108,47 @@ public boolean isDeterministic
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56427768
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperatorNotInfer.java
---
@@ -0,0 +1,76 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56432884
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperatorNotInfer.java
---
@@ -0,0 +1,76 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56426363
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HiveUDFOperatorNotInfer.java
---
@@ -0,0 +1,44
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/397#discussion_r56439767
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -183,10 +190,40 @@ public SchemaPlus getDefaultSchema
301 - 400 of 539 matches
Mail list logo
