[GitHub] drill issue #1242: DRILL-6361: Revised typeOf() function versions

2018-04-30 Thread kfaraaz
Github user kfaraaz commented on the issue: https://github.com/apache/drill/pull/1242 Can you please add a unit test that covers these types, BINARY, BOOLEAN, DECIMAL, DATE, TIME and TIMESTAMP ? ---

[GitHub] drill issue #1159: DRILL-6215: Changed Statement to PreparedStatement in Jdb...

2018-03-16 Thread kfaraaz
Github user kfaraaz commented on the issue: https://github.com/apache/drill/pull/1159 I don't know about the other file, I didn't add it. Let me check. Thanks, Khurram ---

[GitHub] drill pull request #1159: DRILL-6215: Changed Statement to PreparedStatement...

2018-03-09 Thread kfaraaz
GitHub user kfaraaz opened a pull request: https://github.com/apache/drill/pull/1159 DRILL-6215: Changed Statement to PreparedStatement in JdbcRecordReader @bitblender Can you please review ? You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill issue #868: DRILL-5547:Linking config options with system option manag...

2017-07-18 Thread kfaraaz
Github user kfaraaz commented on the issue: https://github.com/apache/drill/pull/868 @dvjyothsna Can you please add unit tests that cover your changes ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill issue #518: DRILL-4653.json - Malformed JSON should not stop the entir...

2016-10-08 Thread kfaraaz
Github user kfaraaz commented on the issue: https://github.com/apache/drill/pull/518 The below JSON is invalid, due to presence of duplicate key 'key'. Today Drill returns a DATA_READ error, does your proposed fix handle this case too ? [root@centos-01 ~]# cat f1.json {&quo