Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/742
This closes PR #742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/739
This closes PR #739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910265
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +192,13 @@ public QProfiles(List
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910137
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -220,7 +225,21 @@ public QProfiles
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910132
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -220,7 +225,21 @@ public QProfiles
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101910087
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -220,7 +225,21 @@ public QProfiles
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101879098
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +193,13 @@ public QProfiles(List
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101872793
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +193,13 @@ public QProfiles(List
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101872723
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -61,7 +64,7 @@
public class
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/751#discussion_r101864433
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -190,10 +193,13 @@ public QProfiles(List
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/751
DRILL-5259: Allow listing a user-defined number of profiles
Allow changing default number of finished queries in web UI, when starting
up Drillbits
-Ddrill.exec.http.max_profiles=100
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/742
@sudheeshkatkam Please review the PR and label the JIRA, so that @jinfengni
can get it into the commit list for master.
---
If your project is set up for it, you can reply to this email and have
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r101115347
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
---
@@ -122,6 +125,31 @@ public String getQueryId
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r100925486
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -417,6 +417,9 @@ private void parseAndRunPhysicalPlan(final
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/739
@paul-rogers Created a new SimpleDurationFormat class. We can expand to
have more formats, or reimplement on lines of SimpleDateFormat by passing
format strings in the future. Hope this helps
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/742#discussion_r100612470
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -163,11 +165,18 @@ public String
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99975170
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -352,16 +369,26 @@ public String cancelQuery
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/742#discussion_r99975093
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/OperatorWrapper.java
---
@@ -163,11 +165,18 @@ public String getMetricsTable
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/739
@paul-rogers , @sudheeshkatkam
Committed changes based on your recommendations. I also noticed that some
of the calls were passing fragment IDs as links, which were never applied.
Based on the
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r99454561
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -77,12 +77,14 @@
*/
public
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/742
DRILL-5242: The UI breaks when rendering profiles having unknown metrics
Skip any metrics whose metric ID is unknown, This prevents any
ArrayIndexOutOfBoundsException from being thrown and breaking
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/738#discussion_r99408793
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -77,12 +77,14 @@
*/
public
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99393776
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -56,6 +47,30 @@ public TableBuilder(final String
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/739#discussion_r99393441
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/TableBuilder.java
---
@@ -56,6 +47,30 @@ public TableBuilder(final String
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/739
DRILL-5230: Translation of millisecond duration into hours is incorrect
Fixed invalid representation of readable elapsed time using `TimeUnit`
class in JDK.
e.g. 4545 sec is now correctly
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/732
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/732
Pending testcases
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/738
DRILL-5190: Display planning time for a query in its profile page
Modified UserSharedBit protobuf for marking planning end time. This will
allow for accurately reporting the planning time of a query
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/737
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/737
DRILL-5190: Display planning time for a query in its profile page
Modified UserSharedBit protobuf for marking planning end time. This will
allow for accurately reporting the planning time of a query
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/732
DRILL-5230: Translation of millisecond duration into hours is incorrect
Fixed invalid representation of readable elapsed time using `TimeUnit`
class in JDK.
e.g. 4545 sec is now correctly
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/721
@arina-ielchiieva , @paul-rogers , @sudheeshkatkam
Closed the previous PR due to mixup with squashing and rebasing. Please
review this PR.
---
If your project is set up for it, you can reply
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/721
DRILL-5172: Display elapsed time for queries in the UI
Displays the elapsed time for running queries and the total duration of
completed/failed/cancelled queries in the list of query profiles
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/719
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/719
Closing the pull request. Attempted to rebase and squash, but got
interleaved commits with master. Will send out a new pull request.
---
If your project is set up for it, you can reply to this
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95692761
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -106,6 +106,7 @@
STATE: ${model.getProfile().getState().name
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95475935
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String getTime
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95470389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String getTime
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95469066
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -13595,6 +13597,17 @@ public long getEnd() {
return end_
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95432224
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -105,6 +109,25 @@ public String getTime
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95327930
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -13595,6 +13597,17 @@ public long getEnd() {
return end_
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95108121
--- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl ---
@@ -64,6 +65,8 @@
${query.getState
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95107988
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -72,16 +72,30 @@
public static final
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/719
DRILL-5172: Display elapsed time for queries in the UI
Displays the elapsed time for running queries and the total duration of
completed/failed/cancelled queries in the list of query profiles
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/655#discussion_r88602974
--- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
@@ -132,7 +132,7 @@
<#list model.getOptionList() as opt
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/655
@arina-ielchiieva Your fix will not conflict, but is in a branch rebased
off 4b1902c .
@sudheeshkatkam had reverted the commit for DRILL-4373 2 days later. He is
using the following branch to
Github user kkhatua commented on the pull request:
https://github.com/apache/drill/pull/71#issuecomment-143909578
Closing pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/71
DRILL-2961: Throw SQLException when attempting to set query timeout
Statement.setQueryTimeout(int seconds) is a No-Op, leading the user to
believe that a timeout has been set. This provides the
401 - 451 of 451 matches
Mail list logo