Github user nagarajanchinnasamy closed the pull request at:
https://github.com/apache/drill/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
Closing pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva commits squashed. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r98425957
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java
---
@@ -64,17 +65,45 @@ public void eval
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r98355138
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java
---
@@ -64,17 +65,45 @@ public void eval
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r97721703
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java
---
@@ -64,17 +65,45 @@ public void eval
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva conflicts resolved and rebased on master. Please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva @sudheeshkatkam @julianhyde @paul-rogers Thank You All
for your comments and guidance throughout. It was a nice learning experience
for me :)
I have squashed
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva @sudheeshkatkam I have made the following changes to
support invocation of UDFs without parenthesis.
1. Introduced `isNiladic` option in FunctionTemplate
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
Success :) I could invoke SESSION_ID without parenthesis. Following did the
trick:
1. In DrillSqlOperator, overriding getSyntax method to return
SqlSyntax.FUNCTION_ID
2
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
Sent a mail to Dev list with the findings... issue yet to be resolved:
[Link to the
mail](http://mail-archives.apache.org/mod_mbox/drill-dev/201701.mbox
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva , I have started examining the difference in
implementations of functions like CURRENT_DATE, SYSTEM_USER etc. in Calcite and
the implementation of DrillSqlOperator
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93780471
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java ---
@@ -141,7 +141,7 @@ public FragmentContext(final
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93743678
--- Diff: protocol/src/main/protobuf/User.proto ---
@@ -361,7 +361,7 @@ message ResultColumnMetadata {
optional ColumnSearchability
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93741547
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserProtos.java ---
@@ -25001,7 +25001,7 @@ public Builder
setUpdatability
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93741438
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/DrillClientSystemTest.java
---
@@ -17,6 +17,8 @@
*/
package
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93741386
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java ---
@@ -47,7 +47,7 @@ public static String
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93740038
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -319,4 +319,3 @@ message Jar {
optional string name = 1;
repeated
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93739906
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -343,7 +343,6 @@ public BitToUserHandshake
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93394114
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -255,11 +257,12 @@ void disableReadTimeout
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93267919
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -320,3 +320,17 @@ message Jar {
repeated string function_signature = 2
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93267316
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -320,3 +320,17 @@ message Jar {
repeated string function_signature = 2
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93267171
--- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
@@ -320,3 +320,17 @@ message Jar {
repeated string function_signature = 2
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93266381
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -255,11 +257,12 @@ void disableReadTimeout
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva I have made the changes to:
1. Generate sessionId within the constructor of UserSession
2. Add a builder method in UserSession to construct
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93128753
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -359,12 +363,14 @@ public BitToUserHandshake
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93128502
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -343,10 +346,11 @@ public BitToUserHandshake
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r93128266
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java
---
@@ -64,17 +65,45 @@ public void eval
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva Sorry for the refactoring before consulting some of the
thoughts I had. Thanks for the suggestion to add such changes in separate
commit. Learning the process
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r92933806
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java
---
@@ -27,6 +27,7
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r92933786
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java
---
@@ -55,6 +55,7 @@
import
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r92933707
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java
---
@@ -19,6 +19,8 @@
import
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@julianhyde Thanks for your feedback. But I am not sure how to make a
function not to have `()`. Need help.
---
If your project is set up for it, you can reply to this email and have
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva @sudheeshkatkam I have made further re-factoring. Please
review the changes.
Main changes are:
1. Introduced *`UserSessionContext`* class to encapsulate all
Github user nagarajanchinnasamy closed the pull request at:
https://github.com/apache/drill/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user nagarajanchinnasamy reopened a pull request:
https://github.com/apache/drill/pull/685
Drill 5043: Function that returns a unique id per session/connection
similar to MySQL's CONNECTION_ID()
Please check [DRILL-5043](https://issues.apache.org/jira/browse/DRILL-5043
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@sudheeshkatkam changes suggested are incorporated and committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r92617289
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java
---
@@ -77,4 +76,28 @@ public void eval
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva
- squashing done :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@arina-ielchiieva
- minor changes made
- commit message amended
- unit tests added
But am not sure If I have done the squashing correctly!!! tried `rebase
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@paul-rogers @arina-ielchiieva I have incorporated only the session id
related changes from #666. Checked in embedded mode and it does work. Yet to
check in distributed mode
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r91826699
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -115,6 +118,7 @@ public UserSession build
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@paul-rogers as per my requirement the SessionId needs to be unique. Thats
all. It does not have to be a monotonically increasing sequence. So, UUID
should be fine. Will look into #666
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r91685705
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -115,6 +118,7 @@ public UserSession build
GitHub user nagarajanchinnasamy opened a pull request:
https://github.com/apache/drill/pull/685
Drill 5043: Function that returns a unique id per session/connection
similar to MySQL's CONNECTION_ID()
Please check [DRILL-5043](https://issues.apache.org/jira/browse/DRILL-5043
45 matches
Mail list logo
