[GitHub] drill issue #1037: DRILL-5968: Add support for empty service_host user prope...

2017-11-16 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/1037 Thanks, @parthchandra ! ---

[GitHub] drill issue #1037: DRILL-5968: Add support for empty service_host user prope...

2017-11-16 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/1037 @parthchandra We should get this in for 1.12? ---

[GitHub] drill pull request #1037: DRILL-5968: Add support for empty service_host use...

2017-11-16 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/1037#discussion_r151515278 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -28,6 +28,18 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties

[GitHub] drill pull request #1039: DRILL-5584: Add branding and versioning informatio...

2017-11-15 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/1039#discussion_r151329816 --- Diff: contrib/native/client/src/clientlib/env.h.in --- @@ -30,6 +30,11 @@ #define GIT_SHA_PROP @GIT_SHA_PROP@ #define GIT_COMMIT_PROP

[GitHub] drill pull request #1039: DRILL-5584: Add branding and versioning informatio...

2017-11-15 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/1039 DRILL-5584: Add branding and versioning information for windows C++ C… …lient. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request #1037: DRILL-5968: Add support for empty service_host use...

2017-11-15 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/1037#discussion_r151282197 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -28,6 +28,20 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties

[GitHub] drill pull request #1037: DRILL-5968: Add support for empty service_host use...

2017-11-15 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/1037#discussion_r151282112 --- Diff: contrib/native/client/src/include/drill/userProperties.hpp --- @@ -28,6 +28,20 @@ class DECLSPEC_DRILL_CLIENT DrillUserProperties

[GitHub] drill pull request #1037: DRILL-5968: Add support for empty service_host use...

2017-11-14 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/1037 DRILL-5968: Add support for empty service_host user property You can merge this pull request into a Git repository by running: $ git pull https://github.com/superbstreak/drill DRILL

[GitHub] drill issue #992: DRILL-5873: (C++ Client) Improve SASL error reporting.

2017-10-13 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/992 @parthchandra Thanks for adding this! ---

[GitHub] drill pull request #950: DRILL-5431: SSL Support

2017-09-20 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/950#discussion_r140129825 --- Diff: contrib/native/client/src/include/drill/common.hpp --- @@ -163,9 +170,13 @@ typedef enum{ #define USERPROP_USERNAME "use

[GitHub] drill pull request #880: DRILL-5678: Undefined behavior due to un-initialize...

2017-07-18 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/880 DRILL-5678: Undefined behavior due to un-initialized values in Server… …MetaContext You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request #878: DRILL-5675: Drill C++ Client reports incorrect date...

2017-07-17 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/878 DRILL-5675: Drill C++ Client reports incorrect datetime Literals Sup… …port Metadata You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill issue #876: DRILL-5659: Fix error code checking in reading from socket

2017-07-13 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/876 Thanks, @parthchandra! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill issue #873: DRILL-5668: Fix C++ connector crash on error

2017-07-11 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/873 Thanks for the patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request #850: DRILL-5541: C++ Client Crashes During Simple "Man i...

2017-06-05 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/850 DRILL-5541: C++ Client Crashes During Simple "Man in the Middle" Atta… …ck Test with Exploitable Write AV You can merge this pull request into a Git repository by running:

[GitHub] drill issue #791: DRILL-5369: Add initializer for ServerMetaContext

2017-03-20 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/791 Thanks @laurentgo for the fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill issue #772: DRILL-5316: Check drillbits size before we attempt to acce...

2017-03-08 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/772 @sohami please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request #772: DRILL-5316: Check drillbitsVector count from zoo_ge...

2017-03-07 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/772#discussion_r104627768 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -86,6 +86,9 @@ connectionStatus_t DrillClientImpl::connect(const char* connStr

[GitHub] drill pull request #772: DRILL-5316: Check drillbitsVector count from zoo_ge...

2017-03-07 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/772#discussion_r104607726 --- Diff: contrib/native/client/src/clientlib/zookeeperClient.cpp --- @@ -138,6 +138,11 @@ int ZookeeperClient::getAllDrillbits(const std::string

[GitHub] drill pull request #772: DRILL-5316: Check drillbitsVector count from zoo_ge...

2017-03-06 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/772 DRILL-5316: Check drillbitsVector count from zoo_get_children before … …we attempt to access the vector element You can merge this pull request into a Git repository by running: $ git

[GitHub] drill pull request #771: DRILL-5315: Address small typo in the comment

2017-03-06 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/771 DRILL-5315: Address small typo in the comment You can merge this pull request into a Git repository by running: $ git pull https://github.com/superbstreak/drill DRILL-5315 Alternatively

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-15 Thread superbstreak
Github user superbstreak commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101409917 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill issue #733: DRILL-5221: Send cancel message as soon as possible in C++...

2017-02-03 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/733 Did some testing. This allow query to cancel more precisely in certain flows. Good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] drill issue #698: DRILL-5136: Server unable to prepare non SELECT queries

2016-12-27 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/698 Closing PR due to widen scope. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request #698: DRILL-5136: Server unable to prepare non SELECT que...

2016-12-27 Thread superbstreak
Github user superbstreak closed the pull request at: https://github.com/apache/drill/pull/698 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request #698: DRILL-5136: Server unable to prepare non SELECT que...

2016-12-19 Thread superbstreak
GitHub user superbstreak opened a pull request: https://github.com/apache/drill/pull/698 DRILL-5136: Server unable to prepare non SELECT queries Currently, the server makes every incoming queries a limit 0 query during server prepare. This is causing some non select queries to fail

[GitHub] drill issue #602: Improve Drill C++ connector

2016-10-17 Thread superbstreak
Github user superbstreak commented on the issue: https://github.com/apache/drill/pull/602 **Mac Environment:** OS: OSX 10.8.5 COMPILER=xcode5_1 **Libraries:** Zookeeper: 3.4.6 (patched) boost: 1.57.0 protobuf: 2.5.0rc1 **For libc