Re: [DISCUSS] 1.14.0 release

2018-07-19 Thread Boaz Ben-Zvi
  That cracked blocker is DRILL-6453 (not 6475 ...), sorry ..   Boaz On 7/19/18 2:32 AM, Boaz Ben-Zvi wrote:  Hi Charles, I merged the DRILL-6104 work into the Apache master; thanks for your useful contribution, it will be included in 1.14. We may have just cracked the blocker

Re: [DISCUSS] 1.14.0 release

2018-07-19 Thread Boaz Ben-Zvi
 Hi Charles, I merged the DRILL-6104 work into the Apache master; thanks for your useful contribution, it will be included in 1.14. We may have just cracked the blocker DRILL-6475 , so we hopefully could start the RC process tomorrow.     Thanks,   Boaz On 7/18/18 8:42 PM,

Re: [DISCUSS] 1.14.0 release

2018-07-18 Thread Charles Givre
HI Boaz, DRILL-6104 is ready to release. Do you think we’ll have an RC this week? Thanks, — C > On Jul 2, 2018, at 23:01, Boaz Ben-Zvi wrote: > > Let's try to make progress on the 1.14 release, aiming for a Release > Candidate towards the end of this week (a little ambitious, with the July

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Timothy Farkas
Hi Boaz, I looked at DRILL-6606 and have updated the ticket, I should have a fix monday. It looks like a minor logical error. I'm not clear on why you suspect DRILL-6453 is cause by batch sniffing, perhaps we can discuss offline. Thanks, Tim On Fri, Jul 13, 2018 at 2:01 PM, Arina Yelchiyeva <

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Arina Yelchiyeva
Two more regressions: https://issues.apache.org/jira/browse/DRILL-6603 https://issues.apache.org/jira/browse/DRILL-6605 Kind regards, Arina On Fri, Jul 13, 2018 at 11:25 PM Sorabh Hamirwasia wrote: > Hi Boaz, > Couple of updates. > > *Merged In:* > DRILL-6542: (May be Ready2Commit soon)

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Sorabh Hamirwasia
Hi Boaz, Couple of updates. *Merged In:* DRILL-6542: (May be Ready2Commit soon) IndexOutOfBounds exception for multilevel lateral ((Sorabh / Parth)) *In Review:* *DRILL-6475: Query with UNNEST causes a Null Pointer . (( Hanumath ))* Thanks, Sorabh On Fri, Jul 13, 2018 at 1:17 PM, Parth

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Parth Chandra
Our (unwritten) rule has been that a commit cannot even go in unless unit _and_ regression tests pass. Releases are stricter, all tests, longevity tests, UI, are required to pass. In addition, any performance regression needs to be discussed. So far we have not made any exceptions, but that is

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Vlad Rozov
My 2 cents: From Apache point of view it is OK to do a release even if unit tests do not pass at all or there is a large number of regression introduced. Apache release is a source release and as long as it compiles and does not have license issues, it is up to community (PMC) to decide on

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Aman Sinha
I would say we have to take a measured approach to this and decide on a case-by-case which issue is a show stopper. While of course we have to make every effort to avoid regression, we cannot claim that a particular release will not cause any regression. I believe there are 1+ passing tests,

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Arina Yelchiyeva
We cannot release with existing regressions, especially taking into account the there are not minor issues. As far as I understand reverting is not an option since hash join spill feature are extended into several commits + subsequent fixes. I guess we need to consider postponing the release until

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Boaz Ben-Zvi
(Guessing ...) It is possible that the root cause for DRILL-6606 is similar to that in DRILL-6453 -- that is the new "early sniffing" in the Hash-Join, which repeatedly invokes next() on the two "children" of the join *during schema discovery* until non-empty data is returned (or NONE, STOP,

Re: [DISCUSS] 1.14.0 release

2018-07-13 Thread Arina Yelchiyeva
During implementing late limit 0 optimization, Bohdan has found one more regression after Hash Join spill to disk. https://issues.apache.org/jira/browse/DRILL-6606 Boaz please take a look. Kind regards, Arina On Fri, Jul 13, 2018 at 4:34 AM Boaz Ben-Zvi wrote: >We are getting close to a

Re: [DISCUSS] 1.14.0 release

2018-07-12 Thread Boaz Ben-Zvi
  We are getting close to a Release Candidate, though some issues are still pending, and we need to make decisions soon. Soliciting opinions -- which of the following issues should be considered a RELEASE BLOCKER for 1.14: = OPEN == OPEN - DRILL-6453 : TPCDS query 72 is Hanging (on

Re: [DISCUSS] 1.14.0 release

2018-07-10 Thread Kunal Khatua
I have 2 fixes (minor UX and a trivial SysTable patch) that are needed for 1.14.0 DRILL-6583 (already has a +1)  DRILL-6588 (pending review) ~Kunal On 7/10/2018 12:02:36 AM, Arina Yelchiyeva wrote: Hi Boaz, as far as I understand you either move this feature to 1.15 or wait with building RC

Re: [DISCUSS] 1.14.0 release

2018-07-10 Thread Arina Yelchiyeva
Hi Boaz, as far as I understand you either move this feature to 1.15 or wait with building RC until it's finished. Adding changes later means, you'll have to build one more RC candidate and conduct one more vote. I think making people voting twice instead of once, it's not a good thing :) Kind

Re: [DISCUSS] 1.14.0 release

2018-07-09 Thread Boaz Ben-Zvi
 Hi Charles,     The main reason for rushing a Release Candidate is that we could give it enough testing. Given that DRILL-6104 is a separate feature, with almost no impact on the current code, then it seems low risk to add it a few days later.   Anyone has an objection ? Boaz On

Re: [DISCUSS] 1.14.0 release

2018-07-09 Thread Charles Givre
Hi Boaz, I’m traveling at the moment, but I can have DRILL-6104 back in Paul’s hands by the end of the week. —C > On Jul 10, 2018, at 00:53, Boaz Ben-Zvi wrote: > > We are making progress towards 1.14. > > Let's aim for a Release Candidate branch off on Thursday (July 12) !!! > > Below

Re: [DISCUSS] 1.14.0 release

2018-07-09 Thread Boaz Ben-Zvi
  We are making progress towards 1.14. Let's aim for a Release Candidate branch off on  Thursday (July 12)  !!! Below are the unfinished cases; can most be completed and checked in by 7/12 ? (( Relevant people:     Abhishek, Arina, Boaz, Charles, Hanumath, Jean-Blas, Karthik, Kunal,    

Re: [DISCUSS] 1.14.0 release

2018-07-06 Thread Padma Penumarthy
If possible, please include PR 1363 in this release so we can complete our batch sizing work (except for exchange operators) DRILL-6549: batch sizing for nested loop join. Thanks Padma On Fri, Jul 6, 2018 at 2:51 PM, Pritesh Maker wrote: > Here is the release 1.14 dashboard

Re: [DISCUSS] 1.14.0 release

2018-07-06 Thread Charles Givre
Hi Boaz, @Paul-Rogers said he would review DRILL-6104 over the weekend, so hopefully this will be ready to go, and I made a mistake in the unit tests for DRILL-6519, but fixed it this week, so pending one final check it should be good to go. > On Jul 6, 2018, at 14:54, Boaz Ben-Zvi wrote:

Re: [DISCUSS] 1.14.0 release

2018-07-06 Thread Pritesh Maker
Here is the release 1.14 dashboard (https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12332463 ) and agile board (https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=185) I believe Volodymyr is targeting DRILL-6422 (Guava update) for 1.15 release so it shouldn't

Re: [DISCUSS] 1.14.0 release

2018-07-02 Thread Khurram Faraaz
Do we plan to fix this one too, because this is a regression from Apache Drill 1.13.0. https://issues.apache.org/jira/browse/DRILL-6453 On Mon, Jul 2, 2018 at 9:33 PM, Kunal Khatua wrote: > DRILL-6570 seems like a must-have (release blocker, IMHO). > On 7/2/2018 8:02:00 PM, Boaz Ben-Zvi wrote:

Re: [DISCUSS] 1.14.0 release

2018-07-02 Thread Kunal Khatua
DRILL-6570 seems like a must-have (release blocker, IMHO). On 7/2/2018 8:02:00 PM, Boaz Ben-Zvi wrote: Let's try to make progress on the 1.14 release, aiming for a Release Candidate towards the end of this week (a little ambitious, with the July 4th and people on vacations). Current Status of

Re: [DISCUSS] 1.14.0 release

2018-07-02 Thread Boaz Ben-Zvi
  Let's try to make progress on the 1.14 release, aiming for a Release Candidate towards the end of this week (a little ambitious, with the July 4th and people on vacations). Current Status of the previously requested Jiras: == In Progress - DRILL-6104: Generic

Re: [DISCUSS] 1.14.0 release

2018-06-14 Thread Abhishek Ravi
DRILL-5977 is in review and I'm planning to get it in for this release. Regards, Abhishek On Wed, Jun 13, 2018 at 7:50 PM Padma Penumarthy wrote: > I am planning to open couple of batch sizing PRs this week that I would > like to get in. > > Thanks > Padma > > > > On Jun 13, 2018, at 11:59

Re: [DISCUSS] 1.14.0 release

2018-06-13 Thread Padma Penumarthy
I am planning to open couple of batch sizing PRs this week that I would like to get in. Thanks Padma > On Jun 13, 2018, at 11:59 AM, Vlad Rozov wrote: > > DRILL-6422: Update guava to 23.0 and shade it (PR in review) > DRILL-6353: Upgrade Parquet MR dependencies (ready-to-commit) > > Thank

Re: [DISCUSS] 1.14.0 release

2018-06-13 Thread Vlad Rozov
DRILL-6422: Update guava to 23.0 and shade it (PR in review) DRILL-6353: Upgrade Parquet MR dependencies (ready-to-commit) Thank you, Vlad On 6/12/18 17:16, Boaz Ben-Zvi wrote: Hello Drillers,   Nearly three months have passed since the 1.13.0 release, and it is time to start planning for

Re: [DISCUSS] 1.14.0 release

2018-06-12 Thread Charles Givre
I’d like to complete DRILL-6104 and get that in. —C > On Jun 12, 2018, at 20:16, Boaz Ben-Zvi wrote: > > Hello Drillers, > Nearly three months have passed since the 1.13.0 release, and it is time to > start planning for the 1.14.0 ; I volunteer to manage the new release. > If there is any

Re: [DISCUSS] 1.14.0 release

2018-06-12 Thread Parth Chandra
Some of us are trying to finish DRILL-5999 (and related subtasks) in time for 1.14. We have a couple of weeks' worth of work left (or so we think). Can you keep this on your list of items to track and we can make a call as we get closer to the release date. On Tue, Jun 12, 2018 at 5:16 PM, Boaz

[DISCUSS] 1.14.0 release

2018-06-12 Thread Boaz Ben-Zvi
Hello Drillers,   Nearly three months have passed since the 1.13.0 release, and it is time to start planning for the 1.14.0 ; I volunteer to manage the new release.   If there is any ongoing work not yet committed into the Apache Drill master, that you strongly feel MUST be included in the 1.14