[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-10 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-596993199 I think we should still merge this PR since in Drill we don't have list of browsers we

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-05 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-595195005 @dobesv tried your suggestions, unfortunately in Safari it did not make any difference.

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-03 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-593863200 @dobesv thanks for the video, re-checked one more time. Looks like issue is Safari

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-02 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-593404037 @dobesv looks like you changes broke functionality which indicates query execution

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-02 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-593352575 +1, LGTM. This is an

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-28 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-592533482 Restarted CI jobs, unfortunately newly added tests keep failing, though they pass on

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-27 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-591850706 @dobesv please look into Jira description

[GitHub] [drill] arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-26 Thread GitBox
arina-ielchiieva commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-591366673 @dobesv won't think break original behavior? Please see original Jira