[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-28 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339515560 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-28 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339515525 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-28 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339502837 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-28 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339500656 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-28 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339500487 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-28 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339500436 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-28 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339500656 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-27 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339344164 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-27 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339344160 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-27 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339344178 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,59 @@ +# Excel Format Plugin +This plugin enables

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-26 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339323208 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-25 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339175857 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-25 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339173181 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-25 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339172907 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-25 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339039457 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-25 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339039578 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-25 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339032064 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-25 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r339021351 ## File path: contrib/format-excel/pom.xml ## @@ -0,0 +1,115 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-24 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338761283 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-24 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338761283 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-24 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338761283 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-24 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338733373 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-23 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338094170 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-23 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338085104 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,54 @@ +# Excel Format Plugin +This plugin enables

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-23 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338087569 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-23 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338087427 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,54 @@ +# Excel Format Plugin +This plugin enables

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-23 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338085262 ## File path: contrib/format-excel/README.md ## @@ -0,0 +1,54 @@ +# Excel Format Plugin +This plugin enables

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-23 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338081565 ## File path: contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-23 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338080643 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-23 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r338080508 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-20 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336790500 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-20 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336790484 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-17 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335699083 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-17 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335700464 ## File path: protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ## @@ -980,6 +988,7 @@

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-17 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335698017 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-17 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335697332 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-17 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335694604 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-17 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335696309 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-16 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335650653 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-16 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335650653 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-16 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335443550 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335251439 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335251398 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335251156 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335250975 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335248736 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335247011 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatPlugin.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335246885 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335246864 ## File path: contrib/format-excel/pom.xml ## @@ -0,0 +1,112 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335246907 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335245329 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335245040 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##

[GitHub] [drill] cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-15 Thread GitBox
cgivre commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r335245040 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelFormatConfig.java ##