cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419816763
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,83 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read and
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419816168
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419814031
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419813495
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419812878
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419812810
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419812606
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419812106
##
File path: contrib/format-spss/pom.xml
##
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419811899
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,83 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read and
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419668523
##
File path: pom.xml
##
@@ -359,6 +359,7 @@
**/*.pcap
**/*.log1
**/*.log2
+**/*.sav
Review comment:
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419037351
##
File path: exec/java-exec/src/test/java/org/apache/drill/test/ClusterTest.java
##
@@ -125,4 +139,29 @@ public static void run(String query, Object...
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419037264
##
File path: exec/java-exec/src/test/java/org/apache/drill/test/ClusterTest.java
##
@@ -125,4 +139,29 @@ public static void run(String query, Object...
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419036988
##
File path: protocol/src/main/protobuf/UserBitShared.proto
##
@@ -379,7 +379,11 @@ enum CoreOperatorType {
SHP_SUB_SCAN = 65;
METADATA_HANDLER = 66;
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419036349
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419036031
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419035541
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419035598
##
File path: contrib/format-spss/src/main/resources/bootstrap-format-plugins.json
##
@@ -0,0 +1,37 @@
+{
+ "storage":{
Review comment:
Fixed
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419035528
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419035267
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419034736
##
File path:
contrib/format-spss/src/main/java/org/apache/drill/exec/store/spss/SpssBatchReader.java
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419034417
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,87 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read and
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419034264
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,87 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read and
cgivre commented on a change in pull request #2067:
URL: https://github.com/apache/drill/pull/2067#discussion_r419034126
##
File path: contrib/format-spss/README.md
##
@@ -0,0 +1,87 @@
+# Format Plugin for SPSS (SAV) Files
+This format plugin enables Apache Drill to read and
23 matches
Mail list logo
