[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-03-03 Thread GitBox
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-594289758 @akkapur Sorry, I misunderstood the intent of that change. The unit tests are very thorough and let's leave them for the time being.

[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-03-01 Thread GitBox
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-593145031 @akkapur Thanks for the updates. I didn't run all the unit tests yet, but I was successfully able to query Druid via Drill and it

[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-02-28 Thread GitBox
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-592706812 I suspect the reason the unit tests are failing is that something is not configured correctly in the test environment, but I don't know

[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-02-28 Thread GitBox
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-592706368 @akkapur Thanks for submitting this plugin. I started my review and ran into some issues. Firstly the unit tests that do not depend

[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-02-09 Thread GitBox
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-583947585 @akkapur Can you please post this question to the dev alias? (dev@drill.apache.org) I'm not familiar enough with the testing

[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2020-02-07 Thread GitBox
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-583446233 @akkapur I just updated the PR to use the latest build of Drill and rebuilt the protobufs.

[GitHub] [drill] cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid

2019-11-17 Thread GitBox
cgivre commented on issue #1888: DRILL-5956: Add Storage Plugin for Apache Druid URL: https://github.com/apache/drill/pull/1888#issuecomment-554750018 @akkapur I don't think you'd need this, but in case anyone else is reading this, @paul-rogers wrote a very nice tutorial about the