cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP
REST API
URL: https://github.com/apache/drill/pull/1892#issuecomment-612917400
@arina-ielchiieva
Thank you for the review. I made the final revisions to this code and
squashed the commits. Are we good to
cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP
REST API
URL: https://github.com/apache/drill/pull/1892#issuecomment-612647384
@arina-ielchiieva
I addressed your review comments. Could you please take a final look and
let me know if we are good to go?
cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP
REST API
URL: https://github.com/apache/drill/pull/1892#issuecomment-612551648
@paul-rogers
I rebased this branch on master.
This is an
cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP
REST API
URL: https://github.com/apache/drill/pull/1892#issuecomment-608197878
@paul-rogers
I made some minor code cleanup and changes to the docs. Commits are
squashed.
cgivre commented on issue #1892: DRILL-7437: Storage Plugin for Generic HTTP
REST API
URL: https://github.com/apache/drill/pull/1892#issuecomment-594170892
@paul-rogers
I believe this is ready for round 2 of review. My only question at this
point is around the `toString()` methods.
cgivre commented on issue #1892: Drill-7437: Storage Plugin for Generic HTTP
REST API
URL: https://github.com/apache/drill/pull/1892#issuecomment-560381063
@arina-ielchiieva
This PR is a draft, but yes, it would make sense to wait until #1914 and
#1913 are committed.