[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-10 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-597268755 @arina-ielchiieva Thanks. Sorry I didn't have the resources to fix the Safari issue - maybe

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-03 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-594184068 Hmm Safari, that does make it a bit more tricky since I'm using Windows & Linux only currently.

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-02 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-593528077 @arina-ielchiieva It still shows that for me, do you have any errors in the JavaScript console?

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-03-02 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-593501806 @arina-ielchiieva Strange, I remember that working when I tested it before, I'll take another

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-29 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-592978391 In the CI environment I had to pull the query profile from the history but in local development

Re: [GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-28 Thread Paul Rogers
Oh my! This related to my change. We had a "format" method which build and threw the exception. I changed that to just build and return the exception, then I changed all callers to do the throwing. I also changed the method name to "create". The mystery is how the code passed the build and

Re: [GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-28 Thread Paul Rogers
+1 Thanks, - Paul On Friday, February 28, 2020, 12:15:38 PM PST, GitBox wrote: dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-592709083   Is

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-28 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-592775267 Looks like I fixed the issue with the builds, except that the build timed out this time.

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-28 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-592709083 Is there any reason not to add `-DtrimStackTrace=false` to the build options in the github

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-28 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-592708567 I ran it locally using the `act` tool to simulate a github build and got a full stack trace:

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-28 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-592606120 I fixed the alignment issue:

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-27 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-592100942 @arina-ielchiieva If the userName parameter is not provided, it will behave as before. The only

[GitHub] [drill] dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page

2020-02-26 Thread GitBox
dobesv commented on issue #1994: DRILL-7203: Accept impersonation userName as form field & fix back button for query page URL: https://github.com/apache/drill/pull/1994#issuecomment-591631762 Which original behavior are you thinking of ? Maybe you could write a test case to show what