[GitHub] cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds

2019-03-01 Thread GitBox
cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds URL: https://github.com/apache/drill/pull/1665#issuecomment-468785456 Hi @jculio You acutally don't have to create a new file. Just add a line to the `TestPcapDecoder`. All you have to do is add: ```

[GitHub] cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds

2019-03-01 Thread GitBox
cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds URL: https://github.com/apache/drill/pull/1665#issuecomment-468681971 HI @jculio Take a look at:

[GitHub] cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds

2019-02-28 Thread GitBox
cgivre commented on issue #1665: DRILL-7054: timestamp in milliseconds URL: https://github.com/apache/drill/pull/1665#issuecomment-468514038 I can do review if you'd like. This looks good, but can we add a unit test? Also, we should probably do this for PCAP-NG if it doesn't already, but