[GitHub] drill issue #1049: DRILL-5971: Fix INT64, INT32 logical types in complex par...

2018-01-09 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1049 @parthchandra, thanks for the pull request! LGTM, +1. ---

[GitHub] drill issue #1049: DRILL-5971: Fix INT64, INT32 logical types in complex par...

2017-12-18 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1049 @vvysotskyi please review - added fixes for date time and interval types, fixed the reading of dictionary encoded fixed width array types (including int96), fixed object representation of

[GitHub] drill issue #1049: DRILL-5971: Fix INT64, INT32 logical types in complex par...

2017-11-28 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1049 Updated the PR to include all the remaining logical int types. While generating the test file for the unit test, found that some of the types were missing from the fast parquet reader so added

[GitHub] drill issue #1049: DRILL-5971: Fix INT64, INT32 logical types in complex par...

2017-11-23 Thread vvysotskyi
Github user vvysotskyi commented on the issue: https://github.com/apache/drill/pull/1049 LGTM, +1. Except `INT_32` and `INT_64` parquet can contain other logical numeric types: `UINT_8`, `UINT_16`, `UINT_32`, `UINT_64`, `INT_8`, `INT_16`[1]. It would be great to add support for these

[GitHub] drill issue #1049: DRILL-5971: Fix INT64, INT32 logical types in complex par...

2017-11-23 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1049 @vvysotskyi please review. ---