[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user jiang-wu commented on the issue: https://github.com/apache/drill/pull/1184 @parthchandra @vdiravka I finally completed the changes on using Local{Date|Time|DateTime}. I made a new clean pull request for that here: https://github.com/apache/drill/pull/1247 ---

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1184 ``` What do you mean by "Json representation"? ``` Sorry, my mistake, got all tangled up. ``` we may want to further translate the Local [Date|Time|DateTime] objects

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user jiang-wu commented on the issue: https://github.com/apache/drill/pull/1184 @parthchandra Just to clarify on the JDBC comment. What do you mean by "Json representation"? Do you instead mean the "Local[Date|Time]" class representation? There are no "Json" being returned

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1184 Putting aside the discussion on date/time/timezone for the moment, @jiang-wu let's say getObject returns to you an object that implements java.sql.{Struct|Array}. You now use the Struct|Array

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1184 @parthchandra, the point about the birthday is that is is one of those dates that is implied relative to where you are. You celebrate it the same day regardless of where you are in the world.

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user jiang-wu commented on the issue: https://github.com/apache/drill/pull/1184 Actually, JDBC representation is not he hard problem here. I ran into most of the problems dealing with the timezones surrounding the data|time|timestamp. java.sql.Struct and Array are interfaces

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1184 > But, if April 15 is your birthday, it is your birthday in all timezones. We don't say your birthday (or order date, or newspaper issue date or...) is one day in, say London and another day

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user jiang-wu commented on the issue: https://github.com/apache/drill/pull/1184 Yes. There are at least two issues. One is about how Drill represent Date, Time, Timestamp internally using a UTC based instant representation and fudges the timezone in order to make

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1184 One additional note. We noted that JDBC does not support the idea of a nested tuple (a Drill "map".) JDBC does support columns that return a Java object. To bridge the gap, Drill returns a Map

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1184 Sorry, coming late. There seem to be two problems. The original "nested column" issue is an artifact of the JDBC driver. In Drill, a Map (the thing that contains your nested column) is just a

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user jiang-wu commented on the issue: https://github.com/apache/drill/pull/1184 I was out of town last week. Will work on the type change to Java 8 Local[Data|Time|Timestamp] this week and then notify you when it is done. ---

Re: [GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

I'm assuming jiang-wu will update the PR to use the Joda/JDK classes when he gets the time? On Thu, Apr 19, 2018 at 6:34 AM, arina-ielchiieva wrote: > Github user arina-ielchiieva commented on the issue: > > https://github.com/apache/drill/pull/1184 > > So what the

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1184 So what the next steps required before we merge this PR? ---

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1184 I think that would be best. ---

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user jiang-wu commented on the issue: https://github.com/apache/drill/pull/1184 Checked in the patch for the latest master. The test seems to be passing now. But if we want to change the code to use joda java.time Local[Time|Date|TimeStamp], then we can hold off any merge

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/1184 Can you check the unit tests after rebasing? I applied the PR to the latest master and get errors in the same tests. Thanks. ---

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user jiang-wu commented on the issue: https://github.com/apache/drill/pull/1184 The unit test failure is due to additional changes in master after the pull request is made. I can merge and update on the branch to fix them. ---

[GitHub] drill issue #1184: DRILL-6242 - Use java.sql.[Date|Time|Timestamp] classes t...

Github user priteshm commented on the issue: https://github.com/apache/drill/pull/1184 @parthchandra can you please review it. @jiang-wu Parth is traveling and he would be able to review it next week. ---