Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1203
Thanks for all the changes Kunal. LGTM +1
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
@sohami Rebased the commits on top of the latest master (
https://github.com/apache/drill/commit/931b43ec54bf47dcbb4aa9ae4499f37a8f21b408
)
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
@sohami , I've answered your questions in the review.
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1203
@kkhatua I definitely like new design more, thanks for the changes! I see
some unanswered comments from Saurabh in index.ftl, could you please take a
look?
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
Forgot to mention, this also resolves DRILL-5261 because of the protobuf
carrying the HTTP port info.
@arina-ielchiieva / @sohami / @dvjyothsna , please have a review of the
changes.
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
Updated with an additional set of changes.
* Added CPU metrics (obtained from
[OperatingSystemMXBean.getProcessCpuLoad()](https://docs.oracle.com/javase/7/docs/jre/api/management/extension/com/s
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1203
Regarding shutdown button (icon) placement, there are two more options:
1. have separate column for shutdown, when shutdown for the particular
drillbits are unavailable, show disabled but
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
Latest screenshot with the power button,
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
Will add some new screenshots.
In the meanwhile, I was thinking of reduce the 'SHUTDOWN' button to just
the power Symbol, because we already have the 'STATUS' field. The single button
does look
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1203
@sohami could you please also review this PR (it contains some changes with
port hunting, you might be more familiar with)?
---
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1203
Some more points:
1. Please add updated screenshots.
2. Since we have only one shutdown button, we should consider redesigning,
it's position, since it looks really strange:
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
@arina-ielchiieva / @dvjyothsna
Updated the PR with changes based on the comments. Could you please review
and let me know what else would need to be fixed.
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
@arina-ielchiieva You're correct about the inability to shutdown other
Drillbits from the WebUI. But, from what @dvjyothsna explained, it seems that
this was the result of a technical hurdle with HTT
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1203
Before the review I guess we need to clarify one thing. After DRILL-6044
Shutdown button was shown only for the current drillbit. As far as I
understood, you cannot shutdown other drillbits
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
@arina-ielchiieva could you please review this?
---
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1203
**PopOut to open in new window:**
Tooltip describing the new columns
---
17 matches
Mail list logo
