[GitHub] drill issue #512: Drill 4573 fix issue with unicode chars

2016-06-15 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/512 I did the following small changes to this PR, and I'm going to rebase and re-run the regression suite before merge this PR. 1) fix one bug which causes regression failure (IOBE). 2) add

[GitHub] drill issue #512: Drill 4573 fix issue with unicode chars

2016-06-13 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/512 @jcmcote , Overall the patch looks good to me. Once you revise the code, I'll run the regression and merge the code if no problem is found. Thanks for your patch! --- If your project is

[GitHub] drill issue #512: Drill 4573 fix issue with unicode chars

2016-06-03 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/512 @jcmcote , thanks for the new PR. I'll take a look tomorrow, and let you know my feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub