Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/788
It's fine to have example in a follow-up PR.
I was trying to see if I can use new operator/sub-operator test framework
for the schema change task I'm doing. That requires to work with one
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/788
One of the key reasons for creating tests is that they show how to use an
API. In this case, the associated tests show how to use the row set
abstractions to create a schema, populate a row set
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/788
Revised the commit header. Note that the commit messages also identifies
that this PR is dependent on DRILL-5323, and so this PR must be committed after
DRILL-5323.
Sorry for the
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/788
Please see the initial comment which identifies that this PR depends on
several others. Two have been done, only DRILL-5323 remains. Please commit
DRILL-5323 first, then this one.
Note
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/788
I am confused by your comment. Which should be committed first, 5318 or
5323? Your comments says 5318, but the commit message for 5318 and the fact
that 5318 is based on 5323 suggests 5323
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/788
Rebased onto DRILL-5318 so that this branch includes the DRILL-5318 code
that this PR depends upon, as well as the additional code required for this PR.
Fixed the merge errors that caused the
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/788
This does not compile. Please fix the errors and squash the commits into
one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/788
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/788
Thanks for the changes. LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
