Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/923
Thanks @paul-rogers squashed and ready to commit. Please merge this change
before my other PR https://github.com/apache/drill/pull/940
---
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/923
@paul-rogers Finished apply review comments. PR is ready for review again.
---
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/923
@paul-rogers Finished applying comments, and cleanup. It's ready for review
again now.
---
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/923
So it looks like Drill's treatment of OptionType and OptionScope is
inconsistent at present. To correct this I am doing the following:
- OptionType seems to be I'll defined. I think the
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/923
Thanks @paul-rogers I'll work on addressing the comments and talk to you
next week about some questions I have.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/923
@paul-rogers Applied your comments and cleaned up the PR, it should be
ready for review now. If additional work needs to be done to make this easier
to review please let me know.
Thanks,
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/923
Please add a brief description in the PR title.
This PR has commits from other PRs, and has merge conflicts. If this PR
depends on others, then please identify the commits to be reviewed,
