Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
@paul-rogers, @vrozov, thanks for the review. Squashed commits and rebased
onto master.
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/930
Holding of on the merge waiting for review by @vrozov.
---
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/930
The proposal from @vrozov makes sense to me. As long as Lilith is not
completely disabled, I'm fine with it.
---
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
I have implemented the proposal of @vrozov to conditionally enable Lilith
appender. I have used `ThresholdFilter` in Lilith appender, so it was not
needed to change all places where it is used.
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/930
We have run unit in our test clusters and I never hear that people
complained that unit tests failed due to Lilith.
---
If your project is set up for it, you can reply to this email and have
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
Yes, we can change hiveserver2 port #, but I think that it would be better
to disable Lilith by default since hiveserver2 port number may be used in the
configs of other applications and it would
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/930
Per this hive doc, seems it's possible to change hiveserver2 port #.
Can you try to change hivesever2# if the other one is hardcoded?
1.
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
@priteshm, as I have mentioned in the Jira
[DRILL-5761](https://issues.apache.org/jira/browse/DRILL-5761), port in Lilith
UI cannot be changed (https://github.com/huxi/lilith/issues/10).
---
If
Github user priteshm commented on the issue:
https://github.com/apache/drill/pull/930
@vvysotskyi is it possible to change the port number for Lilith to avoid
the conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vvysotskyi commented on the issue:
https://github.com/apache/drill/pull/930
Unit tests hang when Lilith application is not running, but when
`ClassicMultiplexSocketAppender` in `logback.xml` is defined and used in the
loggers.
---
If your project is set up for it, you
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/930
I have some concern about this PR.
AFASIK, some of Drill developers use Lilith to debug issues when running
individual unit testcases. If remove it, does it mean people has to manually
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/930
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
12 matches
Mail list logo
