Github user sohami commented on the issue:
https://github.com/apache/drill/pull/959
I have created
[DRILL-5287](https://issues.apache.org/jira/browse/DRILL-5827) for adding tests.
---
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/959
lgtm. +1. @sohami could you pls check with @chunhui-shi if unit tests
were added previously for DRILL-4237 (another skew issue)? If not, could you
create a new JIRA to add such tests, which
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/959
@paul-rogers - I have added few tests and findings using hash32 and hash64
to compute the 32 bit hash codes in JIRA.
---
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/959
The change looks benign. I wonder; do we have a test case that exercises
the hash functions so we can be certain that the fix actually solves the
original problem?
---
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/959
@amansinha100 - Please help to review.
---
