Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/319#issuecomment-172103488
Looks reasonable. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/319
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/319#issuecomment-171842104
+1 . For functional testing we should try to have a similar scenario with
skew in the data for the build side of the HashJoin such that some minor
fragments get 0
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/319#issuecomment-171801351
I changed the merging receiver so it no longer waits for the last batch
when it's an early termination. Unit tests and regression tests are all passing.
GitHub user adeneche opened a pull request:
https://github.com/apache/drill/pull/319
DRILL-3845: PartitionSender doesn't send last batch for receivers that
already terminated
You can merge this pull request into a Git repository by running:
$ git pull
