Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-209081311
In general, I'm against version number checking. We did that in the code
early on but we should be moving towards a capabilities flag approach.
Also agree with
Github user paul-rogers commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208959253
Some other design issues. The idea of a rollling upgrade presupposes that
we can shut down a Drillbit, bring up a new one, and the cluster keeps running.
But, today,
Github user paul-rogers commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208943460
Hi All. Version compatibility is a complex issue. Do we have a design
document that explains our goals and policy? Is the goal to allow rolling
updates of clients?
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59332891
--- Diff:
common/src/main/java/org/apache/drill/common/util/DrillVersionInfo.java ---
@@ -49,10 +53,52 @@ public static String getVersion() {
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59297387
--- Diff:
common/src/main/java/org/apache/drill/common/util/DrillVersionInfo.java ---
@@ -49,10 +53,52 @@ public static String getVersion() {
}
Github user arina-ielchiieva commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208557847
If we add new type to version 1.7, it can't work with version 1.6 where
this type is absent, that's why I am adding support only for +1 version. At
this point
Github user yufeldman commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208554692
Not sure how that comment contradicts with what I said. Adding new feature
in the next version should not break previous version.
> On Apr 11, 2016, at 12:41
Github user arina-ielchiieva commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208521519
I thought it's hard to maintain backward compatibility. Quoting Parth
comment from Jira:
"Drill needs to be able to run queries that depend only on features
Github user yufeldman commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208434359
Should it be +-1, not just +1 ? Otherwise in your scheme 1.9 can work with
2.0, but can not with 1.8, while 1.8 can work with 1.9.
On Mon, Apr 11, 2016 at
Github user arina-ielchiieva commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-208428822
Updated PR.
New implementation approach:
1. we allow to register any drillbit (disregarding the version).
2. instead of getting available endpoints
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59077998
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +209,28 @@ private void
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59065316
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions()
Github user JohnOmernik commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59064857
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions() {
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/474#discussion_r59063793
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions() {
Github user arina-ielchiieva commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-207529907
Drill version is defined from build manifest file [1].
There is no config setting to override it. Though if you want to change
version in "master", you'll
Github user JohnOmernik commented on the pull request:
https://github.com/apache/drill/pull/474#issuecomment-207520784
So how is the version actually set? Is it just the bit to register with
Drill? Is there a config setting that we can set in drill-override that sets
the cluster
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/474
DRILL-4596: Drill should do version check among drillbits
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arina-ielchiieva/drill
17 matches
Mail list logo
