[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-10 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/152#discussion_r39192041 --- Diff: exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java --- @@ -379,6 +379,16 @@ protected static void parseErrorHelper(final String

[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-10 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/152#discussion_r39189463 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/TestWindowFunctions.java --- @@ -165,49 +258,182 @@ public void testWindowGroupByOnView()

[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-10 Thread jinfengni
Github user jinfengni commented on the pull request: https://github.com/apache/drill/pull/152#issuecomment-139324948 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-10 Thread hsuanyi
Github user hsuanyi commented on the pull request: https://github.com/apache/drill/pull/152#issuecomment-139341626 Will report after done with the tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-10 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/152#discussion_r39198057 --- Diff: exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java --- @@ -379,6 +379,16 @@ protected static void parseErrorHelper(final String

[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-10 Thread hsuanyi
Github user hsuanyi commented on the pull request: https://github.com/apache/drill/pull/152#issuecomment-139341107 Addressed jinfengni and sudheeshkatkam 's comments, Thanks!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-09 Thread hsuanyi
Github user hsuanyi closed the pull request at: https://github.com/apache/drill/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: Update Calcite and Add Test cases

2015-09-09 Thread hsuanyi
GitHub user hsuanyi opened a pull request: https://github.com/apache/drill/pull/150 Update Calcite and Add Test cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/hsuanyi/incubator-drill DRILL-TEST Alternatively you can